Uh right, thanks, seems https://we.phorge.it/rPdfe47157d322d3500f5eee204672cdb3d2c32c16 removed all except for this one, and creating an empty portal shows the strings defined in src/applications/search/engine/PhabricatorProfileMenuEngine.php instead.

Last comment promise... but I discovered that renaming to newNoContentView() ... renders something! with:

protected function newNoContentView(array $items) {
  $object = $this->getProfileObject();
  $builtins = $this->getBuiltinProfileItems($object);
  if (count($items) <= count($builtins)) {
    return $this->newEmptyView(
      pht('New Portal'),
      pht('Use "Edit Menu" to add menu items to this portal.'));
  } else {
    return $this->newEmptyView(
      pht('No Portal Content'),
      pht(
        'None of the visible menu items in this portal can render any '.
        'content.'),
    );
  }
}

With:

• line 35 from newNoMenuItemsView to newNoContentView
• line newNoContentView to be adjusted to avoid newNoContentView() (to avoid recursions)

In this case the test plan would be:

• having a portal with nothing: renders first message
• having a portal with just one "Divider": renders second message
• having a portal with something useful (e.g. a Dashboard): shows the Dashboard