Page MenuHomePhorge

speck (Christopher Speck)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 02:58 (141 w, 3 d)
Roles
Administrator
Availability
Available

At my company I investigated code review tools back in 2014/2015 and selected Phabricator. I worked to adopt it into the company and we've used it successfully since then. I have a few minor contributions in the upstream, mainly related to Mercurial, along with some bug reports.

I'm interested in helping to organize the project effort as well as help document existing architecture/code and provide input into architectural design decisions. I will likely have time for some coding as well.

Recent Activity

Mon, Feb 12

speck added a comment to D25502: Make PhabricatorSearchIntField validate its input.

Is it possible to check if anything is relying on this not working with negative numbers?

Mon, Feb 12, 22:56
speck accepted D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

whoops

Mon, Feb 12, 12:23

Sat, Feb 10

speck added a comment to Q108: Phorge and Mermaid Js (Answer 137).

A mermaid-js one could be written based on the old graphviz one:

Sat, Feb 10, 03:54

Fri, Feb 9

speck added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

I haven’t run this specific issue but I have seen other oddities when using my installed arc within the arc or phorge repos. I’m unable to get it to work unless I use the arc that exists along side that phorge repo. That might be similar here.

Fri, Feb 9, 03:15
speck added a comment to T15673: Phorge participation at FOSDEM 2024.

Hahaha I’m just now seeing this. Thank you for putting together the presentation and giving the talk. I enjoy seeing your excitement!

Fri, Feb 9, 03:07 · Blessed Communicators, Phorge
speck added a comment to T15630: Fix Fonts.

I configure my browsers to increase the default font size because my eyes can’t handle the small fonts. Most pages tend to size appropriately but there are some oddities, including Phorge. I’ll grab some screen caps when I’m back on workstation.

Fri, Feb 9, 02:42

Tue, Feb 6

speck closed D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 11:56
speck committed rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows.
T15064: Several arcanist PHP 8.1 compat issues on Windows
Tue, Feb 6, 11:56
speck added a comment to D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.

Both of these failures are edge cases so it does seem likely we wouldn't have found them as quickly. I do still wonder how many Windows users we have.

Tue, Feb 6, 11:54
speck updated the summary of D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 03:42
speck added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 03:42 · PHP 8 support
speck updated the summary of D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:41
speck added a revision to T15011: Build a Phorge Developer Environment: D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:41 · Extension Development
speck added a comment to D25535: T15011: Update support for XHPast on Windows.

The ArcanistBundleTestCase failures are due to diff binary not being present on Windows systems. The tests could be rewritten to utilize git diff instead but would take some effort.

Tue, Feb 6, 03:37
speck updated the diff for D25535: T15011: Update support for XHPast on Windows.

Fix some lints about line length

Tue, Feb 6, 03:13
speck updated the diff for D25535: T15011: Update support for XHPast on Windows.

Fix use of ExecFuture to pass a scalar string as first argument instead of variable.

Tue, Feb 6, 03:10
speck requested review of D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:06
speck edited P29 xhpast-make.bat.
Tue, Feb 6, 02:28
speck added a comment to T15011: Build a Phorge Developer Environment.

I managed to compile xhpast on windows using llvm installed via Scoop. I also have Visual Studio C++ 19 installed which may be required (I saw some suspicious output that indicated that some include files were being pulled from that install somehow).

Tue, Feb 6, 02:17 · Extension Development
speck created P30 xhpast-winbisonflex.bat.
Tue, Feb 6, 02:16
speck created P29 xhpast-make.bat.
Tue, Feb 6, 02:16
speck created P28 unistd.h.
Tue, Feb 6, 02:12
speck added a comment to D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.

I wonder how many Windows users we have. The xhpast linter does not work, and the unit test failures listed here are pre-existing and occur without these changes.

Tue, Feb 6, 00:42
speck requested review of D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 00:38

Mon, Feb 5

speck accepted D25533: Deprecate Fund and Phortune prototype applications.

Almost seems a little too easy

Mon, Feb 5, 22:58

Tue, Jan 30

speck added a comment to D25301: Diffusion: add "Permalink" button.

I’m not sure about Permalink being a top-level button. Maybe under the View Options menu?

Tue, Jan 30, 13:23

Jan 26 2024

speck added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I believe it was originally made for Phacility to accept donations and then process payments for paid support, neither of which we want at Phorge, and I doubt is used elsewhere. Removing seems fine to me.

Jan 26 2024, 20:47
speck accepted D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 26 2024, 20:39
speck added inline comments to D25526: Avoid exception in revision timeline when left diff does not exist.
Jan 26 2024, 14:19

Jan 19 2024

valerio.bozzolan awarded T15322: Footer: specify a default Libre license for Phorge contents a Love token.
Jan 19 2024, 21:00 · Discussion Needed, Governance
speck closed T15322: Footer: specify a default Libre license for Phorge contents as Resolved.
Jan 19 2024, 20:45 · Discussion Needed, Governance
speck claimed T15322: Footer: specify a default Libre license for Phorge contents.
Jan 19 2024, 20:45 · Discussion Needed, Governance
speck added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Is it assumed that using the site will automatically license the user’s content under these, or should there be a line for that?

Jan 19 2024, 18:54 · Discussion Needed, Governance
speck accepted D25521: Adds "Locate File" input to every browse directory view in Diffusion.

Thanks!

Jan 19 2024, 12:36

Jan 18 2024

speck added a comment to T15645: Implement "Locate File" input in Browse view.

@bekay while in this area of code would you have any pointers on these other issues I’d like to fix at some point?

  1. File browse widget doesn’t work unless logged in, for publicly accessible repos
  2. The search results pop up width is often too narrow to show the full results path, and truncates the end of the path instead of beginning.
Jan 18 2024, 23:35 · Diffusion
speck added a comment to D25521: Adds "Locate File" input to every browse directory view in Diffusion.

Looks good! Thank you so much for this!

Jan 18 2024, 23:22
speck added inline comments to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Jan 18 2024, 01:24

Jan 17 2024

speck added inline comments to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Jan 17 2024, 17:37

Jan 14 2024

speck accepted D25516: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types.
Jan 14 2024, 13:43

Jan 13 2024

speck accepted D25514: Correct manual upload of Differential patch with a leading BOM.

Thanks - I did mean as an inline comment in the code but either is good.

Jan 13 2024, 19:58
speck added a comment to D25514: Correct manual upload of Differential patch with a leading BOM.

Is the input to parseDiff guaranteed to be UTF-8 encoded? I don’t have the code on-hand to look up but it’s possible encoding is handled elsewhere — or arc might have a hard requirement for all input to be UTF-8. All mercurial commands run by arcanist are done with a flag to enforce UTF-8.

Jan 13 2024, 15:51
speck added a comment to T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

Jan 13 2024, 15:42 · Differential

Jan 12 2024

speck added inline comments to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Jan 12 2024, 22:51
speck accepted D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Jan 12 2024, 13:23

Jan 11 2024

speck accepted D25494: Fix PHP 8.1 exception creating task when custom select field configured.

Same comment about keeping strlen. Up to you if you want to switch before landing.

Jan 11 2024, 23:25
speck accepted D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

ty

Jan 11 2024, 23:21
speck accepted D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Jan 11 2024, 21:22
speck accepted D25510: Fix invalid CSS property value.
Jan 11 2024, 12:32

Jan 10 2024

speck added a comment to T15566: Make is easier to install Phorge in the smallest case.

I have some containers I put together for development which could provide a place to start
https://github.com/neandrake/phab-dev

Jan 10 2024, 04:21 · Phorge

Jan 7 2024

speck added a comment to D25118: Remarkup: make less internal links open in new tabs.

Also instead of “Goodie” maybe “Helper” or something. Maybe there’s a similar naming elsewhere in the code base

Jan 7 2024, 14:43
speck added a comment to D25118: Remarkup: make less internal links open in new tabs.

I forgot I had this requesting changes. Any idea of the performance hit in markup rendering now that PhutilURI is constructed for every link? I think its constructor does a fair amount.

Jan 7 2024, 14:42

Dec 14 2023

speck accepted D25496: Fix typo.

Thanks!

Dec 14 2023, 12:05

Dec 10 2023

speck added Q97: Unable to submit patch via arc diff (Answer 126).
Dec 10 2023, 23:42
speck added inline comments to D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 01:48

Dec 9 2023

speck added a comment to T15645: Implement "Locate File" input in Browse view.

I’ve been meaning to investigate this. It also has thrown me that it’s not available where you expect it. I do suspect @valerio.bozzolan is right

Dec 9 2023, 23:59 · Diffusion
speck awarded T15645: Implement "Locate File" input in Browse view a Like token.
Dec 9 2023, 23:57 · Diffusion

Dec 7 2023

speck added a comment to D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

It might be safer to do a null check with the strlen check in case the value isn’t a string.

Dec 7 2023, 00:06

Dec 5 2023

speck requested changes to D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

Good catch. I don’t think it would cause an implosion but might result in not applying constraints when it should

Dec 5 2023, 12:18
speck accepted D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Dec 5 2023, 12:04
speck accepted D25487: Fix PHP 8.1 exceptions rendering task when custom select field configured.
Dec 5 2023, 12:03

Dec 4 2023

speck added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

Whitelisting both vs and id sound good.

Dec 4 2023, 19:10

Dec 3 2023

speck added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

I spent only 5 minutes playing around on a diff to see what might make the url change. The diff id is probably the key one I’d be interested in keeping. I don’t know what the other params are for (even vs).

Dec 3 2023, 15:58

Dec 2 2023

speck added a comment to D25483: fix PHP 8 "strlen(null)" when testing the ssh setup.

Hmm that stack trade doesn’t seem to contain the origin of the issue, likely getting lost through error handling or maybe it’s an incomplete stack trace.

Dec 2 2023, 21:41
speck accepted D25484: fix PHP 8 "strlen(null)" when moving paths with missing options.

This seems fine, though I wonder if we should introduce a phutil_empty_string() or phutil_is_empty_string function to avoid the double-negative logic. I think this reads more easily:

if (phutil_empty_string($from)) {
  throw new Exception()
}
Dec 2 2023, 19:10
speck added a comment to D25483: fix PHP 8 "strlen(null)" when testing the ssh setup.

Is there a stacktrace to work from here? I suspect nothing should really be passing null into phutil_encode_log() and there's likely another issue here. I prefer preventing passing null values into this rather than papering over the issue here in the depths of util functions.

Dec 2 2023, 19:07
speck added a comment to D25485: CSS adjustments to Conpherence.

Thank you so much for the header fix that’s been bugging me every time I use conpherence lol

Dec 2 2023, 15:24 · Conpherence

Dec 1 2023

speck added a comment to D25471: Updates for Mercurial's HTTP protocol.

Thanks for staging this @valerio.bozzolan

Dec 1 2023, 01:16
speck closed D25471: Updates for Mercurial's HTTP protocol.
Dec 1 2023, 01:16
speck committed rP99ee9357eff2: Updates for Mercurial's HTTP protocol.
Updates for Mercurial's HTTP protocol
Dec 1 2023, 01:16
speck added inline comments to D25472: Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use junit output rather than json..
Dec 1 2023, 01:14
speck added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

6 year old in-your-face unreported bugs like these make me wonder how many people use Phabricator/Phorge :-(

It's not many, but this issue would be specific to anyone using Phabricator/Phorge for PHP development, which is likely Phab/Phorge itself is close to 100% of that market. And Phab/Phorge also itself has its own unit testing framework instead of PHPUnit.

Dec 1 2023, 01:00 · Arcanist

Nov 30 2023

speck added inline comments to D25477: Visually indicate new user accounts.
Nov 30 2023, 22:16
speck added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

What do you think about keeping the current naming scheme but whitelisting a handful of query params to use instead of using them all? The timestamp adds noise and it's probably nice to see the ID of the diff in the filename, e.g. D25478.id1541.diff? Maybe just allow the the id parameter and regex that it's value is just a string of numbers.

Nov 30 2023, 21:51
speck added a comment to D25388: PhutilErrorHandler: support multiple error listeners.

Sorry for the delayed review

Nov 30 2023, 21:37
speck accepted D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().

Oh interesting

Nov 30 2023, 12:30

Nov 29 2023

speck added inline comments to D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
Nov 29 2023, 16:21
speck added a comment to D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().

Was this the result of a recent change?

Nov 29 2023, 16:19

Nov 28 2023

speck accepted D25481: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Nov 28 2023, 13:03

Nov 19 2023

speck added a comment to D25474: Disallow webcrawlers to index Diffusion commits.

I don’t think revert I’d needed but the comment should probably be removed or updated. I’d like to understand why it was deemed hard to do but the solution here doesn’t seem that hard. Maybe it’s more difficult than it appears, or was robots.txt standard later updated in a way that makes this easier, or maybe Phab URLs changed in a way that made this easier but this was never updated, etc.

Nov 19 2023, 00:07

Nov 17 2023

speck added inline comments to D25474: Disallow webcrawlers to index Diffusion commits.
Nov 17 2023, 18:15

Nov 16 2023

speck accepted D25474: Disallow webcrawlers to index Diffusion commits.
Nov 16 2023, 23:27

Nov 15 2023

speck accepted D25421: Audit Feed: less verbose when the author is the committer.
Nov 15 2023, 12:49

Nov 14 2023

speck accepted D25421: Audit Feed: less verbose when the author is the committer.

Minor, just suggestion

Nov 14 2023, 19:45
speck planned changes to D25276: Add support for secure connections to the database.

I think there’s still a chunk to do here, including additional documentation during setup

Nov 14 2023, 12:01

Nov 12 2023

speck accepted D25465: Fix loop in contribution docs.
Nov 12 2023, 21:03
speck accepted D25470: Initialize static variable to make linter happy.
Nov 12 2023, 21:02
speck accepted D25469: Fix reentrancy guard in setDebugTimeLimit().
Nov 12 2023, 21:00
speck accepted D25468: Fix typo in DiffusionLowLevelGitRefQuery.
Nov 12 2023, 20:59
speck published D25276: Add support for secure connections to the database for review.

Opening this up from draft if communication/reviews are happening

Nov 12 2023, 17:09
speck accepted D25464: Enforce viewable MIME types config on PDF documents.

Okay I misunderstood the default value. I don’t think a security tag is necessary either.

Nov 12 2023, 15:49
speck added a comment to D25464: Enforce viewable MIME types config on PDF documents.

This will require documentation of some sort, specifically for the upgrade notes to indicate that if someone relies on rendering PDFs currently then after upgrading they would need to update that configuration.

Nov 12 2023, 15:23
speck added inline comments to D25465: Fix loop in contribution docs.
Nov 12 2023, 00:51

Nov 11 2023

speck added a comment to D25464: Enforce viewable MIME types config on PDF documents.

The Referenced Files section of this diff looks like someone is looking for a vulnerability. Any idea what’s happening here?

Nov 11 2023, 15:51
speck added inline comments to D25465: Fix loop in contribution docs.
Nov 11 2023, 15:48
speck added a comment to D25441: Fix possible array to string conversion renaming Pholio Mockup image.

Since this is for the timeline text maybe it should check for array and just say “multiple images” rather than grabbing the first.

Nov 11 2023, 15:43
speck accepted D25463: Correct default database prefix in documentation.

Thanks!

Nov 11 2023, 02:27
speck accepted D25462: Fix view policy inheritance on image transforms.

Awesome thanks for adding details and clarification

Nov 11 2023, 02:26
speck added inline comments to D25462: Fix view policy inheritance on image transforms.
Nov 11 2023, 00:03

Nov 10 2023

speck added inline comments to D25421: Audit Feed: less verbose when the author is the committer.
Nov 10 2023, 04:04
speck accepted D25460: Make "git cat-file" exception messages include repository monogram/slug.

This seems reasonable to me. It only adds further information to logs. I suppose there are some paths that could result in showing exception on the client-side but including monogram doesn’t seem concerning/dangerous.

Nov 10 2023, 03:58