Page MenuHomePhorge

speck (Christopher Speck)
UserAdministrator

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 02:58 (67 w, 5 d)
Roles
Administrator
Availability
Available

At my company I investigated code review tools back in 2014/2015 and selected Phabricator. I worked to adopt it into the company and we've used it successfully since then. I have a few minor contributions in the upstream, mainly related to Mercurial, along with some bug reports.

I'm interested in helping to organize the project effort as well as help document existing architecture/code and provide input into architectural design decisions. I will likely have time for some coding as well.

Recent Activity

Wed, Sep 21

speck created T15121: Contributor Agreement.
Wed, Sep 21, 13:03 · Phorge

Aug 23 2022

speck added a comment to T15108: Rework the URL to Phame posts.

Somewhat related - see T15050

Aug 23 2022, 19:40 · Phame
speck created T15111: Create a pathway for security-related issues to be reported.
Aug 23 2022, 19:14

Aug 22 2022

speck accepted D25048: Update default wordmark and logo.
Aug 22 2022, 19:57
speck added a comment to D25048: Update default wordmark and logo.

Could it be cached?

Aug 22 2022, 19:15

Aug 21 2022

speck added a comment to T15108: Rework the URL to Phame posts.

Could you elaborate on what this would help with? I recall reading something in Phabricator’s past that the current url scheme is intentional as opposed to using the monogram/slug. I did a quick search and couldn’t find much, though in this change release
https://secure.phabricator.com/w/changelog/2015.51/

Removed dedicated titles/slugs. Phame posts now automatically generate readable URIs, but the slugs are no longer semantic.

We should investigate the history related to the current URL scheme before making a change. My suspicion is that it has to do with phase posts being “public” or published where having a url with part of the title is very common for linking across other content.

Aug 21 2022, 16:51 · Phame

Aug 20 2022

speck accepted D25046: Rebrand: Change Server name.
Aug 20 2022, 19:05
speck accepted D25047: Rebrand: Rename library and update "version" logic.
Aug 20 2022, 14:18
speck added inline comments to D25046: Rebrand: Change Server name.
Aug 20 2022, 13:51

Jul 26 2022

speck committed rARCf0a2b699ba62: Update arc-hg to support mercurial 6.1 (authored by speck).
Update arc-hg to support mercurial 6.1
Jul 26 2022, 15:04
speck committed rARCa028291f8e5e: Make corrections to the "arc amend" workflow in Mercurial repositories to be… (authored by speck).
Make corrections to the "arc amend" workflow in Mercurial repositories to be…
Jul 26 2022, 15:04
speck committed rARCd246a0656259: Update ArcanistMercurialAPI to support getting the current commit ref (authored by speck).
Update ArcanistMercurialAPI to support getting the current commit ref
Jul 26 2022, 15:04
speck committed rARCcd17e8441214: Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to… (authored by speck).
Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to…
Jul 26 2022, 15:04
speck committed rARC76a2976fd9a4: Update other usages of "hg rebase" to use the new extension-enabling function (authored by speck).
Update other usages of "hg rebase" to use the new extension-enabling function
Jul 26 2022, 15:04
speck committed rARCac365c3ee509: Refactor how Mercurial runs commands that require extensions (authored by speck).
Refactor how Mercurial runs commands that require extensions
Jul 26 2022, 15:04
speck committed rARC232363e387da: Display informative message when arc launches an editor (authored by speck).
Display informative message when arc launches an editor
Jul 26 2022, 15:04
speck committed rARCa43a3a9aabe2: An assortment of fixes and updates to using arc-land with mercurial (authored by speck).
An assortment of fixes and updates to using arc-land with mercurial
Jul 26 2022, 15:04
speck committed rARC41f6c6ecb2ec: Update "arc diff" to amend non-head commits with Mercurial (authored by speck).
Update "arc diff" to amend non-head commits with Mercurial
Jul 26 2022, 15:04
speck committed rARC514c12366b63: Update templates used with mercurial to remove '--debug' (authored by speck).
Update templates used with mercurial to remove '--debug'
Jul 26 2022, 15:04
speck committed rARCc94c5bbf35f0: Force all mercurial commands to use UTF-8 encoding (authored by speck).
Force all mercurial commands to use UTF-8 encoding
Jul 26 2022, 15:04
speck committed rP3b2868e15553: Fix searching legalpad documents by contributors (authored by speck).
Fix searching legalpad documents by contributors
Jul 26 2022, 15:04
speck committed rP09c3c7d87931: Add support to marking commits as UNREACHABLE for Mercurial (authored by speck).
Add support to marking commits as UNREACHABLE for Mercurial
Jul 26 2022, 15:04
speck committed rP458ad4a8617a: Remove history query from DiffusionRepositoryController as it is unused (authored by speck).
Remove history query from DiffusionRepositoryController as it is unused
Jul 26 2022, 15:03
speck committed rPe5de7f08436d: Update templates used with mercurial to remove '--debug' (authored by speck).
Update templates used with mercurial to remove '--debug'
Jul 26 2022, 15:03
speck committed rP14c516b7a109: Updating the filtering of Mercurial debug output (authored by speck).
Updating the filtering of Mercurial debug output
Jul 26 2022, 15:03
speck committed rP96374208616b: Update a few random typos (authored by speck).
Update a few random typos
Jul 26 2022, 15:02

Jul 12 2022

speck abandoned D25039: merge phab/master -> phorge/master.
Jul 12 2022, 20:09
speck abandoned D25040: merge phab/master -> phorge/master.
Jul 12 2022, 20:09
speck added a comment to D25040: merge phab/master -> phorge/master.

Sorry about the delay on this. I think the emails didn't go out until later and I've not had much time to dedicate to this project as expected. As of today's meeting the current plan is for @avivey to do the merge with latest updates from upstream and push, sans review.

Jul 12 2022, 19:59

May 21 2022

speck added a comment to T15094: Catch up the master branch to upstream.

@dcog I think the differences with the Harbormaster changes are due to the different approach taken. We planned to do the approach which you took in D25036 which re-played the Phorge diffs on top of phabricator, however in D25040 I just did a merge of the phab/master branch into phorge/master where the Harbormaster changes already existed. Since upstream didn't modify the same Harbormaster files there were no conflicts and things merged appropriately. I did a sanity check of files changed on D25005 with the files changed on D25040.

May 21 2022, 17:06 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

Do we even have servers to run the tests on?

May 21 2022, 16:56 · Trusted Contributors, Phorge
speck updated the summary of D25039: merge phab/master -> phorge/master.
May 21 2022, 16:43
speck added a revision to T15094: Catch up the master branch to upstream: D25039: merge phab/master -> phorge/master.
May 21 2022, 16:43 · Trusted Contributors, Phorge
speck added a revision to T15094: Catch up the master branch to upstream: D25040: merge phab/master -> phorge/master.
May 21 2022, 16:43 · Trusted Contributors, Phorge
speck updated the summary of D25040: merge phab/master -> phorge/master.
May 21 2022, 16:43
speck added a comment to T15094: Catch up the master branch to upstream.

I did not think we had Harbormaster set up to run unit tests - I think that involves configuring both Harbormaster and Drydock, and possibly Almanac which I don't think anyone has done.

May 21 2022, 16:24 · Trusted Contributors, Phorge
dcog awarded D25039: merge phab/master -> phorge/master a Party Time token.
May 21 2022, 15:23
dcog awarded D25040: merge phab/master -> phorge/master a Party Time token.
May 21 2022, 15:23
speck added a comment to T15094: Catch up the master branch to upstream.

Though it does appear additional work has been landing upstream today

May 21 2022, 00:52 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

Any concerns about landing those changes? Once I land I'll see about updating this instance which should make accessing the repositories possible again.

May 21 2022, 00:45 · Trusted Contributors, Phorge

May 20 2022

speck added a comment to D25040: merge phab/master -> phorge/master.

I had to skip unit tests because phabricator/phorge unit tests require a local database to test against which I don't have setup. The lint failures are either pre-existing TODO's being flagged or the newest lint which catches product name literals. We should fix the literals but I don't want to fix that as part of the merge -- would rather do that in a separate change.

May 20 2022, 03:09
speck added a comment to D25039: merge phab/master -> phorge/master.

Unit tests all pass. For the two lint errors, one is erroneous checking characters used in a non-code file, the other is pre-existing and fine to leave alone.

May 20 2022, 03:07
speck added a comment to T15094: Catch up the master branch to upstream.

Merged the arcanist repository in D25039

May 20 2022, 03:06 · Trusted Contributors, Phorge
speck requested review of D25040: merge phab/master -> phorge/master.
May 20 2022, 03:05
speck updated the summary of D25039: merge phab/master -> phorge/master.
May 20 2022, 02:54
speck requested review of D25039: merge phab/master -> phorge/master.
May 20 2022, 02:50

May 3 2022

speck added a comment to T15094: Catch up the master branch to upstream.

It looks like upstream has issued a number of updates which we'll want to pull in. From {E4} we discussed doing the following:

May 3 2022, 19:20 · Trusted Contributors, Phorge

Apr 28 2022

speck added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Thank you for these write-ups, I'll need more time to review however I noticed Evan recently started a task in the upstream where it looks like he's investigating compiling PHP to a library for use with a custom native entrypoint which would allow distributing arcanist as a single binary (he estimates ~10mb in size).
https://secure.phabricator.com/T13675

Apr 28 2022, 14:28 · Phorge General/Unknown, Arcanist
speck added a comment to T15077: Rebrand: Tracking task.

Evan recently landed a boatload of changes to address this under https://secure.phabricator.com/T13658

Apr 28 2022, 14:21 · Phorge

Apr 20 2022

speck edited the content of April 19, 2022.
Apr 20 2022, 13:06 · Governance
speck added a comment to April 19, 2022.

There is quite a bit of text that is setup like this:

pht(
  'blah blah blah %s blah blah'.
  'blah blah Phabricator blah %s'.
  'blah blah.',
  $var1,
  $var2);
Apr 20 2022, 02:54 · Governance

Apr 19 2022

speck updated the task description for T15092: Automatic deploy onto we.phorge.it.
Apr 19 2022, 19:31 · phorge.it install, Upstream General/Unknown
speck created T15092: Automatic deploy onto we.phorge.it.
Apr 19 2022, 19:29 · phorge.it install, Upstream General/Unknown

Apr 6 2022

20after4 awarded April 5, 2022 a Mountain of Wealth token.
Apr 6 2022, 16:59 · Governance

Mar 29 2022

speck added a comment to T15075: Add support for @link in diviner.

A few thoughts. This sounds like a great idea as searching by article title seems a little fragile as you mention. I think a good practice for using the proposed @link would be to fully namespace it somehow like @link development.processes.i18n, though I'm not totally sure what that looks like as I'm not familiar with the Diviner format or structure. If we have the use of namespaces then managing multiple @link declarations might lead to confusion or tedious to maintain. To me this also feels more similar to something like an @id rather than @link. What are your thoughts?

Mar 29 2022, 03:36 · Diviner
speck added a comment to T15079: Upstream TranslateWiki's changes.

A highly unfortunate side-effect of T15077: Rebrand: Tracking task is that it will invalidate a ton of translations. My guess is that upstream did not want to maintain these translations as part of the release product, possibly due to not requiring translations be part of the Phabricator release process. If we pull them into the Phorge codebase then we would likely need to update all translations for any text changes made during development, prior to release. I think it would make sense to host the translations in a repository here but I would worry about them quickly falling out of date. Handling of translations is likely a larger-sized project that we would need help managing.

Mar 29 2022, 03:30 · Localization, Phorge General/Unknown
speck edited the content of March 21, 2022.
Mar 29 2022, 03:18
speck added a comment to T15006: Re-brand Phorge.

As part of {E1} we reviewed this as a priority item, and have created T15077: Rebrand: Tracking task for concrete first steps forwards. There is a lot of text to update and review and that task is setup with instructions on how we're approaching it as well as listing out all the individual applications to update. Anyone interested in assisting please review that task and feel free to put your name on an application/folder, as well as ask any questions for clarification.

Mar 29 2022, 03:17 · Phorge
speck edited the content of March 21, 2022.
Mar 29 2022, 03:13
speck updated the task description for T15077: Rebrand: Tracking task.
Mar 29 2022, 03:13 · Phorge
speck added a comment to T15077: Rebrand: Tracking task.

I put up some coding guidelines that I could recall from when I was working with upstream on example changes. I won't be back at my home office for another week so there may be some things I'm missing but I think a number of things were covered/discussed with Evan on the example changes in https://secure.phabricator.com/D21712.

Mar 29 2022, 03:08 · Phorge
speck updated the task description for T15077: Rebrand: Tracking task.
Mar 29 2022, 03:00 · Phorge
speck edited the content of Planning Meetings.
Mar 29 2022, 02:41 · Phorge Upstream
speck updated the task description for T15077: Rebrand: Tracking task.
Mar 29 2022, 02:35 · Phorge
speck updated the task description for T15077: Rebrand: Tracking task.
Mar 29 2022, 02:35 · Phorge
speck created an object: March 21, 2022.
Mar 29 2022, 02:34
speck edited the content of Planning Meetings.
Mar 29 2022, 02:29 · Phorge Upstream
speck created an object: Planning Meetings.
Mar 29 2022, 02:25 · Phorge Upstream

Mar 25 2022

speck accepted D25035: Hide the blurb of a user when that user is disabled.

Ah interesting. My own preference would be updating PhabricatoPeopleProfileController as I would associate this more as a view-level change but looking again at how this is structured I don't think it would cause any issues and I don't feel too strongly about changing it.

Mar 25 2022, 02:42
speck added a comment to D25035: Hide the blurb of a user when that user is disabled.

Real quick before landing -- should this change be made here in PhabricatorUser or would it be sufficient in PhabricatorPeopleProfileController? Placing it here affects the profile at the data model source which would likely cause the same blurb-scrub in any other location it might render, but it might also cause problems in areas which need to access the profile data for other reasons other than rendering, e.g. if a profile gets copied/cloned in memory then this might result in losing the profile data altogether. Updating only PhabricatoPeopleProfileController to call cleanupProfile() instead of within PhabricatorUser would only scrub it at the time it's being rendered (to the profile page at least).

Mar 25 2022, 01:50
speck added a comment to T15078: Support for hardware keys as second factor.

I've only looked at the new auth frameworks briefly (WebAuthn, is there another standard too?). My basic understanding is that the browser provides the client with its own certificate which HTTP requests are able to include with it, as a means of providing authentication for the user. This seems like a reasonable thing to allow though I'd also be interested in learning more about the tech in general.

Mar 25 2022, 01:24 · Auth
speck added a comment to T15080: Intermittent DNS issues when attempting to visit we.phorge.it.

Unfortunately this type of issue is in an area that's beyond my network/configuration experience. Is CloudFlare our NS provider?

Mar 25 2022, 01:20 · phorge.it install
speck accepted D25035: Hide the blurb of a user when that user is disabled.

I'm having trouble landing this, I keep getting 403 errors. I suspect it's a local configuration issue, though...

Mar 25 2022, 01:18

Mar 20 2022

speck added a comment to T15073: /status should be always allowed in anonymous mode.

Interestingly accessing /status on secure.phabricator.com seems to return a json object instead of ALIVE.

Mar 20 2022, 21:10 · Phorge General/Unknown
speck added inline comments to D25034: support language highlighting for GFM-style code blocks.
Mar 20 2022, 21:02

Mar 16 2022

speck added a comment to T15071: Setup recurring Core meeting.

I also created a Jitsi meeting and put that in the description of {E1}.

Mar 16 2022, 02:33 · Governance
speck added a comment to T15071: Setup recurring Core meeting.

I turned on prototypes and created {E1}, adding everyone currently (individually) cc'd on this task as an invitee.

Mar 16 2022, 02:32 · Governance
speck updated the task description for T15071: Setup recurring Core meeting.
Mar 16 2022, 02:31 · Governance
speck added a comment to T15072: Update Python-related linters for modern workflows.

Yeah, I think we'd like to try and update arcanist to account for this with a general solution if possible and not making updates for each individual linter which might necessitate this. There's probably some general restructuring that needs to happen to account for the same odd scenario with Java and so forth.

Mar 16 2022, 02:22 · Arcanist

Mar 15 2022

speck updated the task description for T15071: Setup recurring Core meeting.
Mar 15 2022, 18:08 · Governance
speck updated the task description for T15071: Setup recurring Core meeting.
Mar 15 2022, 01:58 · Governance
speck added a comment to T15072: Update Python-related linters for modern workflows.

I think that's roughly what I ended up doing in https://secure.phabricator.com/D14632 for launching separate Java linters, where java had to be configured as the "interpreter" and checkstyle.jar (or whatever) configured as the "binary" (https://secure.phabricator.com/D15067 added the ability to pass flags to the "interpreter").

Mar 15 2022, 01:55 · Arcanist
speck added a comment to T15071: Setup recurring Core meeting.

Phabricator has a Calendar application but is prototype. I believe it's mostly functional -- should we enable prototypes on this install to try and use the calendar application for organizing this event?

Mar 15 2022, 01:06 · Governance

Mar 13 2022

speck updated the task description for T15071: Setup recurring Core meeting.
Mar 13 2022, 17:36 · Governance
speck updated the task description for T15071: Setup recurring Core meeting.
Mar 13 2022, 02:39 · Governance
speck added a comment to T15071: Setup recurring Core meeting.

Based on the entries so far it seems like possible window of time for meeting would be 4pm-8pm GMT? That would mean 9am-1pm for GMT-6 and 6pm-10pm for GMT+2. If that time window seems reasonable would any day of the week be better than others?

Mar 13 2022, 02:38 · Governance
speck added a comment to T15072: Update Python-related linters for modern workflows.

Should this be the responsibility of the linter/tester and not part of Arcanist itself? Updating arcanist to handle the many different environment-dependent systems for languages would mean accounting for nearly every language like Javascript/npm, Ruby/rubyenv, etc. right?

Mar 13 2022, 02:28 · Arcanist
speck added a comment to T15069: Disable spammers.

That would be useful, though we might not want all disabled accounts to have their profiles description hidden for accounts disabled which aren't spam.

Mar 13 2022, 02:26 · Upstream General/Unknown

Mar 11 2022

speck closed T15070: Susu management as Spite.
Mar 11 2022, 15:17
speck updated the task description for T15071: Setup recurring Core meeting.
Mar 11 2022, 15:17 · Governance

Mar 7 2022

speck updated the task description for T15069: Disable spammers.
Mar 7 2022, 23:28 · Upstream General/Unknown
speck added a comment to T15069: Disable spammers.

Thanks for reporting, I've disabled the account.

Mar 7 2022, 23:14 · Upstream General/Unknown

Dec 9 2021

speck added a comment to T15064: Make phorge compatible with PHP 8.1.

Evan just posted some comments regarding 8.1 compatibility (as well as building PHP binary to ship with Arcanist, for Mac systems at least)
https://secure.phabricator.com/T13588#256390

Dec 9 2021, 21:30 · Phorge

Dec 2 2021

speck added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

I just checked the emails I receive to my gmail account and noticed that the emails seem to be from the secure.phorge.dev domain. Should those be received from we.phorge.it instead? I was in the process of filling out an issue form for Microsoft and noticed this discrepancy. Could that cause issues like this?

Dec 2 2021, 15:24 · Phorge

Dec 1 2021

speck added a comment to T15064: Make phorge compatible with PHP 8.1.

I noticed this recently too. These PHP 8 updates have been frustrating because it breaks Arcanist for users as well...

Dec 1 2021, 17:07 · Phorge
speck added a comment to T15062: Introducing Phixator 2.

Time tracking is an interesting topic. At my company we addressed this by having a Herald WebHook hit our internal server whenever activity we're interested in tracking happens. Our internal server tracks these activities from multiple sources (not just Phab/Phorge) and users can go in to see all their activity linked up and input the approximate time spent on those activities.

Dec 1 2021, 16:55 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest
speck added inline comments to D25027: Allow an infinite number of arcpatch_DXXXX_X branches to be created.
Dec 1 2021, 16:49
speck added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

A few months back this story came up on hackernews which seems relevant. There might be things in there we can attempt to appeal to Microsoft to allow emails from this Phorge instance to go through

Dec 1 2021, 16:44 · Phorge
speck added a comment to T15058: Improve page layout for mobile devices.

What mobile display are you using? From the screenshots it looks like based on the dimensions of the display phorge isn't detecting that it should render as mobile view.

Dec 1 2021, 16:36
speck added a comment to T15051: default.pem in Arcanist is out of date - maybe remove it completely?.

I think updating the current pem file is a good holdover patch for now (sorry for the delay in reviewing the change). Re-working how arcanist manages certs is something we can look at addressing long-term.

Dec 1 2021, 16:32 · Arcanist