Differential D25531

Remove dysfunctional Fund and Phortune prototype applications
Changes PlannedPublic
Actions

Authored by aklapper on Jan 27 2024, 13:29.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15726: Remove dysfunctional Fund and Phortune prototype applications

Summary

This commit removes Phortune and Fund entirely. All of the application files are removed, and the migrations used are stubbed out. I stubbed the migrations as that allows for existing installs to make no changes, but new installs will not create the database.

Closes T15726

Test Plan

Go to http://phorge.localhost/fund and http://phorge.localhost/phortune and get a 404.
Go to http://phorge.localhost/applications/ and do not see their entries anymore.
Go to up http://phorge.local/applications/view/PhabricatorFundApplication and http://phorge.local/applications/view/PhabricatorPhortuneApplication and get a 404.
STILL TODO: Create new database prefix and run bin/storage upgrade against it, confirmed that Fund and Phortune databases do not get created.
STILL TODO: Restore another prefix (an old one) and run bin/storage upgrade and confirm databases were not deleted.

Diff Detail

Repository

rP Phorge

Branch

rmPhortuneFundApps (branched from master)

Lint

Lint Errors

Severity	Location	Code	Message
Error	resources/sql/autopatches/20190815.account.01.carts.php:1	XHP15	Expected Open Tag
Error	resources/sql/autopatches/20190815.account.02.subscriptions.php:1	XHP15	Expected Open Tag
Error	resources/sql/autopatches/20210316.almanac.15.intiative-mailkey.php:1	XHP15	Expected Open Tag
Warning	resources/sql/quickstart.sql:4907	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 1049
Build 1049: arc lint + arc unit

Event Timeline

aklapper created this revision.Jan 27 2024, 13:29

Owners added a reviewer: O1: Blessed Committers.Jan 27 2024, 13:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 27 2024, 13:29

aklapper requested review of this revision.Jan 27 2024, 13:29

Harbormaster completed remote builds in B1049: Diff 1672.Jan 27 2024, 13:29

Test Plan still to be fully executed thus setting "Plan Changes"

Not a concern but a question: @aklapper why blanking Phortune-related SQL files on \phorge\resources\sql\autopatches instead of completely deleting them?

Remove dysfunctional Fund and Phortune prototype applicationsChanges PlannedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 1672

externals/stripe-php/.travis.yml

externals/stripe-php/CHANGELOG

externals/stripe-php/LICENSE

externals/stripe-php/README.rdoc

externals/stripe-php/VERSION

externals/stripe-php/composer.json

externals/stripe-php/lib/Stripe.php

externals/stripe-php/lib/Stripe/Account.php

externals/stripe-php/lib/Stripe/ApiConnectionError.php

externals/stripe-php/lib/Stripe/ApiError.php

externals/stripe-php/lib/Stripe/ApiRequestor.php

externals/stripe-php/lib/Stripe/ApiResource.php

externals/stripe-php/lib/Stripe/ApplicationFee.php

externals/stripe-php/lib/Stripe/AttachedObject.php

externals/stripe-php/lib/Stripe/AuthenticationError.php

externals/stripe-php/lib/Stripe/Balance.php

externals/stripe-php/lib/Stripe/BalanceTransaction.php

externals/stripe-php/lib/Stripe/Card.php

externals/stripe-php/lib/Stripe/CardError.php

externals/stripe-php/lib/Stripe/Charge.php

externals/stripe-php/lib/Stripe/Coupon.php

externals/stripe-php/lib/Stripe/Customer.php

externals/stripe-php/lib/Stripe/Error.php

externals/stripe-php/lib/Stripe/Event.php

externals/stripe-php/lib/Stripe/InvalidRequestError.php

externals/stripe-php/lib/Stripe/Invoice.php

externals/stripe-php/lib/Stripe/InvoiceItem.php

externals/stripe-php/lib/Stripe/List.php

externals/stripe-php/lib/Stripe/Object.php

externals/stripe-php/lib/Stripe/Plan.php

externals/stripe-php/lib/Stripe/RateLimitError.php

externals/stripe-php/lib/Stripe/Recipient.php

externals/stripe-php/lib/Stripe/Refund.php

externals/stripe-php/lib/Stripe/SingletonApiResource.php

externals/stripe-php/lib/Stripe/Stripe.php

externals/stripe-php/lib/Stripe/Subscription.php

externals/stripe-php/lib/Stripe/Token.php

externals/stripe-php/lib/Stripe/Transfer.php

externals/stripe-php/lib/Stripe/Util.php

externals/stripe-php/lib/Stripe/Util/Set.php

externals/stripe-php/lib/data/ca-certificates.crt

resources/celerity/map.php

resources/sql/autopatches/20140721.phortune.1.cart.sql

resources/sql/autopatches/20140721.phortune.2.purchase.sql

resources/sql/autopatches/20140721.phortune.3.charge.sql

resources/sql/autopatches/20140721.phortune.4.cartstatus.sql

resources/sql/autopatches/20140721.phortune.5.cstatusdefault.sql

resources/sql/autopatches/20140721.phortune.6.onetimecharge.sql

resources/sql/autopatches/20140721.phortune.7.nullmethod.sql

resources/sql/autopatches/20140722.appname.php

resources/sql/autopatches/20140911.fund.1.initiative.sql

resources/sql/autopatches/20140911.fund.2.xaction.sql

resources/sql/autopatches/20140911.fund.3.edge.sql

resources/sql/autopatches/20140911.fund.4.backer.sql

resources/sql/autopatches/20140911.fund.5.backxaction.sql

resources/sql/autopatches/20141004.currency.01.sql

resources/sql/autopatches/20141004.currency.02.sql

resources/sql/autopatches/20141004.currency.03.sql

resources/sql/autopatches/20141004.currency.04.sql

resources/sql/autopatches/20141004.currency.05.sql

resources/sql/autopatches/20141004.currency.06.sql

resources/sql/autopatches/20141005.phortuneproduct.sql

resources/sql/autopatches/20141006.phortunecart.sql

resources/sql/autopatches/20141006.phortunemerchant.sql

resources/sql/autopatches/20141006.phortunemerchantx.sql

resources/sql/autopatches/20141007.fundmerchant.sql

resources/sql/autopatches/20141007.fundrisks.sql

resources/sql/autopatches/20141007.fundtotal.sql

resources/sql/autopatches/20141007.phortunecartmerchant.sql

resources/sql/autopatches/20141007.phortunecharge.sql

resources/sql/autopatches/20141007.phortunepayment.sql

resources/sql/autopatches/20141007.phortuneprovider.sql

resources/sql/autopatches/20141007.phortuneproviderx.sql

Remove dysfunctional Fund and Phortune prototype applications
Changes PlannedPublic
Actions

Revision Contents
Changeset List