Page MenuHomePhorge

Update Facebook icon on Auth Provider page
ClosedPublic

Authored by aklapper on Jul 10 2023, 10:09.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 25, 06:44
Unknown Object (File)
Thu, Feb 22, 00:02
Unknown Object (File)
Thu, Feb 22, 00:02
Unknown Object (File)
Sun, Feb 18, 14:05
Unknown Object (File)
Sun, Feb 18, 02:06
Unknown Object (File)
Tue, Feb 13, 00:44
Unknown Object (File)
Fri, Feb 9, 22:09
Unknown Object (File)
Fri, Feb 9, 21:12

Details

Summary

Closes T15545

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Branch
authFBicon (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 662
Build 662: arc lint + arc unit

Event Timeline

Is the file resources/sprite/login_2x/Facebook.png in high definition? it seems a bit grainy

avivey subscribed.

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

This revision is now accepted and ready to land.Jul 11 2023, 08:17

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.

Yeah, that's what I was worried about

Try arc unit --everything ? it would take a while...