Page MenuHomePhorge
Differential D25342

Update Facebook icon on Auth Provider page
ClosedPublic
Actions

Authored by aklapper on Jul 10 2023, 10:09.

Details

Reviewers
Cigaryno
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15545: Update "Facebook" icon on Phorge OAuth
Commits
rPfb822ba84999: Update Facebook icon on Auth Provider page
Summary

Closes T15545

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Branch
authFBicon (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 662
Build 662: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 10 2023, 10:09
Owners added a reviewer: O1: Blessed Committers.Jul 10 2023, 10:09
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 10 2023, 10:09
aklapper requested review of this revision.Jul 10 2023, 10:09
Harbormaster completed remote builds in B662: Diff 1111.Jul 10 2023, 10:09
Cigaryno accepted this revision.Jul 10 2023, 10:54
valerio.bozzolan added a comment.Jul 10 2023, 11:49

Is the file resources/sprite/login_2x/Facebook.png in high definition? it seems a bit grainy

avivey accepted this revision.Jul 11 2023, 08:17
avivey subscribed.

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

This revision is now accepted and ready to land.Jul 11 2023, 08:17
aklapper added a comment.Jul 11 2023, 10:06

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.
mainframe98 mentioned this in Q66: Is Differential configured wrong or has something broken?.Jul 11 2023, 10:24
avivey added a comment.Jul 11 2023, 10:25

Yeah, that's what I was worried about

Try arc unit --everything ? it would take a while...

Closed by commit rPfb822ba84999: Update Facebook icon on Auth Provider page. · Explain WhyJul 11 2023, 11:00
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPfb822ba84999: Update Facebook icon on Auth Provider page.
mainframe98 mentioned this in T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.Jul 19 2023, 12:14
valerio.bozzolan mentioned this in Z1: Phorge.Feb 1 2024, 15:56

Revision Contents
Changeset List

Diff 1111

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/login_1x/Facebook.png

Loading...
View Options

resources/sprite/login_2x/Facebook.png

Loading...
View Options

resources/sprite/manifest/login.json

Loading...
View Options

webroot/rsrc/image/sprite-login-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-login.png

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0