I wonder if under the hood this means "Add branch support to Locate File"

I’ve been meaning to investigate this. It also has thrown me that it’s not available where you expect it. I do suspect @valerio.bozzolan is right

Under the hood branches are already supported by the locate feature. The whole file tree is loaded via AJAX, when you first click in the input field. This tree represents the current selected branch.

@speck @valerio.bozzolan My revision is ready to be tested 😄

@bekay while in this area of code would you have any pointers on these other issues I’d like to fix at some point?

1. File browse widget doesn’t work unless logged in, for publicly accessible repos
2. The search results pop up width is often too narrow to show the full results path, and truncates the end of the path instead of beginning.

In T15645#15201, @speck wrote:

@bekay while in this area of code would you have any pointers on these other issues I’d like to fix at some point?

1. File browse widget doesn’t work unless logged in, for publicly accessible repos
2. The search results pop up width is often too narrow to show the full results path, and truncates the end of the path instead of beginning.

1. True... the problem is: the pathtree is created through the conduit API, which needs a user. A small stack trace:
   • https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionPathTreeController.php$18
   • https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionController.php$234
   • the callConduitWithDiffusionRequest could be extended with a third bool parameter to activate the use of PhabricatorUser::getOmnipotentUser() instead of the user of the request
   • this third parameter could be used in DiffusionPathTreeController
   • there would be no security concern because the basic policies are already tested here: https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionPathTreeController.php$6

2. Well, the default case for typeahead results is: the result wrapper is as wide as the input field. With a small css hack this could be changed only for the locate input:

.diffusion-profile-locate #locate-input + .jx-typeahead-results {
  min-width: 100%;
  width: auto;
}