See D25420 for a conflicting change...

ooh, check out D25349 for basically this exact use-case...

IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this:

@valerio.bozzolan I found the js section where with the listener for open/close the persistent chat. From there I can get element somehow (by ID I don't think it would be good, because it seems to be auto-generated (UQ3_0)) and remove the class "core-menu-item" and the invisible gear icon will no longer be clickable. If the chat is not minimized, we add the class back so we can see it and click it.

cosmetic whitespace changes

Updating D25420:

This is very promising. Just added an inline comment

if you check the checkbox, it will use the current setting timezone.

Updating D25420: Updating D25420: fixed tests error

Updating D25420: Added a checkbox to ignore timezone conflict in Adjust Timezone dialog window. Using the checkbox instead of a button because this way it's possible to reuse the existing form. Also, i still didn't find a way to capture the additional button click event. This way, if you check the checkbox, it will use the current setting timezone.

This is very probably a recent regression since I cannot reproduce on Wikimedia Phabricator.

Looks good

Looks good to me.

This happens also with the Upload File dialog

Ah! I can reproduce exactly in this comment!

Finally, after additional tests, I guess these issue are not related (as related in T15629)

consider more cases

fix corner case of NULL phid

In D25419#12006, @valerio.bozzolan wrote:

It seems your "master" branch has (many?) local unexpected commits.

In order to work on this feature, in Phorge, try these:

git status
# you should be on master - please eventually manually delete any local uncommitted change

Then, create another clean branch:

git branch   pippo_feature
git switch   pippo_feature
git reset --hard origin/master

So now you are on a custom branch pippo_feature that is super-clean. From there you can add fresh features and propose whatever patch.

(To switch between branches, just git switch master or git switch pippo_feature ecc.)

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

You're right valerio, this sign in is an automatic reflex since my Phorge instance is private ;)

It seems your "master" branch has (many?) local unexpected commits.

I kindly mark this as "request changes" since the author said that it needs an update to reflect the screenshot. Feel free to update with

Thanks Roberto, feel free to update D25420 to reflect your lovely screenshot.

Got it! Nice catch!

I'm thinking of adding similar handling for E_USER_NOTICE and E_USER_WARNING - to allow using them in extension code and in things like T15316 (Right now, we treat those as fatal errors too).

That works! Thank you!

Would taking care of the depreciations bump the minimum PHP version required to run Phorge?

Not in itself, but we do plan to bump the minimum to 7.1 (in T15047).

In T15626#13393, @valerio.bozzolan wrote:

Thanks I'm trying to reproduce. Can you please help me in understanding "click to the left next to the up arrow icon"? I probably don't get "click the left"

Interestingly I tried to open a simple README file and selecting UTF-8.

Thanks I'm trying to reproduce. Can you please help me in understanding "click to the left next to the up arrow icon"? I probably don't get "click the left"

sometimes i can not reproduce the issue

As this is broken anyway (and creates noisy log spam when someone tries to use the broken Create Identity form), would it make sense in the meantime as a workaround to disable (or hide, but no idea how to do that for a PhabricatorEditEngine) that form for every and any user? A one-line hack would be in P22.