Page MenuHomePhorge

Curtain: add Hovercard support
ClosedPublic

Authored by valerio.bozzolan on Aug 28 2023, 13:19.
Tags
None
Referenced Files
F2308673: D25424.1721306174.diff
Wed, Jul 17, 12:36
Unknown Object (File)
Sun, Jul 14, 23:43
Unknown Object (File)
Tue, Jul 9, 09:35
Unknown Object (File)
Tue, Jul 9, 06:58
Unknown Object (File)
Tue, Jul 9, 06:56
Unknown Object (File)
Mon, Jul 8, 16:35
Unknown Object (File)
Sat, Jul 6, 18:44
Unknown Object (File)
Sat, Jul 6, 18:25

Details

Summary

Before this change, the right navigation panel (Curtain) had info without Hovercard support.

After this change, all fields, like Subscribers, Tags, Referenced Files etc. have Hovercards.

If you meet an UX problem with a specific field with Hovercard, you can disable that specific
Hovercard, calling PHUICurtainObjectRefView::setHovercarded(false).

This is an example, now with Hovercard support:

Curtain with Hovercard.png (830×1 px, 100 KB)

Closes T15577

Test Plan

No nuclear implosions when, on desktop and with a mouse:

Browse Maniphest Task and mouse hover Authored By, Assigned To, Subscribers, Referenced Files, ...

Browse Phriction document and mouse Tags, Referenced Files, Subscribers, ...

Browse single commit and mouse hover Referenced Files, Subscribers, ...

Browse Ponder question and mouse hover Tags, Referenced Files, Subscribers, ...

Browse Differential revision and mouse hover Tags, Referenced Files, Subscribers, ...

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable