Page MenuHomePhorge
Differential D25421

Audit Feed: less verbose when the author is the committer
Needs ReviewPublic
Actions

Authored by valerio.bozzolan on Mon, Aug 28, 12:09.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 17, 14:00
Unknown Object (File)
Sun, Sep 17, 10:20
Unknown Object (File)
Sun, Sep 17, 04:34
Unknown Object (File)
Sat, Sep 16, 11:56
Unknown Object (File)
Wed, Sep 13, 05:01
Unknown Object (File)
Tue, Sep 12, 07:35
Unknown Object (File)
Sun, Sep 10, 20:29
Unknown Object (File)
Sun, Sep 10, 16:27
View All 14 Files
Subscribers
Cigaryno
Matthew
tobiaswiese

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx)
Summary

If the author and the committer are the same person, do not show them twice.

From:

UsernameFoo committed <commit hash>: <commit msg> (authored by UsernameFoo).

To:

UsernameFoo committed <commit hash>: <commit msg>

This only affects the feed.

BeforeAfter
Committer Feed before D25421.png (836×1 px, 152 KB)
Committer Feed after D25421.png (836×1 px, 140 KB)

Closes T15528

Test Plan

Do some mixed commits and visit /feed/query/all/. No nuclear implosions.

Diff Detail

Repository
rP Phorge
Branch
audit-fix-author-twice
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 811
Build 811: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mon, Aug 28, 12:09
Owners added a reviewer: O1: Blessed Committers.Mon, Aug 28, 12:09
Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptMon, Aug 28, 12:09
Harbormaster completed remote builds in B809: Diff 1336.Mon, Aug 28, 12:09
valerio.bozzolan requested review of this revision.Mon, Aug 28, 12:09
valerio.bozzolan updated this revision to Diff 1337.Mon, Aug 28, 12:12

fix corner case of NULL phid

Harbormaster completed remote builds in B810: Diff 1337.Mon, Aug 28, 12:12
valerio.bozzolan edited the summary of this revision. (Show Details)Mon, Aug 28, 12:28
valerio.bozzolan updated this revision to Diff 1338.Mon, Aug 28, 12:30

consider more cases

Harbormaster completed remote builds in B811: Diff 1338.Mon, Aug 28, 12:30
valerio.bozzolan retitled this revision from Audit: do not show same author twice in Feed to Audit Feed: less verbose when the author is the committer.Mon, Aug 28, 13:37
valerio.bozzolan added inline comments.Wed, Sep 6, 11:09
src/applications/audit/storage/PhabricatorAuditTransaction.php
341

✅ This is the supposed non-empty check for a PHID. See line 323.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
audit/
storage/
10 linesO1: Blessed Committers

Diff 1338

View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...