Page MenuHomePhorge
Differential D25393

Fix answer background color when using Dark Mode in Ponder
ClosedPublic
Actions

Authored by bob on Aug 16 2023, 09:37.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Wed, Apr 24, 21:50
Unknown Object (File)
Thu, Apr 11, 02:54
Unknown Object (File)
Tue, Apr 9, 08:58
Unknown Object (File)
Tue, Apr 2, 17:01
Unknown Object (File)
Mon, Apr 1, 02:37
Unknown Object (File)
Mon, Apr 1, 02:37
Unknown Object (File)
Mon, Apr 1, 02:37
View All 90 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP0ec3291ff4a9: Fix answer background color when using Dark Mode in Ponder
Summary

This CSS fix replaces the hard coded white background value by the page.content CSS variable.

BeforeAfter
screenshot-phorge-bug-darkmode-ponder-answer-before.png (434×1 px, 23 KB)
screenshot-phorge-bug-darkmode-ponder-answer-after.png (434×1 px, 26 KB)
Test Plan
  • Flush all Phorge caches
  • Sign in
  • Go to question with at least one answer.
  • Check that the answer block background color is consistent with the theme.
  • Do these steps for each user interface theme in order to check against regression.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob created this revision.Aug 16 2023, 09:37
Owners added a reviewer: O1: Blessed Committers.Aug 16 2023, 09:37
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2023, 09:37
bob requested review of this revision.Aug 16 2023, 09:37
Harbormaster completed remote builds in B759: Diff 1262.Aug 16 2023, 09:37
bob edited the summary of this revision. (Show Details)Aug 16 2023, 09:39
bob mentioned this in T15056: Improve Dark Mode.Aug 16 2023, 09:41
bob edited the test plan for this revision. (Show Details)Aug 16 2023, 14:38
valerio.bozzolan accepted this revision.Aug 19 2023, 03:52

You are a good minion, thanks bob

Tested with and without Dark Mode enabled

I confirm that Celerity map was already up to date \o/

sgtm

This revision is now accepted and ready to land.Aug 19 2023, 03:52
valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47
Closed by commit rP0ec3291ff4a9: Fix answer background color when using Dark Mode in Ponder. · Explain WhyAug 28 2023, 08:39
This revision was automatically updated to reflect the committed changes.
bob added a commit: rP0ec3291ff4a9: Fix answer background color when using Dark Mode in Ponder.
valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

PathSizePackages
webroot/
rsrc/
css/
application/
ponder/
2 linesO1: Blessed Committers

Diff 1333

View Options

webroot/rsrc/css/application/ponder/ponder-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0