Page MenuHomePhorge

Fix answer background color when using Dark Mode in Ponder
ClosedPublic

Authored by bob on Aug 16 2023, 09:37.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 14, 00:16
Unknown Object (File)
Sat, Jul 13, 22:59
Unknown Object (File)
Fri, Jul 12, 00:55
Unknown Object (File)
Thu, Jul 11, 03:01
Unknown Object (File)
Mon, Jul 8, 22:37
Unknown Object (File)
Mon, Jul 8, 22:31
Unknown Object (File)
Mon, Jul 8, 22:30
Unknown Object (File)
Mon, Jul 8, 13:35

Details

Summary

This CSS fix replaces the hard coded white background value by the page.content CSS variable.

BeforeAfter
screenshot-phorge-bug-darkmode-ponder-answer-before.png (434×1 px, 23 KB)
screenshot-phorge-bug-darkmode-ponder-answer-after.png (434×1 px, 26 KB)
Test Plan
  • Flush all Phorge caches
  • Sign in
  • Go to question with at least one answer.
  • Check that the answer block background color is consistent with the theme.
  • Do these steps for each user interface theme in order to check against regression.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 16 2023, 09:37

You are a good minion, thanks bob

Tested with and without Dark Mode enabled

I confirm that Celerity map was already up to date \o/

sgtm

This revision is now accepted and ready to land.Aug 19 2023, 03:52