Page MenuHomePhorge

Teach Commit View about Encoding

Authored by avivey on Jul 26 2023, 17:55.
Referenced Files
Unknown Object (File)
Mon, Jul 15, 21:40
Unknown Object (File)
Sat, Jul 13, 22:08
Unknown Object (File)
Fri, Jul 12, 02:16
Unknown Object (File)
Mon, Jul 8, 22:07
Unknown Object (File)
Mon, Jul 8, 22:00
Unknown Object (File)
Mon, Jul 8, 13:43
Unknown Object (File)
Sun, Jul 7, 10:06
Unknown Object (File)
Mon, Jul 1, 01:20



If the user specifies a text encoding via the "View Options" dropdown, respect this choice.
Ref Q68.

Test Plan

Play with the Encoding button in the view

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

avivey held this revision as a draft.

Just a note from my side: I just applied this patch to our Phorge installation and it does exactly what we need. :)

avivey published this revision for review.Aug 26 2023, 07:46
avivey retitled this revision from teach commit view about encoding to Teach Commit View about Encoding.
avivey edited the test plan for this revision. (Show Details)

Interestingly I tried to open a simple README file and selecting UTF-8.

It said this nonsense message:

This document was converted from UTF-8 to UTF8 for display.

Is this a relevant corner case?

BTW apart from that, this seems very nice, thanks!

This revision is now accepted and ready to land.Aug 26 2023, 10:00
This revision was automatically updated to reflect the committed changes.