Page MenuHomePhorge

chris (Christopher Wetherill)
Not a robotAdministrator

Projects (8)

User Details

User Since
Jun 9 2021, 22:34 (19 w, 2 h)
Roles
Administrator

Recent Activity

Wed, Sep 22

chris awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Wed, Sep 22, 18:53

Sep 4 2021

chris added a comment to T15044: Co-Author support in arc land.

Ref also Git Commit Message Conventions. Adding a Co-authored-by: name <name@example.com> trailer to the commit message seems fairly well-accepted, at least for Git. GitHub and GitLab both recognize and parse it when present.

Sep 4 2021, 21:09 · Arcanist

Aug 28 2021

chris closed T15040: MGB task as Invalid.
Aug 28 2021, 12:21

Aug 18 2021

chris added a comment to D25017: Fix PhutilLibraryMapBuilder to call the right function in log().

@roguelazer - added you to Trusted Contributors so you should be able to land now

Aug 18 2021, 21:41
chris added a member for Trusted Contributors: roguelazer.
Aug 18 2021, 21:40

Jul 11 2021

chris updated subscribers of T15028: phorge.it bare domain usage? .

Looks like @deadalnix may need to update DNS:

$ dig phorge.it
[...]
;; ANSWER SECTION:
phorge.it.              0       IN      A       217.70.184.38

versus

$ dig we.phorge.it
[...]
;; ANSWER SECTION:
we.phorge.it.           0       IN      A       198.74.57.92
Jul 11 2021, 21:45 · Phorge General/Unknown

Jun 23 2021

chris added a comment to D25011: Remove CircleCI specific code from all over the place.

Slowing things down is rarely a good idea ever - at least for the reasons external to the patch in question, rejecting a patches because it's not good if obviously just fine. I reject that point outright.

Jun 23 2021, 14:04

Jun 20 2021

chris added a comment to T15016: Update default storage namespace.

One other option, if we're going to provide a migration guide, par of that could be setting the storage namespace... Brain fart and forgot that'll be something we do. But that'd let existing installs continue to use their Phab namespace and new ones the Phorge one

Jun 20 2021, 01:29 · Phorge General/Unknown
chris added a comment to T15016: Update default storage namespace.

Confirmed this does indeed break existing installs relying on the default. What options do we have to work around this? Couple that come to mind might be:

  • Add a new SQL patch that runs RENAME TABLE old_db.table_name TO new_db.table_name for every Phorge DB and table.
    • Con of this is that it may require a new GRANT ALL PRIVILEGES ON [...] statement based on how each install originally set things up (e.g., granting ON *.* versus ON phabricator%.*)
  • Add a line in the release notes telling users to ./bin/config set storage.default-namespace phabricator if they're using the default namespace
    • Con of this is it's an out-of-band upgrade step that relies on instance maintainers reading the release notes and not setting and forgetting an upgrade script in a crontab on the assumption that stable generally is pretty stable
  • Leave the default storage namespace as phabricator
Jun 20 2021, 00:55 · Phorge General/Unknown

Jun 19 2021

chris accepted D25007: Update Diviner documentation to reference Phorge instead of Phabricator..

Couple tiny nits and otherwise LGTM!

Jun 19 2021, 23:58
chris added a comment to T15000: Ad hoc setup tasks.

(It's all in src/docs and can be generated with ./bin/diviner generate)

Jun 19 2021, 03:05 · Upstream General/Unknown

Jun 18 2021

chris added a member for Blessed Committers: Ekubischta.
Jun 18 2021, 22:19
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Fair point on being precise with the terminology.

Jun 18 2021, 22:18 · Aphlict
chris accepted D25004: Update .gitignore to account for package-lock.json.
Jun 18 2021, 21:45 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Will it cause a conflict or ask the user to commit or stash untracked changes? But yeahhhhhh, will need some human intervention...

Jun 18 2021, 20:23 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Just confirmed on another instance:

  • Had an existing package-lock.json pinning ws to version 7.0.0
  • Manually updated package-lock.json to pin to version 7.5.0 (did not actually update installed version of ws)
  • Cycled Aphlict service
  • Sent a test notification
  • Received Web + Desktop popups
Jun 18 2021, 19:43 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

It _shouldn't_ mess up anything existing, I don't think. It's been a few months since I did a ton with JS so might be forgetting something obvious here, but if anyone already has Aphlict up and running, I'm pretty sure their existing install will be unimpacted by the presence/absense of package-lock.json. If they want to manually update their npm packages, then they might need the additional steps, but pretty sure it won't be disruptive outside of that.

Jun 18 2021, 19:30 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Do we actually want to be version controlling this? That's the recommended approach for Node projects, and given how hilariously awful dependency management is with npm, it might simplify support if we say "Aphlict runs with this specific version of websockets and its dependencies".

Jun 18 2021, 19:14 · Aphlict
chris added a comment to T15000: Ad hoc setup tasks.

Something was funky in how the repo was originally imported that was causing the issues. Somehow got to a state where it wasn't properly a bare repo (there wasn't a working tree, but everything was still inside .git/ instead of the root folder). Not sure how that happened, but seems to be resolved now

Jun 18 2021, 15:42 · Upstream General/Unknown
chris closed D25000: Update Readme.
Jun 18 2021, 15:39
chris committed rPfda1a5545066: Update Readme (authored by avivey).
Update Readme
Jun 18 2021, 15:39
chris awarded T15011: Build a Phorge Developer Environment a 100 token.
Jun 18 2021, 14:56 · Phorge General/Unknown

Jun 17 2021

chris added a comment to T15000: Ad hoc setup tasks.

Hah yup, we're all good in case everything catches fire. I'm around all evening and can revert changes if anything goes haywire

Jun 17 2021, 23:45 · Upstream General/Unknown
chris added a comment to T15000: Ad hoc setup tasks.

Thanks @speck! I think we also need to update the NGINX config and phabricator.base-uri config to we.phorge.it from secure. Will also require updating the clone URI. You want to just bundle both changes at once to make things easier? Looks like @deadalnix already updated DNS so that should be hunky dory

Jun 17 2021, 21:19 · Upstream General/Unknown
chris added a comment to T15000: Ad hoc setup tasks.

Yeah, logging perms should (I think) be fixed now. I was dumb when I chowned things and forgot what system users needed what access.

Jun 17 2021, 20:46 · Upstream General/Unknown
chris added a comment to T15000: Ad hoc setup tasks.

Same with a patch workflow against a fresh clone of the repo:

phorge  (master)$ arc --config phabricator.uri=https://secure.phorge.it patch D25000
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D25000.
Jun 17 2021, 20:28 · Upstream General/Unknown

Jun 16 2021

chris accepted D25000: Update Readme.

<do-it-live.gif>

Jun 16 2021, 18:05

Jun 14 2021

chris added a comment to T15008: Build Welcome Site.

From IRC a while back, for reference:

Evan Priestley (and others) wrote:

[01:09] ^[: epriestley: Looking at Phabricator from just the right angle, we can see that it's actually a web application framework which comes bundled with a handful of really sophisticated example applications. In your opinion, how silly would it be to surgically separate Phabricator-the-framework from Phabricator-the-dev-suite?
[01:31] epriestley: Relatively easy-ish. You can already use Phabricator as a web framework by subclassing "PhabricatorSite", and "phacility.com" is an extension that uses Phabricator as a framework.
[01:31] epriestley: Phabricator also sort of uses itself as a framework for public blogs in Phame ("PhameBlogSite").
[01:33] epriestley: Depending on your goals and use case, some details might need to be worked out, and some behaviors might be too Phabricator-flavored and difficult or impossible to override purely in extensions today, but I suspect there aren't many of these.
[01:34] epriestley: For example, extensions can get full control of top-level exception handling behavior by subclassing "AphrontRequestExceptionHandler".
[01:35] epriestley: Previously, a larger portion of "framework" behavior was in libphutil/, while "Phabricator" behavior was in phabricator/. The theory was that if you wanted to use the framework parts, you could depend on just libphutil.
[01:36] epriestley: However, essentially no one actually did this so it just represented an additional maintenance cost and general confusion for end-users, and I merged "libphutil/" into "arcanist/" and "phabricator/" last year.
[01:37] epriestley: The layers are still (for the most part) logically separate, they just live in the same repository now.
[01:42] epriestley: The biggest fundamental issue with thinking of Phabricator as a generic web application framework (internally, "Aphront") is probably that a lot of behavior depends on "PhabricatorUser $viewer", and "PhabricatorUser" is a concrete final class with a fair amount of Phabricator-specific behavior (it depends on the Lisk storage layer, etc). Decoupling that into "ViewerInterface $viewer" and making "PhabricatorUser
[01:42] epriestley: implements ViewerInterface" or similar could separate the layers, but that's probably a very messy change.
[01:46] epriestley: But it's also unnecessary if you're okay with using Phabricator's "system" applications (Auth, daemons, mail, etc) and just building your own user-facing applications. "admin.phacility.com" is a Phabricator application running on Phabricator-as-an-application-framework, using Phabricator auth and infrastructure but with none of the normal applications installed. If you install an app that provides a route for "/" and
[01:46] epriestley: uninstall the upstream "Home" app, your app becomes the new landing app.
[01:47] epriestley: (See also https://secure.phabricator.com/D11753.)

Jun 14 2021, 22:54 · Upstream General/Unknown
chris added a comment to T15000: Ad hoc setup tasks.

Looks like we.phorge.it is the winner coming out of that, with a static site hosted at the apex

Jun 14 2021, 22:00 · Upstream General/Unknown

Jun 13 2021

chris added a comment to T15000: Ad hoc setup tasks.

Fixed for real this time. I had an error in the sudoers file. Thought the webserver was running under a different user. But just cloned rARC with its HTTPS URI successfully, so should be hunky dory now hopefully.

Jun 13 2021, 18:41 · Upstream General/Unknown

Jun 12 2021

chris empowered 20after4 as an administrator.
Jun 12 2021, 23:12
chris added a member for Blessed Committers: 20after4.
Jun 12 2021, 23:06
chris added a member for Trusted Contributors: 20after4.
Jun 12 2021, 23:05
chris updated subscribers of T15000: Ad hoc setup tasks.

Good catch, thanks!

Jun 12 2021, 13:23 · Upstream General/Unknown

Jun 11 2021

chris added a comment to T15006: Re-brand Phorge.

I tried to get a start on this in P1, just running

grep -r -n -E '[Pp]habricator[ \.,;:\-\!\?)]' ./src

and found a few occurrences. Not sure how we want to handle the configuration values that are `phabricator.<XYZ>' since they're sort-of internal, sort-of exposed in the UI. I left them in the Paste just to have them documented

Jun 11 2021, 13:28 · Phorge
chris added a member for Blessed Committers: deadalnix.
Jun 11 2021, 01:16
chris empowered deadalnix as an administrator.
Jun 11 2021, 01:15

Jun 10 2021

chris added a comment to T15004: Decide who has admin/commit/security access.

There is great benefit from having people submitting the code to push it themselves.

Jun 10 2021, 22:47 · Phorge, Governance
chris updated the task description for T15000: Ad hoc setup tasks.
Jun 10 2021, 20:48 · Upstream General/Unknown
chris updated the task description for T15000: Ad hoc setup tasks.
Jun 10 2021, 20:09 · Upstream General/Unknown
chris updated the task description for T15000: Ad hoc setup tasks.
Jun 10 2021, 20:08 · Upstream General/Unknown
chris added a comment to T15001: Set up initial policies.

Could just do like Phorge UpstreamGovernance, PhorgeManiphest, etc. with subprojects to have a kind of clean-ish separation between "application" stuff and "administrative" stuff?

Jun 10 2021, 18:32 · Upstream General/Unknown
chris added a member for Phorge: chris.
Jun 10 2021, 17:43
chris updated chris.
Jun 10 2021, 17:43
chris created T15000: Ad hoc setup tasks.
Jun 10 2021, 15:02 · Upstream General/Unknown
chris empowered Matthew as an administrator.
Jun 10 2021, 03:57
chris empowered speck as an administrator.
Jun 10 2021, 03:16

Jun 9 2021

People empowered chris as an administrator.
Jun 9 2021, 22:47