Page MenuHomePhorge

Fix label of submit button in timezone conflict dialog

Authored by waldyrious on Aug 29 2023, 21:32.
Referenced Files
Unknown Object (File)
Wed, Jun 12, 18:18
Unknown Object (File)
Sun, Jun 9, 15:41
Unknown Object (File)
Sat, Jun 8, 13:35
Unknown Object (File)
Sat, Jun 8, 12:54
Unknown Object (File)
Sat, Jun 8, 10:54
Unknown Object (File)
Thu, Jun 6, 02:27
Unknown Object (File)
Thu, May 30, 20:57
Unknown Object (File)
Thu, May 30, 05:08


Group Reviewers
O1: Blessed Committers

The timezone conflict dialog allows the user to either:

  • change the profile timezone setting to match the browser timezone
  • ignore the conflict

However, the submit button was explicitly labeled "Change Timezone", which is innacurate if the user picks the "Ignore Conflict" option from the dropdown menu.

This patch changes the label of the submit button to "Submit", so that it works for both ignoring the conflict and setting a new profile timezone.

Test Plan
  • Change your browser/system timezone to differ from your Phorge profile timezone
  • Click the notice that Phorge shows at the bottom left about the timezone mismatch
  • Confirm that the submit button now says "Submit" instead of "Change Timezone"

Diff Detail

rP Phorge
Lint Skipped
Tests Skipped

Event Timeline

waldyrious edited the summary of this revision. (Show Details)

See D25420 for a conflicting change...

Thanks for the heads-up! That's a better approach indeed. I will abandon this patch in favor of that one.