Page MenuHomePhorge

PHUITagView and similar: it's unclear whenever 'href' should be just a string
Open, NormalPublic

Description

If you received a similar error message, please share your stack trace!

The variable href received an unexpected type: PhutilURI. Please share your stack trace as comment in Task https://we.phorge.it/T15316` you are in the good place!

This is a task that can be useful to discuss the href parameter of these classes:

https://we.phorge.it/source/phorge/browse/master/src/view/phui/PHUITagView.php

https://we.phorge.it/source/phorge/browse/master/src/view/phui/PHUIObjectItemView.php

Event Timeline

valerio.bozzolan triaged this task as Normal priority.
valerio.bozzolan created this object in space S1 Public.
valerio.bozzolan renamed this task from PHUITagView: it's unclear whenever 'href' should be just a string to PHUITagView and similar: it's unclear whenever 'href' should be just a string.May 2 2023, 09:07

I went to https://we.phorge.it/D25018 and that URL says:
Received unexpected type for href: PhutilURI. Please paste this log as comment in https://we.phorge.it/T15316

PhutilURI is obviously a better type for href then string. It should not log anything in this case...

https://we.phorge.it/source/phorge/browse/master/src/view/phui/PHUITagView.php$114 is the offending line.

@valerio.bozzolan: This is now spamming our error logs. Any recommendations how to proceed?

@aklapper Can you please share your stack trace?

I think we already improved the situation in master. Check the last 2 commits mentioned above by avivey

Argh, sorry for my comment. I missed that rPbcfcd9acfc12fdf8ca3bf0e2c89651ba6d159b17 removed that noise already! (Anyway, I cannot share a stack trace when no stack trace is printed anyway.)