Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aklapper
	May 4 2023, 20:45

Description

Upstreaming this from https://phabricator.wikimedia.org/T158177 and https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/024c5b0d1d05cbac148128eb0f77df7ac578220b , as we had several folks expressing their confusion about the current message.

In downstream, we changed the following two messages:
"Your browser timezone setting differs from the timezone setting in your profile, click to reconcile." to
"Your browser timezone setting differs from the timezone setting in your profile, click to reconcile or ignore the conflict."
and
"Your browser timezone (%s) differs from your profile timezone (%s). You can ignore this conflict or adjust your profile setting to match your client." to
"Your browser timezone (%s) differs from your profile timezone (%s). You can ignore this conflict or adjust your profile setting to match your client. Ignoring the conflict is the top option in the dropdown menu.",

The corresponding files in Phorge which include these strings are:

src/view/page/PhabricatorStandardPageView.php
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

Current	Proposed

Revisions and Commits

rP Phorge
	D25420	rP37ecdf233697 Improving UX for ignoring timezone conflicts

Related Objects

Mentioned In: 2023 week 49
Next Up
Mentioned Here: D25420: Improving UX for ignoring timezone conflicts

Event Timeline

aklapper created this task.May 4 2023, 20:45

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMay 4 2023, 20:45

valerio.bozzolan awarded a token.May 4 2023, 21:16

valerio.bozzolan subscribed.

avivey removed a project: Phorge.May 9 2023, 10:42

A friendlier UX might be to add a button/checkbox for "ignore this conflict".
This can be implemented in either the controller or in javascript, to act as if the user selected "ignore" in the drop-down).

I don't know how to add a third button in a modal, but I would agree on that approach.

In T15349#13341, @valerio.bozzolan wrote:

I don't know how to add a third button in a modal, but I would agree on that approach.

Yes that's the second reason I added a new notification.
I managed to add the third button in the footer, but before writing any logic I would like to confirm with you that it looks right now. No additional notifications, the same dialog window.