Page MenuHomePhorge

Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict
Closed, ResolvedPublic

Description

Upstreaming this from https://phabricator.wikimedia.org/T158177 and https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/024c5b0d1d05cbac148128eb0f77df7ac578220b , as we had several folks expressing their confusion about the current message.

In downstream, we changed the following two messages:
"Your browser timezone setting differs from the timezone setting in your profile, click to reconcile." to
"Your browser timezone setting differs from the timezone setting in your profile, click to reconcile or ignore the conflict."
and
"Your browser timezone (%s) differs from your profile timezone (%s). You can ignore this conflict or adjust your profile setting to match your client." to
"Your browser timezone (%s) differs from your profile timezone (%s). You can ignore this conflict or adjust your profile setting to match your client. Ignoring the conflict is the top option in the dropdown menu.",

The corresponding files in Phorge which include these strings are:

  • src/view/page/PhabricatorStandardPageView.php
  • src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
CurrentProposed
Adjust time - Before.png (239×822 px, 27 KB)
Adjust time - After.png (275×822 px, 31 KB)

Event Timeline

avivey triaged this task as Normal priority.Jun 1 2023, 06:02
avivey subscribed.

A friendlier UX might be to add a button/checkbox for "ignore this conflict".
This can be implemented in either the controller or in javascript, to act as if the user selected "ignore" in the drop-down).

I don't know how to add a third button in a modal, but I would agree on that approach.

I don't know how to add a third button in a modal, but I would agree on that approach.

Yes that's the second reason I added a new notification.
I managed to add the third button in the footer, but before writing any logic I would like to confirm with you that it looks right now. No additional notifications, the same dialog window.

adjust-timezone-dialog.png (246×823 px, 26 KB)

I like so much this popup, thanks Roberto

Yeah, the dialog looks better then the extra notification...

Thanks Roberto, feel free to update D25420 to reflect your lovely screenshot.