Page MenuHomePhorge

Diffusion: Create Identity form is incomplete
Open, Needs TriagePublic

Description

Navigating to /diffusion/identity/ and clicking the Create Identity button will present a form with a single field, "Assigned To". Regardless of leaving this empty or putting in a user account, submitting the form results in an error about the authorPHID column not allowed to be null.

While investigating T15440 it seems that the PhabricatorDiffusionIdentity created by this form is missing a number of fields such that it cannot be persisted to the database. This appears to be an incomplete workflow. The form likely needs to be fleshed out to fill in all the state that makes up an identity. It's possible the current implementation was intended to be a multi-form step, e.g. select the assignee then continue to another form for filling in other details.

Event Timeline

As this is broken anyway (and creates noisy log spam when someone tries to use the broken Create Identity form), would it make sense in the meantime as a workaround to disable (or hide, but no idea how to do that for a PhabricatorEditEngine) that form for every and any user? A one-line hack would be in P22.