I'd be worried that this might break some tests that do relate to translation/extraction, but running arc unit --everything should solve that.

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

You can set "visibility" for each URI already.

Yeah, thad makes sense, I guess.

In D25548#17006, @valerio.bozzolan wrote:

I see "Unknown object" if the Diff repository is unset. Is that known?

• check for non-null repository in Revision
• rebase

Pending that small inline, lgtm.

Can't reproduce either - 🤷🏻‍♂️

Done - #ponder now refers to the new (active) tag.

I thought we had a ticket for "allow more things to show up in workboards", but I can't find it.

done...

Yeah, probably. I'll try to do it tonight.

Maybe put the warning above the box, so it catches all actions, not just comments?

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

In D25575#16550, @valerio.bozzolan wrote:

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

I've created D25575 for this case, and filed T15783 for the broader issue.

Done:

Did that Phactory: Hosting Projects Here

This script can be used to download the entire graph:

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Doesn't actually work for me either after arc patch:

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

• Don't exist in Diffusion
• Do exist in Paste
• Don't exist in Differential

There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.

You should be able to just arc land this now...

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

As a work-around, you can probably add ?offset=0 to the URL.

(The images aren't public/attached, so I can't see them)

All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷‍♂️

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

In D25568#16354, @valerio.bozzolan wrote:

In this way, do we skip that column creating a column shift?

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

The Github syntax for this is bad. That's the code block syntax. It makes it impossible to have code-block with mermaid syntax.

looks good to me - couple of small inlines....

(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)

:-)

Is that really as trivial as in my last revision?

house-keeping...

Changing status for house-keeping.

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Can we just define the used properties instead? Doesn't look like there's too many of them.

IIRC, The save() command won't generate any Feed item, so the unified feed entry would be either "xxx triaged this task" or "xxx added a comment". Also, for each comment added, a new Feed item will be generated, which is probably not what you'd like.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

So this is quite an edge-case:

• PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
• There's an automatic rule, saying a member of a project can always view the project
• When loading the project for the hovercard, we don't bother loading all the member list
• When loading the user for the mention, we don't bother loading all its projects
• so data is not available at the rendering point.

I can't immediately reproduce with that version either. I'll try again later.
In the meanwhile:

• Try clearing your browser's cache
• Try updating Phorge to the latest commit
• Try disabling this extension: assets/DisableUsernameEditEventListener.php

I can reproduce this on master with basically any string search.

I can't reproduce this.
Which version of phorge/arc do you have (git log -1)?
How did you install the new Instance?