Page MenuHomePhorge

Fix setup check for gzip request mangling being sent as GET
ClosedPublic

Authored by kat on Apr 1 2024, 17:53.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 18:52
Unknown Object (File)
Mon, May 20, 18:20
Unknown Object (File)
Sat, May 18, 04:23
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Wed, May 8, 04:57
Unknown Object (File)
Wed, May 8, 04:32
Unknown Object (File)
Sat, May 4, 18:54
Tokens
"Mountain of Wealth" token, awarded by 20after4.

Details

Summary

Certain web servers (or cache layers such as Varnish) strip the body
of GET requests, resulting in the setup check failing when it would
otherwise function normally if a request is sent as POST.

Test Plan

Phorge will no-longer mark the test as failing due to the body of a GET request being dropped.
As per RFC7231, certain implementations of HTTP/1.1 may reject the request or drop the payload
due to a previous revision of the spec where the body was supposed to be ignored (RFC2616, section 4.3)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kat requested review of this revision.Apr 1 2024, 17:53
20after4 subscribed.

Discussed on IRC: it seems that this should have been POST all along.

This revision is now accepted and ready to land.Apr 1 2024, 18:11
speck subscribed.

Ah yep, GET with body will get flagged in a number of cases.

@kat: I've added you to the Trusted Contributors project, so you can now land this change!