Differential D25566

Fix setup check for gzip request mangling being sent as GET
ClosedPublic
Actions

Authored by kat on Apr 1 2024, 17:53.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 28, 01:22

	Unknown Object (File)
	Wed, Apr 17, 18:27

	Unknown Object (File)
	Wed, Apr 17, 07:14

	Unknown Object (File)
	Tue, Apr 9, 14:18

	Unknown Object (File)
	Tue, Apr 9, 02:02

	Unknown Object (File)
	Mon, Apr 8, 08:11

	Unknown Object (File)
	Sun, Apr 7, 16:39

	Unknown Object (File)
	Sat, Apr 6, 11:44

View All 14 Files

Subscribers

valerio.bozzolan

Tokens

"Mountain of Wealth" token, awarded by 20after4.

Details

Reviewers

20after4
speck
avivey

Group Reviewers

O1: Blessed Committers

Commits

rPd4af32c1d412: Fix setup check for gzip request mangling being sent as GET

Summary

Certain web servers (or cache layers such as Varnish) strip the body
of GET requests, resulting in the setup check failing when it would
otherwise function normally if a request is sent as POST.

Test Plan

Phorge will no-longer mark the test as failing due to the body of a GET request being dropped.
As per RFC7231, certain implementations of HTTP/1.1 may reject the request or drop the payload
due to a previous revision of the spec where the body was supposed to be ignored (RFC2616, section 4.3)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kat created this revision.Apr 1 2024, 17:53

Owners added a reviewer: O1: Blessed Committers.Apr 1 2024, 17:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 1 2024, 17:53

Harbormaster completed remote builds in B1138: Diff 1805.Apr 1 2024, 17:53

kat requested review of this revision.Apr 1 2024, 17:53

Discussed on IRC: it seems that this should have been POST all along.

This revision is now accepted and ready to land.Apr 1 2024, 18:11

Ah yep, GET with body will get flagged in a number of cases.

avivey accepted this revision.Apr 2 2024, 07:44

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Closed by commit rPd4af32c1d412: Fix setup check for gzip request mangling being sent as GET. · Explain WhyApr 2 2024, 18:49

This revision was automatically updated to reflect the committed changes.

kat added a commit: rPd4af32c1d412: Fix setup check for gzip request mangling being sent as GET.

kat mentioned this in Z1: Phorge.Apr 2 2024, 18:51

20after4 awarded a token.Apr 2 2024, 19:15

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

config/

check/

PhabricatorWebServerSetupCheck.php

1 line

O1: Blessed Committers

Diff 1810

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Loading...