Page MenuHomePhorge
Create Task
Maniphest T15749

Display warning about commenting on a task which is closed as a duplicate
Open, Needs TriagePublic
Actions

Description

Upstreaming from https://phabricator.wikimedia.org/T354769

Launchpad.net shows a warning above the comment field to logged-in users for tasks closed as a duplicate:

This task is a duplicate of T1234567. Comment here only if you think that it is not a duplicate.

This can make it clearer to users (who may have followed an anchor link and not see the task status at the top) not to fragment conversations, and thus save triagers' time explaining how things are supposed to work in Phorge.

Revisions and Commits

rP Phorge
Needs ReviewD25546 Warn in comment field if task is closed as duplicate

Event Timeline

aklapper created this task.Feb 29 2024, 16:56
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptFeb 29 2024, 16:56
aklapper added a revision: D25546: Warn in comment field if task is closed as duplicate.Feb 29 2024, 17:07
valerio.bozzolan subscribed.Mar 1 2024, 12:55
avivey subscribed.Sun, Apr 14, 08:22

Maybe put the warning above the box, so it catches all actions, not just comments?

aklapper added a comment.Tue, Apr 16, 10:44
In T15749#16629, @avivey wrote:

Maybe put the warning above the box, so it catches all actions, not just comments?

That's another option (and would allow additional text formatting). My personal preference for a placeholder text is probably based on not using additional screen estate, especially on small screens. The main question in any case though is how to get the current EditEngine in an acceptable (sufficiently performant) way.

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0