Page MenuHomePhorge
Feed Advanced Search

Today

revi awarded D25440: Show Deprecation Warnings as Setup Warnings a Party Time token.
Sat, Sep 23, 21:03
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

So would the latter option mean doing $html_details = array($head, $more, implode(' ', $exceptions)); here? I kind of find this approach cleaner than appending a space to each item in the $exceptions array.

Sat, Sep 23, 14:55
avivey added inline comments to D25363: Match yourself from Imported Events Invitees.
Sat, Sep 23, 09:05
avivey added a project to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land": UX.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Sat, Sep 23, 06:11 · UX, Differential
avivey updated the task description for T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".
Sat, Sep 23, 05:53 · UX, Differential
avivey added a comment to T15512: Reimplement "Flags" to be based on Edges.

Interestingly: https://secure.phabricator.com/T10574 argues for removal of the additional data from edges.

Sat, Sep 23, 05:36
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

... whereas the $html_details is constructed as merely array($head, $more, $exceptions); ...

Sat, Sep 23, 05:07

Yesterday

avivey requested review of D25440: Show Deprecation Warnings as Setup Warnings.
Fri, Sep 22, 19:41
avivey added a revision to T15554: Handling PHP deprecations: convert to Setup Issues: D25440: Show Deprecation Warnings as Setup Warnings.
Fri, Sep 22, 19:41 · Phorge
avivey created an object: Report-warnings.
Fri, Sep 22, 19:02
avivey created an object: Docs.
Fri, Sep 22, 19:02

Mon, Sep 18

avivey added inline comments to D25051: Destroy file attachments when file is deleted.
Mon, Sep 18, 07:47 · Files

Sun, Sep 17

avivey added a comment to T15639: Exception: Value passed to "phutil_string_cast()" is an array in PhabricatorApplicationSearchEngine.php.

Without a reproduction, this is speculative.

Sun, Sep 17, 07:38
avivey requested changes to D25438: Allow branch names to be integer values to avoid an InvalidArgumentException.

Why would a branch name be an integer and not a string?

Sun, Sep 17, 07:35

Fri, Sep 15

avivey added a comment to Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).

Yeah, I generally agree with "let the user set the width of the page"...

Fri, Sep 15, 08:28
avivey added Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).
Fri, Sep 15, 08:08

Wed, Sep 13

revi awarded T15554: Handling PHP deprecations: convert to Setup Issues a The World Burns token.
Wed, Sep 13, 16:40 · Phorge

Mon, Sep 11

avivey accepted D25435: Fix rendering of cowsay sheep.cow.
Mon, Sep 11, 19:04
avivey added a comment to D25435: Fix rendering of cowsay sheep.cow.

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

Mon, Sep 11, 10:32

Fri, Sep 8

avivey committed R6:ef927d616f71: Add quick-access buttons to lists (authored by avivey).
Add quick-access buttons to lists
Fri, Sep 8, 08:09

Tue, Sep 5

avivey accepted D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Tue, Sep 5, 14:29
avivey added a comment to T15630: Fix Fonts.

Did some digging, and it looks like Segoe is not something we can use:

Tue, Sep 5, 06:14
avivey updated the task description for T15630: Fix Fonts.
Tue, Sep 5, 05:52

Mon, Sep 4

avivey edited the content of Next Up.
Mon, Sep 4, 16:57
avivey accepted D25413: Show a link to the Phorge homepage.
Mon, Sep 4, 06:26

Sun, Sep 3

avivey committed R6:4322021080d4: Allow Instance queries to appear in Dashboards (authored by avivey).
Allow Instance queries to appear in Dashboards
Sun, Sep 3, 20:56
avivey committed R6:c9b9dc3eb624: Crumbs in Item page should lead to item list, not type page (authored by avivey).
Crumbs in Item page should lead to item list, not type page
Sun, Sep 3, 20:56
avivey changed the image for Image Macro "allthethings".
Sun, Sep 3, 06:43
avivey accepted D25430: Implement ferret engine in typeahead datasource query for repos.

makeitso

Sun, Sep 3, 06:41

Fri, Sep 1

bekay awarded Blog Post: August 2023 Release a Party Time token.
Fri, Sep 1, 13:54
valerio.bozzolan awarded Blog Post: August 2023 Release a Love token.
Fri, Sep 1, 09:16
avivey created Blog Post: August 2023 Release.
Fri, Sep 1, 09:12
avivey added a comment to T15174: Phorge←GitHub: create a bot that imports "Pull requests".

Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?

Fri, Sep 1, 09:02 · Phactory: Community Projects, User-valerio.bozzolan, GitHub
avivey renamed T15554: Handling PHP deprecations: convert to Setup Issues from Handling PHP deprecations: Maybe convert to Setup Issues? to Handling PHP deprecations: convert to Setup Issues.
Fri, Sep 1, 08:54 · Phorge
avivey edited the content of 2023 Week 32.
Fri, Sep 1, 08:12
avivey edited the content of 2023 Week 23.
Fri, Sep 1, 08:11

Thu, Aug 31

tinloaf awarded rP69c64c1e83e2: Teach Commit View about Encoding a Love token.
Thu, Aug 31, 19:46
avivey closed D25360: Teach Commit View about Encoding.
Thu, Aug 31, 18:00
avivey committed rP69c64c1e83e2: Teach Commit View about Encoding (authored by avivey).
Teach Commit View about Encoding
Thu, Aug 31, 18:00
avivey closed D25386: log deprecation events in Dark Console.
Thu, Aug 31, 15:18
avivey committed rP94c0774d8055: log deprecation events in Dark Console (authored by avivey).
log deprecation events in Dark Console
Thu, Aug 31, 15:18
avivey closed D25387: Error handling: send Deprecation messages as explicit Event.
Thu, Aug 31, 15:14
avivey committed rARCd343be59269a: Error handling: send Deprecation messages as explicit Event (authored by avivey).
Error handling: send Deprecation messages as explicit Event
Thu, Aug 31, 15:14
avivey added a comment to D25359: Generate more fields in Download Raw Diff.

hey, @ton - is this useful for you?

Thu, Aug 31, 15:10
avivey added a comment to Q74: Minio over HTTP (without SSL) as an S3 backend (Answer 100).

yeah, just default to https if it doesn't include a schema, and I think it should be fine in that regards.
There's probably already some method somewhere that looks at a uri and chooses HTTPFuture or HTTPSFuture based on the schema...

Thu, Aug 31, 11:47
avivey edited Description on Trusted Contributors.
Thu, Aug 31, 11:45
avivey added a member for Trusted Contributors: alufers2.
Thu, Aug 31, 11:45
avivey added Q74: Minio over HTTP (without SSL) as an S3 backend (Answer 100).
Thu, Aug 31, 11:43
avivey triaged T15630: Fix Fonts as High priority.
Thu, Aug 31, 08:22
avivey added Q73: File Visibility (Answer 99).
Thu, Aug 31, 07:07
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Thu, Aug 31, 06:44

Wed, Aug 30

avivey closed D25429: Generate Diviner book for Javelin.
Wed, Aug 30, 18:20
avivey committed rPaeab4efe17cf: Generate Diviner book for Javelin (authored by avivey).
Generate Diviner book for Javelin
Wed, Aug 30, 18:20
avivey requested review of D25429: Generate Diviner book for Javelin.
Wed, Aug 30, 18:17
avivey added a comment to D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

Wed, Aug 30, 14:24
avivey added a comment to D25426: Fix label of submit button in timezone conflict dialog.

See D25420 for a conflicting change...

Wed, Aug 30, 06:22
avivey added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

ooh, check out D25349 for basically this exact use-case...

Wed, Aug 30, 06:21

Tue, Aug 29

avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Tue, Aug 29, 14:19
avivey accepted D25420: Improving UX for ignoring timezone conflicts.
Tue, Aug 29, 12:49
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Tue, Aug 29, 08:45
avivey requested changes to D25420: Improving UX for ignoring timezone conflicts.
Tue, Aug 29, 08:44

Mon, Aug 28

avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Mon, Aug 28, 18:43
avivey added a comment to D25420: Improving UX for ignoring timezone conflicts.

if you check the checkbox, it will use the current setting timezone.

Mon, Aug 28, 18:39

Sun, Aug 27

avivey added a comment to D25387: Error handling: send Deprecation messages as explicit Event.

I'm thinking of adding similar handling for E_USER_NOTICE and E_USER_WARNING - to allow using them in extension code and in things like T15316 (Right now, we treat those as fatal errors too).

Sun, Aug 27, 08:07

Sat, Aug 26

avivey added a comment to T15554: Handling PHP deprecations: convert to Setup Issues.

Would taking care of the depreciations bump the minimum PHP version required to run Phorge?

Not in itself, but we do plan to bump the minimum to 7.1 (in T15047).

Sat, Aug 26, 16:59 · Phorge
avivey edited the content of 2022 Week 37.
Sat, Aug 26, 16:31
avivey edited the content of 2023 Week 23.
Sat, Aug 26, 16:30
avivey edited the content of 2023 Week 17.
Sat, Aug 26, 16:30
avivey published D25360: Teach Commit View about Encoding for review.
Sat, Aug 26, 07:46

Fri, Aug 25

avivey removed a project from T15627: Clicking on meme then cancel causes redirection to homepage and dialog does not disappear: Phorge.

Does not reproduce to me.
Which browser are you using? Are there any javascript errors?

Fri, Aug 25, 18:31 · UX, Bug Reports
avivey added a member for Trusted Contributors: Juest.
Fri, Aug 25, 17:58
avivey added a comment to T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict.

Yeah, the dialog looks better then the extra popup...

Fri, Aug 25, 15:24 · Good Starter Task
avivey edited the content of Change Log.
Fri, Aug 25, 11:58
avivey edited the content of 2023 Week 32.
Fri, Aug 25, 11:57
avivey committed rARCb5140eed542a: Promote 2023.32 to Stable (authored by avivey).
Promote 2023.32 to Stable
Fri, Aug 25, 11:55
avivey committed rP56789a2fa681: Replace dedicated Commit Field with an existing one (authored by avivey).
Replace dedicated Commit Field with an existing one
Fri, Aug 25, 11:54
avivey committed rP11424ffbe664: Promote 2023.32 to Stable (authored by avivey).
Promote 2023.32 to Stable
Fri, Aug 25, 11:54

Aug 24 2023

avivey added a comment to D25420: Improving UX for ignoring timezone conflicts.

But it adds another notification, and now the user will have to pick between 2 buttons that say "solve conflict".
It's also not the common path - in the common case, we expect users to actually approve the timezone offered by the dialog (which should be the one detected from the browser).

Aug 24 2023, 15:47
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

0. Welcome!

  1. This diff is based of a commit that's not in master - some local changes that make it not-apply
  2. the space should be on the inside of the pht(), not attached to it.
  3. even better, find whatever is calling describeAutomaticCapability(), and if it accepts an array (some implementations return array, some return string), have the caller add a space between each element of the array - solving this once for all callers...
Aug 24 2023, 15:46
avivey added a comment to D25420: Improving UX for ignoring timezone conflicts.

Adding another notification will only make this more annoying.

Aug 24 2023, 15:43

Aug 22 2023

avivey added a comment to D25417: Fix RuntimeException: min(): Array must contain at least one element.

whatcouldgowrong

Aug 22 2023, 09:27
avivey accepted D25417: Fix RuntimeException: min(): Array must contain at least one element.
Aug 22 2023, 09:27
avivey added a project to T15491: Add config option for default branch name: Good Starter Task.

This might be a Good Starter Task, I think - you'll need to add a class for the config, and pull the config value in diffusion.

Aug 22 2023, 07:28 · Good Starter Task, Feature Requests, Diffusion
avivey added a comment to T15583: Typeahead datasource query for repos should match substrings.

go for it.

Aug 22 2023, 07:13 · Feature Requests, Diffusion

Aug 21 2023

avivey added a comment to T15583: Typeahead datasource query for repos should match substrings.

a hack that might work: add a field in the document that's called "typeahead-text" or something, and put both title and callsign into it (and maybe number and short-name as well). Then use that field in the Datasource.
Since this is a full-text field, whatever the user types will fit this field...

Aug 21 2023, 17:59 · Feature Requests, Diffusion
avivey added a comment to T15583: Typeahead datasource query for repos should match substrings.

rP99c9df96b4ffbf7 (2015) is the big "convert to Full Text Search" commit, but looks like it's not about Ferret (2017?).

Aug 21 2023, 15:36 · Feature Requests, Diffusion
avivey added a comment to T15583: Typeahead datasource query for repos should match substrings.

I suspect that the code in People is the oldest one - this stuff blames to 2011! and does explicit sql stuff!

Aug 21 2023, 15:21 · Feature Requests, Diffusion
avivey added a comment to T15583: Typeahead datasource query for repos should match substrings.

Yeah, that's probably good - that's the query for typeaheads and probably global search, but not for other cases.

Aug 21 2023, 11:29 · Feature Requests, Diffusion
avivey added a project to T15583: Typeahead datasource query for repos should match substrings: Feature Requests.

Yeah, totally reasonable feature request.
Do you think you can implement?
This might involve the Ferret engine (like this thing, or maybe there's a simpler approach for the query (title LIKE %text% in the Query class?).

Aug 21 2023, 08:14 · Feature Requests, Diffusion
avivey added Q72: Add support for Cloudflare Turnstile (A Captcha alternative)? (Answer 98).
Aug 21 2023, 06:11
avivey updated Q72: Add support for Cloudflare Turnstile (A Captcha alternative)? from Add support for Cloudflare Turnstile? to Add support for Cloudflare Turnstile (A Captcha alternative)?.
Aug 21 2023, 05:58

Aug 20 2023

avivey added a comment to D25359: Generate more fields in Download Raw Diff.

IDK - this was code was never explicitly about git am - I think it was about patch, which started in the stone age and predates things like "formal specification".

Aug 20 2023, 08:34
avivey added a subtask for T15535: Using Differential with plain Git, without requiring Arc: T15250: Raw use of "git diff" provides insufficient Diff Context.
Aug 20 2023, 08:20 · Feature Requests
avivey added a parent task for T15250: Raw use of "git diff" provides insufficient Diff Context: T15535: Using Differential with plain Git, without requiring Arc.
Aug 20 2023, 08:20 · Affects-FreeBSD, Differential

Aug 19 2023

avivey closed T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Aug 19 2023, 06:36 · PHP 8 support
avivey closed T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible as Resolved by committing rPba4b8cb1ae7d: PHP 8 and Diviner Technical Documentation.
Aug 19 2023, 06:36 · PHP 8 support
avivey closed D25412: PHP 8 and Diviner Technical Documentation.
Aug 19 2023, 06:36
avivey committed rPba4b8cb1ae7d: PHP 8 and Diviner Technical Documentation (authored by avivey).
PHP 8 and Diviner Technical Documentation
Aug 19 2023, 06:36

Aug 18 2023

avivey requested review of D25412: PHP 8 and Diviner Technical Documentation.
Aug 18 2023, 19:31
avivey added a revision to T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible: D25412: PHP 8 and Diviner Technical Documentation.
Aug 18 2023, 19:31 · PHP 8 support