Page MenuHomePhorge
Feed Advanced Search

Sun, Jun 16

avivey updated the question details for Q139: Add remarkup syntax help for custom remarkup rule tokens.
Sun, Jun 16, 15:49 · Extension Development
avivey added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 171).
Sun, Jun 16, 15:44
avivey added Q138: SAML 2.0 support (Answer 170).
Sun, Jun 16, 15:33
avivey added a comment to D25546: Warn in comment field if task is closed as duplicate.

I still don't like the solution of using place-holder text for that; But this implementation also adds another DB access which I think is redundant.

Sun, Jun 16, 09:16
avivey added a comment to D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Instead of this diff, can you add a modern endpoint that uses the EditEngine/transactions? e.g. maniphest.edit, badge.edit, etc.
That will need a different name, but will allow full editing capability.

Sun, Jun 16, 07:53

Sun, Jun 9

avivey added a comment to T15724: PHP 8.3: ldap_connect() call signature deprecated.

So PHP, very wow

Sun, Jun 9, 06:54 · PHP 8 support

Fri, Jun 7

avivey added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Fri, Jun 7, 19:58

Thu, Jun 6

avivey accepted D25682: Fix a leftover misspelled "Phabricator" reference.

There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.

Thu, Jun 6, 06:52

Tue, Jun 4

avivey added a comment to D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).

Please add some negative tests - things that could trigger this thing, but shouldn't.

Tue, Jun 4, 06:58
avivey added a revision to T15774: Celerity: javascript minification issue with template literals (backticked strings): D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Tue, Jun 4, 06:51
avivey added a task to D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings): T15774: Celerity: javascript minification issue with template literals (backticked strings).
Tue, Jun 4, 06:51

Mon, Jun 3

avivey accepted D25678: Expose initially set values of Maniphest custom date field and point values when removing them.
Mon, Jun 3, 12:37
avivey accepted D25677: Remove unused method shouldCopyWhenCreatingSimilarTask().
Mon, Jun 3, 10:55

Sun, Jun 2

avivey added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

I think the EditEngine is what's used to create the actions form, and it has some sense of the object's status (see for example the available actions on Revisions - these change based on the revision's state).
Maybe it can get an additional "field" for this warning, and display it based on task status.

Sun, Jun 2, 06:51 · Feature Requests

Wed, May 29

avivey awarded T15843: Allow collapse and expand of workboard columns in mobile view a Hungry Hippo token.
Wed, May 29, 07:12 · Workboard
avivey added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

Very cool!

Wed, May 29, 07:12
avivey accepted D25669: Improve error passing task IDs as URL parameter in invalid format.

Don't we have something like phutil_is_integer method somewhere?

Wed, May 29, 07:00

Sun, May 26

avivey closed T15840: Don't give bad password advice when resetting password as Spite.
Sun, May 26, 19:21

Sat, May 25

avivey accepted D25670: Fix spelling of etc. in messages per Translatewiki request.

This is spelling, not formatting.

Sat, May 25, 07:15
avivey added a comment to T15840: Don't give bad password advice when resetting password.

Using a password in 2024 is a bad advice in general.

Sat, May 25, 07:09

Tue, May 21

avivey accepted D25666: PHPMailer: Remove duplicate array keys.
Tue, May 21, 08:31
avivey added a comment to D25668: Add Open Graph protocol meta tags to Maniphest task pages.

need to also test the result of renderPhabricatorLogo() when no logo set, when a custom logo is set, and when a custom logo is set but hidden (maybe. Maybe the logo file should be Attached to something public, so this situation can't really happen?)

Tue, May 21, 07:31
avivey added a comment to T15121: Contributor Agreement.

That "don't sign a CLA" article should be titled "don't sign away your copyrights", to be more accurate and less click-bait-y. A CLA may ask you to sign away copyrights (which I feel makes the project non-open-source) ; It doesn't have to.

Tue, May 21, 06:28 · Phorge

May 19 2024

aklapper awarded T15048: Allow awarding Tokens to individual Comments a Love token.
May 19 2024, 19:46 · Comments
avivey added a project to T15835: Misc "Return type is not covariant" errors for method Iterator::key(): PHP 8 support.
May 19 2024, 06:12 · PHP 8 support
avivey updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().
May 19 2024, 06:11 · PHP 8 support
avivey accepted D25663: PHPMailer: Remove check for non-existing get_magic_quotes().
May 19 2024, 06:06

May 14 2024

avivey added a comment to D25035: Hide the blurb of a user when that user is disabled.

(It's about spam, but it doesn't have anything explicitly sensitive. I've made it public now)

May 14 2024, 16:02
avivey changed the visibility for T15074: Hide profile pictures and descriptions of disabled users.
May 14 2024, 16:00 · Security

May 12 2024

avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

On a more meta level, Maniphest isn't well-suited to be an entry-form to be filled by a non-expert user; Nuance is/was intended for this use-case.

May 12 2024, 14:05 · Herald, Maniphest, User-valerio.bozzolan
avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

on the technical level, Herald can't block object creation - it runs after the fact, by the Daemons.

May 12 2024, 14:03 · Herald, Maniphest, User-valerio.bozzolan
avivey added a comment to D25636: Fix exception awarding empty badge to user.

I think the 404 is possibly better then "silently fail without error".

May 12 2024, 09:09
avivey added a comment to D25635: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.

How can we end up with null here?

May 12 2024, 07:20

May 11 2024

avivey accepted D25634: Remove deprecated buildStandardPage* method calls.
May 11 2024, 14:48
avivey updated the diff for D25549: Add Standard Custom Fields to Item List.

Rebase

May 11 2024, 10:48
avivey closed T15133: Differential List View should show Repository as Resolved by committing rPea554af47649: Add (Advanced) Custom Fields to Item List.
May 11 2024, 10:25 · Differential
avivey closed D25548: Add (Advanced) Custom Fields to Item List.
May 11 2024, 10:25
avivey committed rPea554af47649: Add (Advanced) Custom Fields to Item List.
Add (Advanced) Custom Fields to Item List
May 11 2024, 10:25
avivey edited the content of Change Log.
May 11 2024, 04:39
avivey attached a referenced file: F1360344: image.png.
May 11 2024, 04:38
avivey attached a referenced file: F1368592: image.png.
May 11 2024, 04:37
avivey renamed 2024 week 19 from Next Up to 2024 week 19.
May 11 2024, 04:37

May 9 2024

avivey edited the content of Next Up.
May 9 2024, 06:16

May 8 2024

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

May 8 2024, 08:25 · Discussion Needed, Arcanist
avivey added a member for Trusted Contributors: pppery.
May 8 2024, 07:29
avivey accepted D25624: Make i18n string extraction ignore strings in test case files.

(run the full tests, and then count it as my + O1 Accept).

May 8 2024, 07:29
avivey added a comment to T15815: Make i18n string extraction ignore strings in test cases.

I think the costs of the extra translations are low, but the cost of "the tests are not being translated for developers" are even lower.

May 8 2024, 07:26 · Localization
avivey added a comment to D25624: Make i18n string extraction ignore strings in test case files.

I'd be worried that this might break some tests that do relate to translation/extraction, but running arc unit --everything should solve that.

May 8 2024, 07:19

May 5 2024

avivey accepted D25608: Facts: Fix displaying charts for anonymous users.

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

May 5 2024, 14:02

Apr 29 2024

avivey added a comment to T15780: Expose only canonical Clone URI in Diffusion when repo hosted externally and Differential uninstalled.

You can set "visibility" for each URI already.

Apr 29 2024, 07:19

Apr 28 2024

avivey closed D25603: arc liberate.
Apr 28 2024, 16:54
avivey committed rPf75c7ce7664b: arc liberate.
arc liberate
Apr 28 2024, 16:54
avivey added Q134: [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864 (Answer 167).
Apr 28 2024, 15:49
avivey updated the summary of D25603: arc liberate.
Apr 28 2024, 15:48
avivey requested review of D25603: arc liberate.
Apr 28 2024, 15:48
avivey added a comment to T15801: Mention on landing page that Phorge is a community fork of Phabricator.

Yeah, thad makes sense, I guess.

Apr 28 2024, 14:05 · Phorge
avivey removed a project from Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?: Phorge.
Apr 28 2024, 14:02
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

I see "Unknown object" if the Diff repository is unset. Is that known?

Apr 28 2024, 13:13
avivey updated the diff for D25548: Add (Advanced) Custom Fields to Item List.
  • check for non-null repository in Revision
  • rebase
Apr 28 2024, 13:13

Apr 27 2024

avivey accepted D25475: Drag & Drop Task Cover Image: also attach.

Pending that small inline, lgtm.

Apr 27 2024, 07:00
avivey accepted D25256: T15064: PHP8 related corrections.

lgtm

Apr 27 2024, 06:43

Apr 26 2024

avivey closed T15731: Editing Ponder Comments is broken as Resolved.

Can't reproduce either - 🤷🏻‍♂️

Apr 26 2024, 06:38 · Ponder, Bug Reports

Apr 25 2024

avivey added a comment to Q131: Why is the Ponder project archived? (Answer 162).

Done - #ponder now refers to the new (active) tag.

Apr 25 2024, 06:45
avivey created Ponder.
Apr 25 2024, 06:45
avivey set the color for Ponder (archived) to Red.
Apr 25 2024, 06:45
avivey renamed Ponder (archived) from Ponder to Ponder (archived).
Apr 25 2024, 06:45

Apr 24 2024

avivey added a comment to Q128: How deeply is Ponder integrated with the rest of Phorge? (Answer 161).

I thought we had a ticket for "allow more things to show up in workboards", but I can't find it.

Apr 24 2024, 06:27
avivey moved T15210: Personal Workboards from Backlog to Features on the Workboard board.
Apr 24 2024, 06:25 · User-valerio.bozzolan, Workboard
avivey moved T15231: Maybe make automatic workboard display sub-projects as columns? from Backlog to Discussion Needed on the Workboard board.
Apr 24 2024, 06:25 · Discussion Needed, Workboard
avivey added Q131: Why is the Ponder project archived? (Answer 162).
Apr 24 2024, 06:22

Apr 16 2024

avivey retitled D25577: Makes extension usable with configured alternative file domain from [WIP] Makes extension usable with configured alternative file domain
Apr 16 2024, 06:28 · Diagrams (Extension)

Apr 15 2024

avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

done...

Apr 15 2024, 16:36 · Auth, Bug Reports
avivey committed rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing… (authored by doommius).
(stable) Fix config transaction rendering error on auth page by allowing…
Apr 15 2024, 16:36
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Yeah, probably. I'll try to do it tonight.

Apr 15 2024, 08:31 · Auth, Bug Reports

Apr 14 2024

avivey added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Maybe put the warning above the box, so it catches all actions, not just comments?

Apr 14 2024, 08:22 · Feature Requests
avivey added a comment to D25576: Improve PHPDoc of id().

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

Apr 14 2024, 07:01

Apr 12 2024

avivey closed D25575: Make sure `offset` is an integer.
Apr 12 2024, 16:28
avivey committed rP0d9ca2589f7c: Make sure `offset` is an integer.
Make sure `offset` is an integer
Apr 12 2024, 16:28
avivey added a comment to D25575: Make sure `offset` is an integer.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

Apr 12 2024, 13:47
avivey added a comment to Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).

I've created D25575 for this case, and filed T15783 for the broader issue.

Apr 12 2024, 08:33
avivey requested review of D25575: Make sure `offset` is an integer.
Apr 12 2024, 08:32
avivey triaged T15783: Conduit doesn't validate missing params as Normal priority.
Apr 12 2024, 08:20 · Conduit

Apr 11 2024

avivey raised the priority of T15106: "Upload file" in remarkup text fields should attach by default from Normal to High.
Apr 11 2024, 10:41 · Files, Remarkup

Apr 10 2024

avivey closed T15773: Community Project: Gantt Diagrams as Resolved.

Done:

Apr 10 2024, 04:52 · Phactory: Community Projects
avivey removed a hashtag from Gantt Charts (Extension): #gantt_diagrams_extension.
Apr 10 2024, 04:50
avivey renamed Gantt Charts (Extension) from Gantt Diagrams (Extension) to Gantt Charts (Extension).
Apr 10 2024, 04:50
avivey edited Description on Gantt Charts (Extension).
Apr 10 2024, 04:47
avivey created Gantt Charts (Extension).
Apr 10 2024, 04:46
avivey claimed T15773: Community Project: Gantt Diagrams.
Apr 10 2024, 04:45 · Phactory: Community Projects

Apr 9 2024

avivey added Q125: "Not In" query operator and searching for project milestones (Answer 157).
Apr 9 2024, 12:33

Apr 5 2024

avivey placed T15030: Support a Phorge Extensions ecosystem up for grabs.

Did that Phactory: Hosting Projects Here

Apr 5 2024, 16:36 · Extension Development, Phactory: Community Projects, Phorge
avivey created an object: Phactory: Hosting Projects Here.
Apr 5 2024, 16:34 · Phactory: Community Projects
avivey closed T15760: Community Repo: DeepClone as Resolved.
Apr 5 2024, 16:20 · Phactory: Community Projects
avivey closed D25570: Show rest of task page when graph errors out.
Apr 5 2024, 10:26
avivey committed rPecbef3fdf4b6: Show rest of task page when graph errors out.
Show rest of task page when graph errors out
Apr 5 2024, 10:26
avivey added a comment to T15772: Task with graph issue won't show.

This script can be used to download the entire graph:

Apr 5 2024, 10:05 · Maniphest
avivey requested review of D25570: Show rest of task page when graph errors out.
Apr 5 2024, 07:33
avivey triaged T15772: Task with graph issue won't show as Normal priority.
Apr 5 2024, 07:28 · Maniphest
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Apr 5 2024, 07:15
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Doesn't actually work for me either after arc patch:

image.png (317×429 px, 19 KB)

Apr 5 2024, 06:58