two items re: phrasing, but otherwise LGTM.

I've set can create to Trusted Contributors for now. I don't see a problem with people being able to create documents.

If the goal is to make it denote "inserted text", I think it should be visually different to "underline" - something more similar to the green we use for actual diff views, maybe more subtle. Will need special handling in the color-blindness themes.

The "Grant permission" button works for me on Chrome/Windows.

I think that for the "the name I use is not my legal name" use-case, I'm pretty sure it's fine to use the name that is actually used (because that's what the person is normally known as). It's probably easier to justify accepting a name that is used in real life then "internet handle", but ㄟ( ▔, ▔ )ㄏ

In T15121#20192, @BlankEclair wrote:

Would the CLA have to be signed with one's legal name?

(we can probably keep this ticket open, so that we have the 2nd part on the backlog. I'm pretty sure we want it to happen "eventually".)

Sounds reasonable.

"Steal credit" might actually lead to a real issue: If a new user can get themselves identified as an old, trusted, user based on commit history, their changes might not be checked as rigorously by the rest of the team - similar to the XZ Utils backdoor issue, only faster.

Please "remind" me about this ticket as often as possible, so I will fix it. I have everything I need to actually fix this, except the willpower.

@3tayesh Please don't do that again.

Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

Ah, the mythical Platypus Ornithopter!

(The Arguments have a supports feature for these cases - like https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 . Not sure what it actually does, but 🤷🏻‍♂️)

If it's the daemons that are having problems, you can probably see in the /daemons/ dashboard which tasks are causing problems, and narrow it down from there.

Repository update is based on how recent the last commit is, but that's only for collecting the list of commits to analyze.
But that should be done in the Daemons, which should at least recover nicely and not break the web side of the application. I don't know if they should be running as php or php-fpm.

Maybe express it as allowed by Policy xxx? (Related to T15277)

it might be in the APCu cache (https://we.phorge.it/config/cache/) - I'll try to check later. Also make sure you've set the Developer Mode in settings.

Ok, so --branch probably doesn't make much sense in that case, right.

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

Also related: T15025

I've filed T15908 for the "quick create from column to do what I mean".

(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)

It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.

It's not "impossible" on the technical level, it's just not obviously the right solution.

...set it by default to the space that the project belongs to...

In T15903#18780, @pppery wrote:

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time.

I did some digging:

This entire method looks very hacky to me. I guess at the bottom of every useful UI, there's a bunch of if statements that map icon names to code.

BTW - is something normalizing the header casing?

In T15750#18669, @CryingWolf wrote:

Is this feature meant to include displaying custom project fields in search results as well? (and possibly for other applications that allow custom field definitions)

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

You didn't have Trusted Contributors membership, which provides access to the repo. Try now

👍👍

I think we're all aligned here...

The best way is probably to make an Extension:

• How to Write Extensions
• Phactory: Hosting Projects Here
• T15030: Support a Phorge Extensions ecosystem

these pages should have Macro disabled, probably. A user on the install can add more macros that would break the page in some other ways. Probably.

Once we remove this, we'll need to handle this edge-case:

• I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).

In D25709#19636, @valerio.bozzolan wrote:

OK.

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

(BTW, in D25698 we started deprecating remarkup.diviner for RemarkupReferenceController)

what will this do?

I'm assuming you're talking about dropping a file in the text area when editing the page, right? Not just dropping it when viewing a wiki page?

Presumably resolved by D25134.