Page MenuHomePhorge

Co-Author support in arc land T15044
Needs RevisionPublic

Authored by TitanNano on Dec 1 2021, 10:55.
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:27
Unknown Object (File)
Wed, Apr 10, 22:36
Unknown Object (File)
Tue, Apr 9, 19:58
Unknown Object (File)
Tue, Apr 9, 19:58
Unknown Object (File)
Mon, Apr 8, 23:24
Unknown Object (File)
Mon, Apr 8, 23:17
Unknown Object (File)
Mon, Apr 8, 09:54
Unknown Object (File)
Sun, Apr 7, 10:40


Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15044: Co-Author support in arc land

This adds all additional commit authors to the differential commit message as co-authors.
I'm not yet done with this, but it's a first draft. I would like to also extend commit parsing so we store,
co-author lines from the original commits. Once we have that we can add them as well.

See also D25029.

Test Plan
  1. go to
  2. find a revision id that contains commits from authors which are not the revision author
  3. make a request to differential.getcommitmessage
  4. verify that additional authors are added as Co-authored-by: xx xx <>

Diff Detail

rP Phorge
Lint Passed
Tests Skipped
Build Status
Buildable 59
Build 59: arc lint + arc unit

Event Timeline

TitanNano held this revision as a draft.

include co-author data from local commits

TitanNano published this revision for review.Dec 3 2021, 09:00
avivey added inline comments.

Can we have the Co-authored-by title as the label for the field, and let this field go through the regular code-path her (the else)?

I'd like to avoid special cases as much as possible, to allow more extensions - ideally, I want installs to be able to add other footers based on the same logic as custom extensions.

That probably means we need to allow (1) multiple instances of the same CommitMessageField and (2) make sure we somehow control the order of fields in $field_list (which we might already do? It looks like something is forcing title to be first).

Hi @TitanNano, thanks again. If you have 5 minutes, feel free to reply to avivey since I'm also interested

avivey requested changes to this revision.Sat, Mar 30, 12:28
avivey removed a project: Differential (archived).

Changing status for house-keeping.

This revision now requires changes to proceed.Sat, Mar 30, 12:28