Page MenuHomePhorge

[bug] Diffusion Commit History CommandException on git 2.42
OpenPublic

Asked by nicodoggie on Apr 3 2024, 08:54.

Details

Getting an error with this command throwing a CommandException when checking branch history on the URL source/<repo>/history/<branch>:

git log --skip '' --max-count 101 '--format=%H:%P' <commit hash> --

errors out with a CommandException: fatal: '': not an integer

reverted to an earlier version of the git binary (2.34 in our case) as a workaround

I suppose git log used to allow an empty string as input to the --skip flag, but recently made this more strict.

On phorge stable 2023.49

Answers

avivey
Updated 44 Days Ago

Thanks - looks like it did (mine still does at git version 2.42.0.111.gd814540bb7)

The real issue looks like there's no validation for missing params: offset is defined as required int, and it's not provided in this particular call:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php$27

New Answer