Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
ClosedPublic

Authored by aklapper on Mar 31 2024, 11:54.
Tags
None
Referenced Files
F3297761: D25564.1742989535.diff
Tue, Mar 25, 11:45
F3294994: D25564.1742948792.diff
Tue, Mar 25, 00:26
F3291724: D25564.1742880285.diff
Mon, Mar 24, 05:24
F3284509: D25564.1742777571.diff
Sun, Mar 23, 00:52
F3283819: D25564.1742760642.diff
Sat, Mar 22, 20:10
F3249413: D25564.1742286028.diff
Mon, Mar 17, 08:20
F3224518: D25564.1742053231.diff
Fri, Mar 14, 15:40
F3215754: D25564.1741660616.diff
Mon, Mar 10, 02:36

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan

See T15767

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable