Paths

Table of Contentst

Differential D25564

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
ClosedPublic
Actions

Authored by aklapper on Mar 31 2024, 11:54.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 26, 20:10

	Unknown Object (File)
	Fri, Apr 26, 20:10

	Unknown Object (File)
	Fri, Apr 26, 20:10

	Unknown Object (File)
	Thu, Apr 25, 23:01

	Unknown Object (File)
	Wed, Apr 17, 18:27

	Unknown Object (File)
	Wed, Apr 17, 07:13

	Unknown Object (File)
	Thu, Apr 11, 06:39

	Unknown Object (File)
	Thu, Apr 11, 06:08

View All 20 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15767: PHP 8.1 "strlen(null)" exception when received email lacks From header

Commits

rP186768ccfd88: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Mar 31 2024, 11:54

Owners added a reviewer: O1: Blessed Committers.Mar 31 2024, 11:54

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 31 2024, 11:54

aklapper requested review of this revision.Mar 31 2024, 11:54

Harbormaster completed remote builds in B1133: Diff 1797.Mar 31 2024, 11:54

avivey accepted this revision.Mar 31 2024, 12:17

This revision is now accepted and ready to land.Mar 31 2024, 12:17

Closed by commit rP186768ccfd88: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header. · Explain WhyMar 31 2024, 13:21

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP186768ccfd88: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

metamta/

storage/

PhabricatorMetaMTAReceivedMail.php

2 lines

O1: Blessed Committers

Diff 1799

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...