Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
ClosedPublic

Authored by aklapper on Mar 31 2024, 11:54.
Tags
None
Referenced Files
F3372098: D25564.1744248195.diff
Wed, Apr 9, 01:23
F3369371: D25564.1744214552.diff
Tue, Apr 8, 16:02
F3369059: D25564.1744212873.diff
Tue, Apr 8, 15:34
F3357499: D25564.1743913353.diff
Sat, Apr 5, 04:22
F3334468: D25564.1743549600.diff
Mon, Mar 31, 23:20
F3334052: D25564.1743544024.diff
Mon, Mar 31, 21:47
F3328930: D25564.1743465696.diff
Mon, Mar 31, 00:01
F3321934: D25564.1743363133.diff
Sat, Mar 29, 19:32

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan

See T15767

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable