Page MenuHomePhorge

Facts: Fix displaying charts for anonymous users
ClosedPublic

Authored by aklapper on Tue, Apr 30, 16:02.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 12:18
Unknown Object (File)
Fri, May 10, 13:39
Unknown Object (File)
Thu, May 9, 21:05
Unknown Object (File)
Wed, May 8, 16:24
Unknown Object (File)
Wed, May 8, 15:42
Unknown Object (File)
Tue, May 7, 09:20
Unknown Object (File)
Sun, May 5, 23:32
Unknown Object (File)
Sun, May 5, 23:32

Details

Summary

Charts in the Facts prototype application (e.g. as a Burndown chart on a project's Reports page) remained empty for users not logged in: payload response was a login dialog instead of actual data to render. Thus set shouldAllowPublic() (as for many other Controllers).

Closes T15436

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

This revision is now accepted and ready to land.Sun, May 5, 14:02

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

Right... PhabricatorFactController is abstract and the neighbor file fact/controller/PhabricatorFactHomeController.php has the same two lines. So I think we're fine.