Page MenuHomePhorge

Co-Author support in arc land T15044
Needs ReviewPublic

Authored by TitanNano on Dec 2 2021, 16:24.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 25, 16:06
Unknown Object (File)
Wed, Nov 23, 03:30
Unknown Object (File)
Sat, Nov 19, 09:14
Unknown Object (File)
Thu, Nov 17, 21:49
Unknown Object (File)
Thu, Nov 17, 13:32
Unknown Object (File)
Wed, Nov 16, 04:59
Unknown Object (File)
Wed, Nov 16, 00:31
Unknown Object (File)
Fri, Nov 11, 18:36

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15044: Co-Author support in arc land
Summary

We have to parse the commit messages and add all co-authors to the "local:commits"
diff property, so we can use it later during arc land.

See also D25028.

Test Plan
  1. create a commit with one or more "Co-authored-by" lines.
  2. arc diff the commit into a revision
  3. verify that the local:commits property contains a coAuthors array with all co-authors

Diff Detail

Repository
rARC Arcanist
Branch
issues/T15044
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 58
Build 58: arc lint + arc unit

Event Timeline

trim whitespace from name and email

avivey edited the summary of this revision. (Show Details)
avivey added a subscriber: avivey.
avivey added inline comments.
src/repository/api/ArcanistGitAPI.php
224

Looks like we already upload the entire commit message - can we do this logic in the server, avoiding adding this key to the API?