Page MenuHomePhorge
Create Task
Maniphest T15706

Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML.
Closed, ResolvedPublic
Actions

Description

When opening the config page for facebook and templating using the same form of oauth a InvalidArgumentExceptionis thrown.

A workaround can be done where the phutil_nonempty_string returns false or true within the get title call.

The html object being parsed contains the following string:

object that is causing exception.

[Thu Jan 11 14:31:13.478731 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352] arcanist(head=master, ref.master=6142fcd5264f), phorge(head=doommius/discord, ref.master=49c3fe619342, ref.doommius/discord=efcc595275e8)

Stack trace

[Thu Jan 11 14:31:13.478661 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352] [2024-01-11 15:31:13] EXCEPTION: (InvalidArgumentException) Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML. at [<arcanist>/src/utils/utils.php:2127]
[Thu Jan 11 14:31:13.478731 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352] arcanist(head=master, ref.master=6142fcd5264f), phorge(head=doommius/discord, ref.master=49c3fe619342, ref.doommius/discord=efcc595275e8)
[Thu Jan 11 14:31:13.478733 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #0 <#2> phutil_nonempty_string(PhutilSafeHTML) called at [<phorge>/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php:153]
[Thu Jan 11 14:31:13.478734 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #1 <#2> PhabricatorAuthProviderConfigTransaction::getTitle() called at [<phorge>/src/applications/transactions/view/PhabricatorApplicationTransactionView.php:448]
[Thu Jan 11 14:31:13.478735 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #2 <#2> PhabricatorApplicationTransactionView::renderEvent(PhabricatorAuthProviderConfigTransaction, array) called at [<phorge>/src/applications/transactions/view/PhabricatorApplicationTransactionView.php:182]
[Thu Jan 11 14:31:13.478736 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #3 <#2> PhabricatorApplicationTransactionView::buildEvents(boolean) called at [<phorge>/src/applications/transactions/view/PhabricatorApplicationTransactionView.php:230]
[Thu Jan 11 14:31:13.478737 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #4 <#2> PhabricatorApplicationTransactionView::buildPHUITimelineView() called at [<phorge>/src/applications/transactions/view/PhabricatorApplicationTransactionView.php:209]
[Thu Jan 11 14:31:13.478738 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #5 <#2> phutil_escape_html(PhabricatorApplicationTransactionView) called at [<phorge>/src/infrastructure/markup/render.php:139]
[Thu Jan 11 14:31:13.478739 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #6 <#2> phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
[Thu Jan 11 14:31:13.478740 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #7 <#2> phutil_tag(string, array, array) called at [<phorge>/src/view/phui/PHUITwoColumnView.php:203]
[Thu Jan 11 14:31:13.478741 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #8 <#2> PHUITwoColumnView::buildMainColumn() called at [<phorge>/src/view/phui/PHUITwoColumnView.php:121]
[Thu Jan 11 14:31:13.478742 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #9 <#2> PHUITwoColumnView::getTagContent() called at [<phorge>/src/view/AphrontTagView.php:161]
[Thu Jan 11 14:31:13.478743 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #10 <#2> AphrontTagView::render() called at [<phorge>/src/view/AphrontView.php:222]
[Thu Jan 11 14:31:13.478744 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #11 <#2> AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
[Thu Jan 11 14:31:13.478745 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #12 <#2> phutil_escape_html(PHUITwoColumnView) called at [<phorge>/src/infrastructure/markup/render.php:171]
[Thu Jan 11 14:31:13.478746 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #13 <#2> phutil_implode_html(string, array) called at [<phorge>/src/view/page/PhabricatorBarePageView.php:58]
[Thu Jan 11 14:31:13.478747 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #14 <#2> PhabricatorBarePageView::willRenderPage() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:217]
[Thu Jan 11 14:31:13.478750 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #15 <#2> PhabricatorStandardPageView::willRenderPage() called at [<phorge>/src/view/page/AphrontPageView.php:46]
[Thu Jan 11 14:31:13.478752 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #16 <#2> AphrontPageView::render() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:919]
[Thu Jan 11 14:31:13.478752 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #17 <#2> PhabricatorStandardPageView::produceAphrontResponse() called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:722]
[Thu Jan 11 14:31:13.478753 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #18 <#2> AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:299]
[Thu Jan 11 14:31:13.478754 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #19 phlog(InvalidArgumentException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
[Thu Jan 11 14:31:13.478755 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #20 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, InvalidArgumentException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
[Thu Jan 11 14:31:13.478756 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #21 AphrontApplicationConfiguration::handleThrowable(InvalidArgumentException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:337]
[Thu Jan 11 14:31:13.478757 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #22 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
[Thu Jan 11 14:31:13.478758 2024] [php:notice] [pid 169782] [client 192.168.1.173:42352]   #23 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:36]

Steps to reproduce:

  1. System config PHP version PHP 8.1.2-1ubuntu2.14 (cli) (built: Aug 18 2023 11:41:11) (NTS) Copyright (c) The PHP Group Zend Engine v4.1.2, Copyright (c) Zend Technologies with Zend OPcache v8.1.2-1ubuntu2.14, Copyright (c), by Zend Technologies Apache2 Server version: Apache/2.4.52 (Ubuntu) Server built: 2023-10-26T13:44:44 Ubuntu Distributor ID: Ubuntu Description: Ubuntu 22.04.3 LTS Release: 22.04 Codename: jammy
  2. Clone repo and setup Phorge with basic config Setup Oauth2 towards Facebook. go to view config. error should be here. Might also be reproducible with other auth implementations as well.

Revisions and Commits

rP Phorge
D25512rPd519f75dfdee (stable) Fix config transaction rendering error on auth page by allowing…
D25512rPb445e1d80df9 Fix config transaction rendering error on auth page by allowing PhutilSafeHTML

Related Objects

Event Timeline

doommius created this task.Jan 11 2024, 17:15
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptJan 11 2024, 17:15
doommius mentioned this in Z1: Phorge.Jan 11 2024, 17:16
doommius updated the task description. (Show Details)
doommius updated the task description. (Show Details)Jan 11 2024, 17:23
valerio.bozzolan awarded a token.Jan 12 2024, 08:53
valerio.bozzolan mentioned this in rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.Jan 12 2024, 08:56
valerio.bozzolan added a comment.Jan 12 2024, 08:58

Can you try changing this line in your local install?

https://we.phorge.it/source/phorge/browse/master/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php;8e09dbfee3436cfa77dd304d060b017cc9e399ea$153

Try adopting phutil_nonempty_stringlike() that also handles objects.

If it works, feel free to propose a patch. For example running ../arcanist/bin/arc diff

doommius added a revision: D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.Jan 12 2024, 11:35
valerio.bozzolan mentioned this in T15737: Include information for installing required PHP version in Diviner docs.Feb 12 2024, 10:46
sirocyl subscribed.Feb 12 2024, 10:50

Heck yeah, changing phutil_nonempty_string() to phutil_nonempty_stringlike() there fixed the issue I had mentioned in a comment in T15737: Include information for installing required PHP version in Diviner docs.

valerio.bozzolan closed this task as Resolved by committing rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.Feb 12 2024, 10:52
valerio.bozzolan claimed this task.
valerio.bozzolan added a commit: rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
revi subscribed.Sun, Apr 14, 12:24

Can this (I mean rPb445e1d80df9 )be backported into stable?

It's breaking all stable installs' ability to read the current auth settings of a provider (one workaround I've been using for 3 months is basically 'figure out the edit URL and go there, edit stuff, save, and then face the Exceptions while the change is applied'.) and I don't really like the idea of having a local patch (which causes a headache w/ updating) and going to master (that defeats the point of using stable...)

avivey added a comment.Mon, Apr 15, 08:31

Yeah, probably. I'll try to do it tonight.

Maybe it's time for a new stable anyway.

avivey added a commit: rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing….Mon, Apr 15, 16:36
avivey added a comment.Mon, Apr 15, 16:36

done...

valerio.bozzolan reassigned this task from valerio.bozzolan to avivey.Tue, Apr 30, 09:53

Thanks again :) Giving right credits

valerio.bozzolan mentioned this in 2023 week 49.Tue, Apr 30, 09:55
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0