Page MenuHomePhorge
Feed Advanced Search

May 8 2024

avivey added a comment to D25624: Make i18n string extraction ignore strings in test case files.

I'd be worried that this might break some tests that do relate to translation/extraction, but running arc unit --everything should solve that.

May 8 2024, 07:19

May 5 2024

avivey accepted D25608: Facts: Fix displaying charts for anonymous users.

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

May 5 2024, 14:02

Apr 29 2024

avivey added a comment to T15780: Expose only canonical Clone URI in Diffusion when repo hosted externally and Differential uninstalled.

You can set "visibility" for each URI already.

Apr 29 2024, 07:19

Apr 28 2024

avivey closed D25603: arc liberate.
Apr 28 2024, 16:54
avivey committed rPf75c7ce7664b: arc liberate.
arc liberate
Apr 28 2024, 16:54
avivey added Q134: [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864 (Answer 167).
Apr 28 2024, 15:49
avivey updated the summary of D25603: arc liberate.
Apr 28 2024, 15:48
avivey requested review of D25603: arc liberate.
Apr 28 2024, 15:48
avivey added a comment to T15801: Mention on landing page that Phorge is a community fork of Phabricator.

Yeah, thad makes sense, I guess.

Apr 28 2024, 14:05 · Phorge
avivey removed a project from Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?: Phorge.
Apr 28 2024, 14:02
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

I see "Unknown object" if the Diff repository is unset. Is that known?

Apr 28 2024, 13:13
avivey updated the diff for D25548: Add (Advanced) Custom Fields to Item List.
  • check for non-null repository in Revision
  • rebase
Apr 28 2024, 13:13

Apr 27 2024

avivey accepted D25475: Drag & Drop Task Cover Image: also attach.

Pending that small inline, lgtm.

Apr 27 2024, 07:00
avivey accepted D25256: T15064: PHP8 related corrections.

lgtm

Apr 27 2024, 06:43

Apr 26 2024

avivey closed T15731: Editing Ponder Comments is broken as Resolved.

Can't reproduce either - 🤷🏻‍♂️

Apr 26 2024, 06:38 · Ponder, Bug Reports

Apr 25 2024

avivey added a comment to Q131: Why is the Ponder project archived? (Answer 162).

Done - #ponder now refers to the new (active) tag.

Apr 25 2024, 06:45
avivey created Ponder.
Apr 25 2024, 06:45
avivey set the color for Ponder (archived) to Red.
Apr 25 2024, 06:45
avivey renamed Ponder (archived) from Ponder to Ponder (archived).
Apr 25 2024, 06:45

Apr 24 2024

avivey added a comment to Q128: How deeply is Ponder integrated with the rest of Phorge? (Answer 161).

I thought we had a ticket for "allow more things to show up in workboards", but I can't find it.

Apr 24 2024, 06:27
avivey moved T15210: Personal Workboards from Backlog to Features on the Workboard board.
Apr 24 2024, 06:25 · User-valerio.bozzolan, Workboard
avivey moved T15231: Maybe make automatic workboard display sub-projects as columns? from Backlog to Discussion Needed on the Workboard board.
Apr 24 2024, 06:25 · Discussion Needed, Workboard
avivey added Q131: Why is the Ponder project archived? (Answer 162).
Apr 24 2024, 06:22

Apr 16 2024

avivey retitled D25577: Makes extension usable with configured alternative file domain from [WIP] Makes extension usable with configured alternative file domain
Apr 16 2024, 06:28 · Diagrams (Extension)

Apr 15 2024

avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

done...

Apr 15 2024, 16:36 · Auth, Bug Reports
avivey committed rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing… (authored by doommius).
(stable) Fix config transaction rendering error on auth page by allowing…
Apr 15 2024, 16:36
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Yeah, probably. I'll try to do it tonight.

Apr 15 2024, 08:31 · Auth, Bug Reports

Apr 14 2024

avivey added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Maybe put the warning above the box, so it catches all actions, not just comments?

Apr 14 2024, 08:22 · Feature Requests
avivey added a comment to D25576: Improve PHPDoc of id().

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

Apr 14 2024, 07:01

Apr 12 2024

avivey closed D25575: Make sure `offset` is an integer.
Apr 12 2024, 16:28
avivey committed rP0d9ca2589f7c: Make sure `offset` is an integer.
Make sure `offset` is an integer
Apr 12 2024, 16:28
avivey added a comment to D25575: Make sure `offset` is an integer.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

Apr 12 2024, 13:47
avivey added a comment to Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).

I've created D25575 for this case, and filed T15783 for the broader issue.

Apr 12 2024, 08:33
avivey requested review of D25575: Make sure `offset` is an integer.
Apr 12 2024, 08:32
avivey triaged T15783: Conduit doesn't validate missing params as Normal priority.
Apr 12 2024, 08:20 · Conduit

Apr 11 2024

avivey raised the priority of T15106: "Upload file" in remarkup text fields should attach by default from Normal to High.
Apr 11 2024, 10:41 · Files, Remarkup

Apr 10 2024

avivey closed T15773: Community Project: Gantt Diagrams as Resolved.

Done:

Apr 10 2024, 04:52 · Phactory: Community Projects
avivey removed a hashtag from Gantt Charts (Extension): #gantt_diagrams_extension.
Apr 10 2024, 04:50
avivey renamed Gantt Charts (Extension) from Gantt Diagrams (Extension) to Gantt Charts (Extension).
Apr 10 2024, 04:50
avivey edited Description on Gantt Charts (Extension).
Apr 10 2024, 04:47
avivey created Gantt Charts (Extension).
Apr 10 2024, 04:46
avivey claimed T15773: Community Project: Gantt Diagrams.
Apr 10 2024, 04:45 · Phactory: Community Projects

Apr 9 2024

avivey added Q125: "Not In" query operator and searching for project milestones (Answer 157).
Apr 9 2024, 12:33

Apr 5 2024

avivey placed T15030: Support a Phorge Extensions ecosystem up for grabs.

Did that Phactory: Hosting Projects Here

Apr 5 2024, 16:36 · Extension Development, Phactory: Community Projects, Phorge
avivey created an object: Phactory: Hosting Projects Here.
Apr 5 2024, 16:34 · Phactory: Community Projects
avivey closed T15760: Community Repo: DeepClone as Resolved.
Apr 5 2024, 16:20 · Phactory: Community Projects
avivey closed D25570: Show rest of task page when graph errors out.
Apr 5 2024, 10:26
avivey committed rPecbef3fdf4b6: Show rest of task page when graph errors out.
Show rest of task page when graph errors out
Apr 5 2024, 10:26
avivey added a comment to T15772: Task with graph issue won't show.

This script can be used to download the entire graph:

Apr 5 2024, 10:05 · Maniphest
avivey requested review of D25570: Show rest of task page when graph errors out.
Apr 5 2024, 07:33
avivey triaged T15772: Task with graph issue won't show as Normal priority.
Apr 5 2024, 07:28 · Maniphest
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Apr 5 2024, 07:15
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Doesn't actually work for me either after arc patch:

image.png (317×429 px, 19 KB)

Apr 5 2024, 06:58

Apr 4 2024

avivey added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

  • Don't exist in Diffusion
  • Do exist in Paste
  • Don't exist in Differential
Apr 4 2024, 21:34 · Discussion Needed
avivey added a comment to V5: Should we remove the code-generated documents from this instance?.

There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.

Apr 4 2024, 18:47 · Diviner
avivey accepted D25558: Initial work.

You should be able to just arc land this now...

Apr 4 2024, 08:00 · DeepClone (Extension)
avivey added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Apr 4 2024, 07:10 · Discussion Needed

Apr 3 2024

avivey added a comment to Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).

As a work-around, you can probably add ?offset=0 to the URL.

Apr 3 2024, 11:09
avivey added Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).
Apr 3 2024, 11:07
avivey awarded Q124: [bug] Diffusion Commit History CommandException on git 2.42 a Yellow Medal token.
Apr 3 2024, 10:59 · Diffusion
avivey added a comment to D25558: Initial work.

(The images aren't public/attached, so I can't see them)

Apr 3 2024, 10:56 · DeepClone (Extension)
avivey created V5: Should we remove the code-generated documents from this instance?.
Apr 3 2024, 07:04 · Diviner
avivey added a comment to D25475: Drag & Drop Task Cover Image: also attach.

All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷‍♂️

Apr 3 2024, 06:51
avivey added a comment to T15768: Better tracking tools for Files.

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

Apr 3 2024, 06:41 · Files
avivey added a comment to D25568: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated text.

In this way, do we skip that column creating a column shift?

Apr 3 2024, 05:40

Apr 2 2024

avivey added a comment to D25566: Fix setup check for gzip request mangling being sent as GET.

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Apr 2 2024, 18:34
avivey added a member for Trusted Contributors: kat.
Apr 2 2024, 18:33
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

Apr 2 2024, 18:28
avivey accepted D25538: Separate repository home and browse view in tab menu.
Apr 2 2024, 13:18
avivey added a comment to Q108: Phorge and Mermaid Js (Answer 139).

The Github syntax for this is bad. That's the code block syntax. It makes it impossible to have code-block with mermaid syntax.

Apr 2 2024, 09:10
avivey accepted D25566: Fix setup check for gzip request mangling being sent as GET.
Apr 2 2024, 07:44
avivey added Q123: [Feature] Phorge integrates with Keycloak (Answer 155).
Apr 2 2024, 06:25

Apr 1 2024

avivey accepted D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

looks good to me - couple of small inlines....

Apr 1 2024, 19:41
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)

Apr 1 2024, 19:30

Mar 31 2024

avivey created T15768: Better tracking tools for Files.
Mar 31 2024, 20:43 · Files
avivey accepted D25564: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header.
Mar 31 2024, 12:17
avivey accepted D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

:-)

Mar 31 2024, 12:17
avivey added a comment to D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

Is that really as trivial as in my last revision?

Mar 31 2024, 08:46

Mar 30 2024

avivey requested changes to D25029: Co-Author support in arc land T15044.

house-keeping...

Mar 30 2024, 12:28
avivey requested changes to D25028: Co-Author support in arc land T15044.

Changing status for house-keeping.

Mar 30 2024, 12:28
avivey accepted D25538: Separate repository home and browse view in tab menu.

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Mar 30 2024, 12:25

Mar 29 2024

avivey added a comment to D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

Can we just define the used properties instead? Doesn't look like there's too many of them.

Mar 29 2024, 12:07
avivey added a comment to D25558: Initial work.

IIRC, The save() command won't generate any Feed item, so the unified feed entry would be either "xxx triaged this task" or "xxx added a comment". Also, for each comment added, a new Feed item will be generated, which is probably not what you'd like.

Mar 29 2024, 09:27 · DeepClone (Extension)

Mar 26 2024

avivey closed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as Resolved by committing rP216d308507ed: Fix Project Hovercard rendering @mention.
Mar 26 2024, 18:07 · Affects-Wikimedia, Bug Reports
avivey closed D25562: Fix Project Hovercard rendering @mention.
Mar 26 2024, 18:07
avivey committed rP216d308507ed: Fix Project Hovercard rendering @mention.
Fix Project Hovercard rendering @mention
Mar 26 2024, 18:07
avivey requested review of D25562: Fix Project Hovercard rendering @mention.
Mar 26 2024, 15:40
avivey added a revision to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description: D25562: Fix Project Hovercard rendering @mention.
Mar 26 2024, 15:40 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

Mar 26 2024, 10:46 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

So this is quite an edge-case:

  • PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
  • There's an automatic rule, saying a member of a project can always view the project
  • When loading the project for the hovercard, we don't bother loading all the member list
  • When loading the user for the mention, we don't bother loading all its projects
  • so data is not available at the rendering point.
Mar 26 2024, 10:39 · Affects-Wikimedia, Bug Reports
avivey claimed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 26 2024, 10:23 · Affects-Wikimedia, Bug Reports
avivey accepted D25560: Remarkup code blocks: guess language from "name=".
Mar 26 2024, 10:19

Mar 25 2024

avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't immediately reproduce with that version either. I'll try again later.
In the meanwhile:

  • Try clearing your browser's cache
  • Try updating Phorge to the latest commit
  • Try disabling this extension: assets/DisableUsernameEditEventListener.php
Mar 25 2024, 08:41 · Bug Reports
avivey added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

I can reproduce this on master with basically any string search.

Mar 25 2024, 08:30 · Phorge, Bug Reports
avivey accepted D25559: Update unit test of InterpreterBlockRule for "a {{{a}}}".
Mar 25 2024, 08:27
avivey added inline comments to D25560: Remarkup code blocks: guess language from "name=".
Mar 25 2024, 07:54
avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't reproduce this.
Which version of phorge/arc do you have (git log -1)?
How did you install the new Instance?

Mar 25 2024, 07:44 · Bug Reports

Mar 22 2024

avivey added Q120: What is the intended effect on a revision if the plan 1 fails? (Answer 152).
Mar 22 2024, 12:11

Mar 20 2024

avivey moved T15525: Create repository for Diagrams, a DrawIO integration from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 12:08 · Phactory: Community Projects
avivey moved T15558: community repo: Semi Structured from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 12:08 · Semi Structured (Extension), Phactory: Community Projects