Please update the diff.

Probably fine. Most of these probably should be Strings anyway, but some can be integers in SVN or some other strange cases. Maybe we'll get xphast to tell us more about types, like the common Python tools.

You need to run bin/celerity map after changing a css file.

In T15448#9857, @avivey wrote:

In any case, it should be generic - on "search results page", although probably requires each SearchEngine to define the available fields in order to actually support this feature.

See https://we.phorge.it/T15533#11839 - the env-selecting code in ExecFuture has this logic:

• the setlocal isn't supposed to make a difference (it only applies the command string itself - ie if a file is named 🧆.txt.
• Setting E is more likely to cause this problem then to solve it...

I think these two are related here:

• https://secure.phabricator.com/T13060 (call setlocal in the master php process, so everything is always en_us)
• T15281 and https://secure.phabricator.com/T12071 (Env-vars are missing because of E)

(I'm able to reproduce. Had to apt-get install language-pack-hu for that...)

Yeah, that's what I was worried about

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

Most of these look good, but I think some of it is outdated - can you check which is still needed?

lint + php 8 fix

Is there anything that generates this URL? Is there a broken link generated anywhere?

Hashtags are not "aliases" - they are single words with # added at the start, that are references to a topic (project).

"Do nothing" does nothing. It's mostly for working with the "Other Herald Rule" conditions.

• coalesce

use ===

yeah, typo. I'll fix it again...

ok, now I understand.

I suspect just listing all open revisions would make using this page even worse - users will have to wade through a giant list.

consider just replacing the selector with a modern AphrontFormTokenizerControl - that smart search features.

I've extracted T15535: Using Differential with plain Git, without requiring Arc for the git-push-for-revision.

If it's urgent, we can apply a strict CLA now (basically copy Phacility), and soften it later, once we've had legal counsel.

yeah, well, we still can't afford legal advice. If some funded organization is willing to donate some, we'll appreciate it.

@valerio.bozzolan I think you're confusing this task ("website content") and T15121 (contributor agreement).

Where exactly are you seeing this error? what page exactly?

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan), and it technically can't delete the branch (it can prevent it from being created, but that shows up as an error in the user-side).
But it should be able to at least trigger the flow and provide a URL for the user to click on.

Ok, the discussion here got a little out of focus. Maybe some parts of this can be extracted to their own discussion.

Currently, only Commits show anything like "description" (commit hovercard shows the commit message.

In D25296#9658, @valerio.bozzolan wrote:

Hi @avivey what do you think about this legacy possible situation?

$ ./bin/repository maintenance --stop --start "" R9
Took repository "R9" out of maintenance mode.

Maybe this Diff is a good moment to introduce a fix also to that, with a dedicated message

I like changes that have unit tests.

I think this is a Good Starter Task...

(I think I'm still interested in continuing some of this discussion, but I'm far behind on reading it already. I might resurrect [parts of] it later...)

In T15525#11410, @valerio.bozzolan wrote:

I would like to mention #diagrams_extension in the Repository description, but I do not have enough permissions.

And you can manage Diagrams (Extension), which has access to manage the repo.

We don't really have a concrete flow setup.
I'll file a task and have you fill some details...

I think the current actionable steps we can take are:

Also, I don't know for sure, but I don't believe the technical issues had a serious effect on Phacility's shutdown - I believe it was the business of trying to compete with GitHub in the low end, and with Phabricator on the high-end - Phabricator/Phorge is at its best when it's being managed in-house, with customizations for integration with the rest of the business tools. Using it as a sealed product is missing half the fun.