Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F2916144: D25306.1737471113.diff
Mon, Jan 20, 14:51
F2916111: D25306.1737471101.diff
Mon, Jan 20, 14:51
F2905185: D25306.1737339106.diff
Sun, Jan 19, 02:11
F2877750: D25306.1737007136.diff
Wed, Jan 15, 05:58
F2871476: D25306.1736856624.diff
Mon, Jan 13, 12:10
F2869791: D25306.1736731151.diff
Sun, Jan 12, 01:19
F2865727: D25306.1736610369.diff
Fri, Jan 10, 15:46
F313281: AFTER.png
Jun 22 2023, 14:28

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable