Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F3976334: D25306.1746536437.diff
Mon, May 5, 13:00
F3946022: D25306.1746446085.diff
Sun, May 4, 11:54
F3912382: D25306.1746344291.diff
Sat, May 3, 07:38
F3904317: D25306.1746297561.diff
Fri, May 2, 18:39
F3850705: D25306.1746115728.diff
Wed, Apr 30, 16:08
F3824142: D25306.1746025834.diff
Tue, Apr 29, 15:10
F3763626: D25306.1745839406.diff
Sun, Apr 27, 11:23
F3658968: D25306.1745457164.diff
Wed, Apr 23, 01:12

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable