Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F3290130: D25306.1742859224.diff
Sun, Mar 23, 23:33
F3284654: D25306.1742781863.diff
Sun, Mar 23, 02:04
F3247094: D25306.1742218698.diff
Sun, Mar 16, 13:38
F3221541: D25306.1741860268.diff
Wed, Mar 12, 10:04
F3221197: D25306.1741814040.diff
Tue, Mar 11, 21:14
F3221196: D25306.1741814037.diff
Tue, Mar 11, 21:13
F3221195: D25306.1741814033.diff
Tue, Mar 11, 21:13
F3151875: D25306.1741226891.diff
Wed, Mar 5, 02:08

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable