Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F3383869: D25306.1744394761.diff
Thu, Apr 10, 18:06
F3372496: D25306.1744250094.diff
Wed, Apr 9, 01:54
F3372260: D25306.1744249254.diff
Wed, Apr 9, 01:40
F3371840: D25306.1744246228.diff
Wed, Apr 9, 00:50
F3368821: D25306.1744211496.diff
Tue, Apr 8, 15:11
F3366922: D25306.1744189783.diff
Tue, Apr 8, 09:09
F3365241: D25306.1744171206.diff
Tue, Apr 8, 04:00
F3362667: D25306.1744091332.diff
Mon, Apr 7, 05:48

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable