Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F2174588: D25306.id1094.diff
Thu, May 2, 09:54
F2174587: D25306.id1001.diff
Thu, May 2, 09:54
F2174586: D25306.id.diff
Thu, May 2, 09:54
Unknown Object (File)
Tue, Apr 30, 21:38
Unknown Object (File)
Sat, Apr 13, 21:54
Unknown Object (File)
Sat, Apr 13, 21:48
Unknown Object (File)
Apr 1 2024, 02:10
Unknown Object (File)
Mar 31 2024, 03:10

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable