Differential D25345

PHP 8.1 strlen(null) errors
ClosedPublic
Actions

Authored by Sten on Jul 13 2023, 12:03.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15549: Dashboard Remove Panel fails with PHP 8.1 strlen(null)

Commits

rPf7dd8f579a36: Fix /dashboard/adjust/remove/ PHP 8.1 strlen(null) errors

Summary

/dashboard/adjust/remove/ POST requests fail under PHP 8.1 with strlen(null) errors.

This change fixes it.

Fixes T15549

Test Plan

View a dashboard which has some panels. Eg https://my.phorge.site/dashboard/view/1/
Click on a 'Manage Panel' dropdown and click on 'Remove Panel'

Confirm the panel is removed and no strlen(null) errors are generated.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jul 13 2023, 12:03

Owners added a reviewer: O1: Blessed Committers.Jul 13 2023, 12:03

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 13 2023, 12:03

Sten requested review of this revision.Jul 13 2023, 12:03

Harbormaster completed remote builds in B666: Diff 1118.Jul 13 2023, 12:03

avivey accepted this revision.Jul 15 2023, 07:27

This revision is now accepted and ready to land.Jul 15 2023, 07:27

Closed by commit rPf7dd8f579a36: Fix /dashboard/adjust/remove/ PHP 8.1 strlen(null) errors. · Explain WhyJul 15 2023, 11:44

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rPf7dd8f579a36: Fix /dashboard/adjust/remove/ PHP 8.1 strlen(null) errors.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

dashboard/

controller/

dashboard/

PhabricatorDashboardAdjustController.php

4 lines

O1: Blessed Committers

Diff 1122

View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php

Fix /dashboard/adjust/remove/ PHP 8.1 strlen(null) errorsClosedPublicActions