Page MenuHomePhorge

Fix tab complete in php 8
ClosedPublic

Authored by avivey on Jul 15 2023, 19:23.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 21, 05:39
Unknown Object (File)
Tue, Sep 19, 10:06
Unknown Object (File)
Aug 19 2023, 17:39
Unknown Object (File)
Aug 17 2023, 03:33
Unknown Object (File)
Aug 12 2023, 16:26
Unknown Object (File)
Aug 10 2023, 04:25
Unknown Object (File)
Aug 7 2023, 16:48
Unknown Object (File)
Aug 7 2023, 14:23

Details

Summary

Ref T15064

Test Plan

run arc shell-complete; arc shell-complete arc shell; Should suggest completions, not crash.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Jul 15 2023, 19:23
src/toolset/workflow/ArcanistShellCompleteWorkflow.php
95

Finally we can remove the (bool)

avivey marked an inline comment as done.Jul 18 2023, 15:40
This revision is now accepted and ready to land.Jul 21 2023, 10:16
This revision was automatically updated to reflect the committed changes.