Page MenuHomePhorge

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()
ClosedPublic

Authored by Sten on Jul 7 2023, 14:36.
Tags
None
Referenced Files
F3852412: D25340.1746123819.diff
Wed, Apr 30, 18:23
F3801252: D25340.1745944788.diff
Mon, Apr 28, 16:39
F3766742: D25340.1745846553.diff
Sun, Apr 27, 13:22
F3754602: D25340.1745820282.diff
Sun, Apr 27, 06:04
F3709381: D25340.1745650354.diff
Fri, Apr 25, 06:52
F3645159: D25340.1745359070.diff
Mon, Apr 21, 21:57
F3502273: D25340.1744796351.diff
Tue, Apr 15, 09:39
F3389927: D25340.1744461489.diff
Fri, Apr 11, 12:38

Details

Summary

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Fixes T15542

Test Plan
  1. Go into a diff (eg https://my.phorge.site/D1234)
  2. Click on the Revision Contents - History tab
  3. Click on a base link (the short git revision ID)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Jul 7 2023, 14:36
src/applications/diffusion/view/DiffusionView.php
71

Can't default $display_name to '' due to the explicit null check on line 106.

This revision is now accepted and ready to land.Jul 11 2023, 08:19