Page MenuHomePhorge

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()
ClosedPublic

Authored by Sten on Jul 7 2023, 14:36.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 19:36
Unknown Object (File)
Wed, Jun 12, 16:27
Unknown Object (File)
Sun, Jun 9, 21:20
Unknown Object (File)
Tue, Jun 4, 16:19
Unknown Object (File)
Thu, May 30, 18:55
Unknown Object (File)
Thu, May 30, 01:19
Unknown Object (File)
Wed, May 29, 05:54
Unknown Object (File)
Wed, May 29, 01:16

Details

Summary

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Fixes T15542

Test Plan
  1. Go into a diff (eg https://my.phorge.site/D1234)
  2. Click on the Revision Contents - History tab
  3. Click on a base link (the short git revision ID)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Jul 7 2023, 14:36
src/applications/diffusion/view/DiffusionView.php
71

Can't default $display_name to '' due to the explicit null check on line 106.

This revision is now accepted and ready to land.Jul 11 2023, 08:19