This drives my colleagues crazy :D

Steps to reproduce:

1. Visit a Diff like D25328 and Update Patch
2. Paste a valid git diff and Continue

At this point you are on a similar URL:

https://we.phorge.it/differential/diff/9876/?revisionID=25328

But, you cannot select the Diff D25328:

It seems the selectbox is limited to your diffs, but, indeed the server allows you to do update Diff D25328 from command line, but also, from the web interface: if you hack with the HTML and you put D25328 in the <select> box, you successfully update the Diff, and that is good.

So this seems just an UX limitation.

In short, the selection box probably should include the specified ?revisionID=.

Background

The current behavior probably comes from an unrelated thing.

https://secure.phabricator.com/T7602

Also the "only current viewer limitation" seems originated from a copy-paste on a part that needed the author indeed.

https://secure.phabricator.com/D12167

Proposed change

Among your changes, pick also the Diff that is specified in the current URL, whenever the DIff is yours or not (as soon as you can view+edit it of course).

So probably the fix is to just omit this specific "only current viewer" limitation in this specific line:

https://we.phorge.it/source/phorge/browse/master/src/applications/differential/controller/DifferentialDiffViewController.php;7bebfa289aa18e3ff043ea3a5b00d178ec6756e1$200