Page MenuHomePhorge
Differential D25328

Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
ClosedPublic
Actions

Authored by Sten on Jul 4 2023, 14:19.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15521: Viewing a diff with code coverage for some but not all files fails with strlen(null) under PHP 8.1
Commits
rP8cbbc9f96107: Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
Summary

DifferentialChangesetViewController loadCoverage() fails under PHP 8.1 when test coverage is provided for some but not all modified files.

Update the code to replace strlen() with phutil_nonempty_string().

Fixes T15521

Test Plan

View a diff with test coverage for some but not all files.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
differential/
controller/
5 linesO1: Blessed Committers

Diff 1127

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0