Differential D25328

Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
ClosedPublic
Actions

Authored by Sten on Jul 4 2023, 14:19.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15521: Viewing a diff with code coverage for some but not all files fails with strlen(null) under PHP 8.1

Commits

rP8cbbc9f96107: Fix strlen(null) in DifferentialChangesetViewController loadCoverage()

Summary

DifferentialChangesetViewController loadCoverage() fails under PHP 8.1 when test coverage is provided for some but not all modified files.

Update the code to replace strlen() with phutil_nonempty_string().

Fixes T15521

Test Plan

View a diff with test coverage for some but not all files.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jul 4 2023, 14:19

Owners added a reviewer: O1: Blessed Committers.Jul 4 2023, 14:19

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 4 2023, 14:19

Sten requested review of this revision.Jul 4 2023, 14:19

Harbormaster completed remote builds in B632: Diff 1064.Jul 4 2023, 14:19

avivey accepted this revision.Jul 17 2023, 06:01

This revision is now accepted and ready to land.Jul 17 2023, 06:01

Closed by commit rP8cbbc9f96107: Fix strlen(null) in DifferentialChangesetViewController loadCoverage(). · Explain WhyJul 17 2023, 10:02

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP8cbbc9f96107: Fix strlen(null) in DifferentialChangesetViewController loadCoverage().

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

5 lines

O1: Blessed Committers

Diff 1127

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Fix strlen(null) in DifferentialChangesetViewController loadCoverage()ClosedPublicActions