Page MenuHomePhorge
Create Task
Maniphest T15276

changes to js files should always invoke PhabricatorCelerityTestCase
Open, HighPublic
Actions

Description

e.g. D25134, which didn't run the celerity tests.

Revisions and Commits

rP Phorge
D25136rP1e27a7b89944 Fix outdated Celerity

Related Objects

Event Timeline

avivey triaged this task as High priority.Apr 26 2023, 10:10
avivey created this task.
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptApr 26 2023, 10:10
valerio.bozzolan awarded a token.Apr 26 2023, 10:17
valerio.bozzolan subscribed.
valerio.bozzolan added a comment.Apr 26 2023, 10:20

I think the reason is, I touched this file:

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

But the test is in this file:

./src/__tests__/PhabricatorCelerityTestCase.php

I wonder, what could happen if we move that here:

./__tests__/PhabricatorCelerityTestCase.php
valerio.bozzolan added a revision: D25136: Fix outdated Celerity.Apr 26 2023, 10:24
valerio.bozzolan added a commit: rP1e27a7b89944: Fix outdated Celerity.Apr 26 2023, 10:26
avivey added a project: Phorge Development Tools.Jul 10 2023, 20:06
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0