Paths

Table of Contentst

Differential D25192

Ponder Answer Comments: indent textarea as Comments
ClosedPublic
Actions

Authored by valerio.bozzolan on May 4 2023, 21:34.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 06:09

	Unknown Object (File)
	Sat, Apr 13, 20:39

	Unknown Object (File)
	Sat, Apr 13, 20:33

	Unknown Object (File)
	Sat, Apr 13, 19:52

	Unknown Object (File)
	Sat, Apr 13, 19:45

	Unknown Object (File)
	Sat, Apr 13, 19:27

	Unknown Object (File)
	Sat, Apr 13, 18:33

	Unknown Object (File)
	Sat, Apr 13, 18:04

Subscribers

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15350: Ponder Answer: improve comment indentation

Commits

rP0dfc84e2abef: Ponder Answer Comments: indent textarea as Comments

Summary

In a Ponder Answer, when adding a Comment, the textarea indentation was a
a little bit unintuitive.

After this change, the textarea is aligned as a Comment:

Before	After

Other changes are welcome but this seems to me a good minimum.

I also hope this could help not to confuse the Comment field with the Answer field.

Closes T15350

Test Plan

create a Ponder Question
create an Answer
look at the Comments input field that now should be more nicely indented
the normal Response field is not changed at all
the mobile view is not changed at all
click on "Pin Form On Screen" and it must be as before

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.May 4 2023, 21:34

Owners added a reviewer: O1: Blessed Committers.May 4 2023, 21:34

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 4 2023, 21:34

valerio.bozzolan requested review of this revision.May 4 2023, 21:34

Harbormaster completed remote builds in B361: Diff 658.May 4 2023, 21:34

valerio.bozzolan added inline comments.May 4 2023, 21:37

webroot/rsrc/css/application/ponder/ponder-view.css
56	Note: I used the `.phui-box.phui-comment-form-view` selector instead of just `.phui-comment-form-view`, so that it's more specific, and it overrides the precedent value. This was my elegant workaround to avoid a CSS `!important` otherwise necessary.

valerio.bozzolan mentioned this in Z1: Phorge.May 9 2023, 16:53

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)May 9 2023, 16:56

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

avivey accepted this revision.Jul 17 2023, 06:48

This revision is now accepted and ready to land.Jul 17 2023, 06:48

valerio.bozzolan edited the test plan for this revision. (Show Details)Jul 18 2023, 11:20

Fix to pass the new test plan

Harbormaster completed remote builds in B679: Diff 1141.Jul 18 2023, 11:42

./bin/celerity map

Harbormaster completed remote builds in B680: Diff 1142.Jul 18 2023, 11:44

valerio.bozzolan added inline comments.Jul 18 2023, 11:46

webroot/rsrc/css/application/ponder/ponder-view.css
56	↑ My inline comment is not relevant anymore, since we have the `:not()` selector that is already incidentally more-precise. So there is no need to have `margin-left: 94px; !important`.

Closed by commit rP0dfc84e2abef: Ponder Answer Comments: indent textarea as Comments. · Explain WhyJul 19 2023, 19:28

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP0dfc84e2abef: Ponder Answer Comments: indent textarea as Comments.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

application/

ponder/

ponder-view.css

7 lines

O1: Blessed Committers

Diff 1145

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/ponder/ponder-view.css

Loading...