Page MenuHomePhorge

Ponder Answer Comments: indent textarea as Comments
Needs ReviewPublic

Authored by valerio.bozzolan on May 4 2023, 21:34.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 06:37
Unknown Object (File)
Wed, May 31, 06:37
Unknown Object (File)
Wed, May 24, 14:13
Unknown Object (File)
Thu, May 18, 12:38
Unknown Object (File)
Wed, May 17, 17:56
Unknown Object (File)
Sun, May 14, 17:40
Unknown Object (File)
Thu, May 11, 05:29
F286221: Ponder - After.png
May 4 2023, 21:34

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15350: Ponder Answer: improve comment indentation
Summary

In a Ponder Answer, when adding a Comment, the textarea indentation was a
a little bit unintuitive.

After this change, the textarea is aligned as a Comment:

BeforeAfter
Ponder - Before.png (694×626 px, 45 KB)
Ponder - After.png (694×626 px, 48 KB)

Other changes are welcome but this seems to me a good minimum.

I also hope this could help not to confuse the Comment field with the Answer field.

Closes T15350

Test Plan
  • create a Ponder Question
  • create an Answer
  • look at the Comments input field that now should be more nicely indented
  • the normal Response field is not changed at all
  • the mobile view is not changed at all

Diff Detail

Repository
rP Phorge
Branch
ponder-answer-indent
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 361
Build 361: arc lint + arc unit

Event Timeline

webroot/rsrc/css/application/ponder/ponder-view.css
56

Note: I used the .phui-box.phui-comment-form-view selector instead of just .phui-comment-form-view, so that it's more specific, and it overrides the precedent value.

This was my elegant workaround to avoid a CSS !important otherwise necessary.