Paths

Table of Contentst

Differential D25192

Ponder Answer Comments: indent textarea as Comments
Needs ReviewPublic
Actions

Authored by valerio.bozzolan on May 4 2023, 21:34.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 31, 06:37

	Unknown Object (File)
	Wed, May 31, 06:37

	Unknown Object (File)
	Wed, May 24, 14:13

	Unknown Object (File)
	Thu, May 18, 12:38

	Unknown Object (File)
	Wed, May 17, 17:56

	Unknown Object (File)
	Sun, May 14, 17:40

	Unknown Object (File)
	Thu, May 11, 05:29

	F286221: Ponder - After.png
	May 4 2023, 21:34

View All 9 Files

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15350: Ponder Answer: improve comment indentation

Summary

In a Ponder Answer, when adding a Comment, the textarea indentation was a
a little bit unintuitive.

After this change, the textarea is aligned as a Comment:

Before	After

Other changes are welcome but this seems to me a good minimum.

I also hope this could help not to confuse the Comment field with the Answer field.

Closes T15350

Test Plan

create a Ponder Question
create an Answer
look at the Comments input field that now should be more nicely indented
the normal Response field is not changed at all
the mobile view is not changed at all

Diff Detail

Repository

Branch

ponder-answer-indent

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 361
Build 361: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.May 4 2023, 21:34

Owners added a reviewer: O1: Blessed Committers.May 4 2023, 21:34

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 4 2023, 21:34

valerio.bozzolan requested review of this revision.May 4 2023, 21:34

Harbormaster completed remote builds in B361: Diff 658.May 4 2023, 21:34

valerio.bozzolan added inline comments.May 4 2023, 21:37

webroot/rsrc/css/application/ponder/ponder-view.css
56	Note: I used the `.phui-box.phui-comment-form-view` selector instead of just `.phui-comment-form-view`, so that it's more specific, and it overrides the precedent value. This was my elegant workaround to avoid a CSS `!important` otherwise necessary.

valerio.bozzolan mentioned this in Z1: Phorge.Tue, May 9, 16:53

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)Tue, May 9, 16:56

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.Thu, May 18, 10:16

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

application/

ponder/

ponder-view.css

6 lines

O1: Blessed Committers

Diff 658

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/ponder/ponder-view.css

Loading...