Page MenuHomePhorge
Create Task
Maniphest T15537

When creating revision from raw diff, "Repository" field is lost
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Differential homepage → Create Diff
  • fill all the fields also the Repository
  • Attach To → Create a new Revision

What happens:

The Repository input picker is empty.

What should happen instead:

The Repository input picker should be populated, keeping the thing I previously picked.

Revisions and Commits

rP Phorge
D25338rP0f07c07b3bc3 Attach Diff to Revision: fix Repository asked twice

Related Objects

Event Timeline

valerio.bozzolan created this task.Jul 6 2023, 19:43
valerio.bozzolan triaged this task as Wishlist priority.
valerio.bozzolan created this object in space S1 Public.
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptJul 6 2023, 19:43
valerio.bozzolan renamed this task from Differential: Update Patch is a dead end in some cases to Differential: Update Patch should not lose the "Repository" field.Jul 6 2023, 19:44
valerio.bozzolan added a revision: D25338: Attach Diff to Revision: fix Repository asked twice.Jul 7 2023, 06:22
valerio.bozzolan claimed this task.Jul 7 2023, 06:29
valerio.bozzolan moved this task from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.

In an early version I did not consider "do it only in create mode". Now I think the patch D25338 does what we imagine.

avivey renamed this task from Differential: Update Patch should not lose the "Repository" field to When creating revision from revision from raw diff, "Repository" field is lost.Jul 7 2023, 06:47
valerio.bozzolan added a comment.EditedJul 7 2023, 06:48

Thanks :) Silly question since I'm not native English: is there a repetition in "creating revision from revision from raw diff"?

avivey subscribed.Jul 7 2023, 06:55

yeah, typo. I'll fix it again...

avivey renamed this task from When creating revision from revision from raw diff, "Repository" field is lost to When creating revision from raw diff, "Repository" field is lost.Jul 7 2023, 06:55
valerio.bozzolan added a comment.Jul 12 2023, 14:02

Unsure if tagging as Bug Reports

valerio.bozzolan closed this task as Resolved by committing rP0f07c07b3bc3: Attach Diff to Revision: fix Repository asked twice.Jul 22 2023, 11:55
valerio.bozzolan added a commit: rP0f07c07b3bc3: Attach Diff to Revision: fix Repository asked twice.
valerio.bozzolan merged a task: T15252: Using a raw git diff asks for repository, then loses it.Aug 2 2023, 21:31
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0