Page MenuHomePhorge

Update Facebook icon on Auth Provider page
ClosedPublic

Authored by aklapper on Jul 10 2023, 10:09.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 13:56
Unknown Object (File)
Thu, Apr 4, 01:12
Unknown Object (File)
Mon, Apr 1, 08:35
Unknown Object (File)
Mon, Apr 1, 02:22
Unknown Object (File)
Mon, Apr 1, 02:22
Unknown Object (File)
Sat, Mar 30, 16:24
Unknown Object (File)
Sun, Mar 24, 07:17
Unknown Object (File)
Wed, Mar 20, 11:11

Details

Summary

Closes T15545

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Is the file resources/sprite/login_2x/Facebook.png in high definition? it seems a bit grainy

avivey subscribed.

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

This revision is now accepted and ready to land.Jul 11 2023, 08:17

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.

Yeah, that's what I was worried about

Try arc unit --everything ? it would take a while...