Page MenuHomePhorge

Update Facebook icon on Auth Provider page

Authored by aklapper on Jul 10 2023, 10:09.
Referenced Files
Unknown Object (File)
Wed, Sep 20, 23:49
Unknown Object (File)
Mon, Sep 18, 22:43
Unknown Object (File)
Fri, Sep 8, 19:56
Unknown Object (File)
Aug 15 2023, 21:51
Unknown Object (File)
Aug 15 2023, 21:33
Unknown Object (File)
Aug 14 2023, 01:52
Unknown Object (File)
Aug 7 2023, 02:45
Unknown Object (File)
Jul 27 2023, 02:41



Closes T15545

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

Is the file resources/sprite/login_2x/Facebook.png in high definition? it seems a bit grainy

avivey subscribed.

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

This revision is now accepted and ready to land.Jul 11 2023, 08:17

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.

Yeah, that's what I was worried about

Try arc unit --everything ? it would take a while...

This revision was automatically updated to reflect the committed changes.