Page MenuHomePhorge
Differential D25307

Dashboard Tabs: fix action "Move Right"
ClosedPublic
Actions

Authored by valerio.bozzolan on Jun 23 2023, 10:35.
Tags
None
Referenced Files
F3290460: D25307.1742865500.diff
Mon, Mar 24, 01:18
F3285461: D25307.1742801901.diff
Sun, Mar 23, 07:38
F3248641: D25307.1742264839.diff
Mon, Mar 17, 02:27
F3225001: D25307.1742090108.diff
Sat, Mar 15, 01:55
F3114015: D25307.1741144033.diff
Tue, Mar 4, 03:07
F3110464: D25307.1741135664.diff
Tue, Mar 4, 00:47
F3110462: D25307.1741135663.diff
Tue, Mar 4, 00:47
F3110213: D25307.1741134863.diff
Tue, Mar 4, 00:34
View All 20 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15493: Dashboard Tabs: allow to move Right
Commits
rP92861cc1f000: Dashboard Tabs: fix action "Move Right"
Summary

It seems that if you use the "Move Right" action, you can get
an unrelated error message about "Move Left":

This is already the first tab. It can not move any farther to the left.

This happened because there was an incomplete condition.

Closes T15493

Test Plan
  • visit /dashboard/panel/ and create at least two panels (please, owned by you)
  • visit a Dashboard, and add a Tabs Panel
  • take the first Tab: "Move Right"

After this change, "Move Right" now always works.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Jun 23 2023, 10:35
Owners added a reviewer: O1: Blessed Committers.Jun 23 2023, 10:35
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptJun 23 2023, 10:35
valerio.bozzolan requested review of this revision.Jun 23 2023, 10:35
Harbormaster completed remote builds in B586: Diff 1003.Jun 23 2023, 10:35
valerio.bozzolan added inline comments.Jun 23 2023, 10:37
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
322

Note that here it checks $is_next

330

Note that here it was not checking if it was previous (!$is_next)

valerio.bozzolan retitled this revision from Dashboard Tabs: fix Move Right to Dashboard Tabs: fix action "Move Right".Jun 29 2023, 08:36
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan added inline comments.Jul 5 2023, 12:10
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
314

When true: is next.

When false: is previous.

avivey accepted this revision.Jul 6 2023, 07:16
This revision is now accepted and ready to land.Jul 6 2023, 07:16
Closed by commit rP92861cc1f000: Dashboard Tabs: fix action "Move Right". · Explain WhyJul 6 2023, 11:31
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP92861cc1f000: Dashboard Tabs: fix action "Move Right".
valerio.bozzolan mentioned this in Next Up.Jul 6 2023, 11:59
avivey mentioned this in 2023 Week 32.Aug 11 2023, 16:31

Revision Contents
Changeset List

PathSizePackages
src/
applications/
dashboard/
controller/
panel/
2 linesO1: Blessed Committers

Diff 1093

View Options

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0