Page MenuHomePhorge

Dashboard Tabs: fix action "Move Right"
ClosedPublic

Authored by valerio.bozzolan on Jun 23 2023, 10:35.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 17:17
Unknown Object (File)
Mon, May 20, 05:10
Unknown Object (File)
Sat, May 18, 17:23
Unknown Object (File)
Sat, May 18, 10:53
Unknown Object (File)
Sat, May 18, 05:42
Unknown Object (File)
Tue, Apr 30, 06:31
Unknown Object (File)
Tue, Apr 30, 06:31
Unknown Object (File)
Tue, Apr 30, 02:05

Details

Summary

It seems that if you use the "Move Right" action, you can get
an unrelated error message about "Move Left":

This is already the first tab. It can not move any farther to the left.

This happened because there was an incomplete condition.

Closes T15493

Test Plan
  • visit /dashboard/panel/ and create at least two panels (please, owned by you)
  • visit a Dashboard, and add a Tabs Panel
  • take the first Tab: "Move Right"

After this change, "Move Right" now always works.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
322

Note that here it checks $is_next

330

Note that here it was not checking if it was previous (!$is_next)

valerio.bozzolan retitled this revision from Dashboard Tabs: fix Move Right to Dashboard Tabs: fix action "Move Right".Jun 29 2023, 08:36
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
314

When true: is next.

When false: is previous.

This revision is now accepted and ready to land.Jul 6 2023, 07:16