Page MenuHomePhorge

Rebrand: Add "path" entries to PlatformSymbols

Authored by avivey on Jul 10 2023, 20:42.
Referenced Files
Unknown Object (File)
Thu, Sep 21, 02:34
Unknown Object (File)
Sat, Sep 2, 19:59
Unknown Object (File)
Sat, Sep 2, 13:58
Unknown Object (File)
Wed, Aug 30, 03:49
Unknown Object (File)
Aug 26 2023, 09:05
Unknown Object (File)
Aug 7 2023, 20:06
Unknown Object (File)
Aug 4 2023, 22:39
Unknown Object (File)
Jul 30 2023, 04:40



Ref T15006. Change a few places that were mentioning phabricator path.

Test Plan

Mk1 eyeball on each effected page.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Jul 10 2023, 20:42

I wonder why the original author proposed to use pht() here.

Maybe to allow message override (?)

Yeah why not. asd

Premising that if we do not use pht() we are losing string-overriding support. It's weird but maybe our glorious Evan P. wanted to override "phorge/" with → "AHAHAHAHAHALOLPHORGE/". Maybe this could be re-introduced in the future adding a function like getPlatformClientNameLocalized() and getPlatformClientPathLocalized().

This revision is now accepted and ready to land.Aug 15 2023, 07:55

I don't understand why the pht was there - it's a "path", why would it be translated?

Maybe to be it consistent with "super-rebranded-product/" :D I don't know

This revision was automatically updated to reflect the committed changes.