Paths

Table of Contentst

Differential D25343

Rebrand: Add "path" entries to PlatformSymbols
ClosedPublic
Actions

Authored by avivey on Jul 10 2023, 20:42.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15006: Re-brand Phorge

Commits

rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols

Summary

Ref T15006. Change a few places that were mentioning phabricator path.

Test Plan

Mk1 eyeball on each effected page.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Jul 10 2023, 20:42

Owners added a reviewer: O1: Blessed Committers.Jul 10 2023, 20:42

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 10 2023, 20:42

avivey requested review of this revision.Jul 10 2023, 20:42

Harbormaster completed remote builds in B663: Diff 1112.Jul 10 2023, 20:42

lint + php 8 fix

Harbormaster completed remote builds in B664: Diff 1113.Jul 10 2023, 20:52

avivey mentioned this in D25349: Rebrand: Add "path" entries to PlatformSymbols.Jul 15 2023, 19:20

avivey added a parent revision: D25349: Rebrand: Add "path" entries to PlatformSymbols.Jul 15 2023, 19:20

valerio.bozzolan added inline comments.Jul 18 2023, 12:13

src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php
71	I wonder why the original author proposed to use `pht()` here. Maybe to allow message override (?)

avivey mentioned this in rARC726b148afc98: Rebrand: Add "path" entries to PlatformSymbols.Aug 12 2023, 15:41

Yeah why not. asd

Premising that if we do not use pht() we are losing string-overriding support. It's weird but maybe our glorious Evan P. wanted to override "phorge/" with → "AHAHAHAHAHALOLPHORGE/". Maybe this could be re-introduced in the future adding a function like getPlatformClientNameLocalized() and getPlatformClientPathLocalized().

This revision is now accepted and ready to land.Aug 15 2023, 07:55

I don't understand why the pht was there - it's a "path", why would it be translated?

Maybe to be it consistent with "super-rebranded-product/" :D I don't know

Closed by commit rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols. · Explain WhyAug 18 2023, 09:00

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols.

avivey mentioned this in T15618: Lots of "Unknown Object"s referenced from revisions.Aug 18 2023, 09:07

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

daemon/

controller/

PhabricatorDaemonLogViewController.php

3 lines

O1: Blessed Committers

diffusion/

controller/

DiffusionRepositoryEditDeleteController.php

3 lines

O1: Blessed Committers

metamta/

PhabricatorMetaMTAWorker.php

7 lines

O1: Blessed Committers

repository/

query/

PhabricatorRepositoryQuery.php

4 lines

O1: Blessed Committers

infrastructure/

markup/

markuprule/

PhutilRemarkupEvalRule.php

4 lines

O1: Blessed Committers

Diff 1298

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php

Loading...

src/applications/metamta/PhabricatorMetaMTAWorker.php

Loading...

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...

src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php

Loading...