Page MenuHomePhorge
Feed All Stories

Feb 4 2024

avivey committed rPd9919ddb0667: Revert "Added cross-platform default fonts".
Revert "Added cross-platform default fonts"
Feb 4 2024, 21:15
valerio.bozzolan added a watcher for Mastodon admins of @phorge@fosstodon.org: valerio.bozzolan.
Feb 4 2024, 15:00
20after4 added a comment to T15630: Fix Fonts.

Interesting that gnome is considering Inter. Recursive looks really good too. I like that it has both monospace and proportional all in one.

Feb 4 2024, 13:40
aklapper added a comment to T15630: Fix Fonts.

cf a very similar discussion about default fonts in GNOME at https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/issues/52 regarding aspects to take into consideration

Feb 4 2024, 11:37
valerio.bozzolan created Mastodon admins of @phorge@fosstodon.org.
Feb 4 2024, 11:35
valerio.bozzolan added a member for Trusted Contributors: pawka.
Feb 4 2024, 09:38

Feb 3 2024

avivey created T15731: Editing Ponder Comments is broken.
Feb 3 2024, 12:01 · Ponder, Bug Reports
avivey triaged T15722: Phorge is inaccessible while waiting for approval after registration as Wishlist priority.

I'm triaging as "wishlist" for now, but realistically - I don't believe will ever reach a point where we'll try to fix this -- see https://secure.phabricator.com/T13154 for discussion.

Feb 3 2024, 10:39 · Bug Reports, UX
avivey added a comment to Q105: Site is inaccessible while waiting for approval.

Marking as "obsolete" because this has graduated to T15722

Feb 3 2024, 10:34
avivey closed Q105: Site is inaccessible while waiting for approval as obsolete.
Feb 3 2024, 10:34
avivey triaged T15730: Tool to manage Extensions Installation (Phorge) as Wishlist priority.
Feb 3 2024, 10:31 · Extension Development, Phactory: Community Projects, Phorge

Feb 2 2024

20after4 added a comment to D25501: Feed: Do not query and display data of uninstalled applications.

Maybe we can simplify things introducing a commodity "if viewer exists" method like:

Feb 2 2024, 14:57
20after4 accepted D25519: Validate PhabricatorSearchTextField value not to be an array.

This seems reasonable.

Feb 2 2024, 14:54
20after4 added a comment to T15630: Fix Fonts.

Noto seems like a reasonable choice. I personally really like DejaVu Sans a lot.

Feb 2 2024, 14:46
bekay added a comment to T15630: Fix Fonts.

Or what about Inter? It is open source and looks very readable: https://rsms.me/inter/

Feb 2 2024, 08:21

Feb 1 2024

20after4 awarded D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages) a Love token.
Feb 1 2024, 19:27
20after4 awarded D25430: Implement ferret engine in typeahead datasource query for repos a Love token.
Feb 1 2024, 19:26
20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

So apparently the ferret search engine doesn't really have any sort of dynamic ranking. The ranking is entirely based on how many ngrams match the query...with one singular exception - all user results are boosted above everything else.

Feb 1 2024, 19:19 · UX
20after4 claimed T15705: Lower the search ranking of disabled user accounts.

I'll try to figure out a architecturally-appropriate way to do this. The users do get grayed out in the typeahead search, just not on the results pages.

Feb 1 2024, 18:52 · UX
20after4 added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Feb 1 2024, 15:52 · Bug Reports, Differential
aklapper added a revision to T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum): D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Feb 1 2024, 14:12 · Phorge, Arcanist, User-valerio.bozzolan
aklapper updated the summary of D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Feb 1 2024, 14:12
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

Feb 1 2024, 12:09 · Bug Reports, Differential
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

Feb 1 2024, 12:08 · Bug Reports, Differential
valerio.bozzolan changed the visibility for F1271256: coin.mp3.
Feb 1 2024, 12:06
valerio.bozzolan raised the priority of T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out from Normal to High.
Feb 1 2024, 12:03 · Bug Reports, Differential
valerio.bozzolan updated the diff for D25079: Trigger: Add Sound "Coin".

What a lovely day to run a git rebase master to shine

Feb 1 2024, 11:56
valerio.bozzolan added a project to T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum): Phorge.
Feb 1 2024, 11:42 · Phorge, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15705: Lower the search ranking of disabled user accounts.

Partially related, from the mentioned search it's easy to recognize closed Tasks, but Users are not greyed out when Disabled.

Feb 1 2024, 10:42 · UX
revi asked Q107: Phorge does not recognize IDN not in punycode format.
Feb 1 2024, 07:43

Jan 31 2024

valerio.bozzolan triaged T15729: Remarkup code blocks: guess the language from the "name" (if available) as Low priority.
Jan 31 2024, 17:16 · User-valerio.bozzolan, Remarkup
valerio.bozzolan closed Q88: Phorge upgrade error PhutilURI::checkHrefType() as resolved.
Jan 31 2024, 07:20

Jan 30 2024

speck added a comment to D25301: Diffusion: add "Permalink" button.

I’m not sure about Permalink being a top-level button. Maybe under the View Options menu?

Jan 30 2024, 13:23
valerio.bozzolan added a comment to D25301: Diffusion: add "Permalink" button.

This basically works

Jan 30 2024, 09:55

Jan 29 2024

avivey added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

My concern with removing the applications outright is that they may be in use. Something like ChatLog was deprecated for years before it was removed. I think it might be smart to leave it deprecated for a couple of months.

Jan 29 2024, 07:59
valerio.bozzolan added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

Another thing: deletion of transactions. If by some misfortune they're around, they mess up during certain things, like T15125.

Jan 29 2024, 06:32
Matthew added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

Should we deprecate these first, before complete removal? (if easy)

Jan 29 2024, 04:49

Jan 28 2024

sirocyl added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I never totally understood what the jobs of Fund and Phortune really were, and they weren't explained very well in the documentation, as if they were very Phacility-only tools that happened to be in Phabricator.

Jan 28 2024, 20:25
aklapper added a comment to D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.

@valerio.bozzolan Thanks. I guess I owe you a drink next weekend :)

Jan 28 2024, 18:17
valerio.bozzolan accepted D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.

Believe me or not but I've spent 15 intense minutes to use my big eyes to check all 571 files to catch whatever line that had not the very same class name A/B.

Jan 28 2024, 17:46
aklapper closed D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.
Jan 28 2024, 16:10
aklapper committed rP064424c1b755: Add getQueryApplicationClass() to *TransactionQuery.php classes.
Add getQueryApplicationClass() to *TransactionQuery.php classes
Jan 28 2024, 16:10
valerio.bozzolan accepted D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

sgtm

Jan 28 2024, 16:08
aklapper requested review of D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Jan 28 2024, 15:59
aklapper accepted D25530: Revert "Added cross-platform default fonts".
Jan 28 2024, 15:56
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

@valerio.bozzolan: Which problem would that solve? :)

Jan 28 2024, 15:53
valerio.bozzolan added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

Should we deprecate these first, before complete removal? (if easy)

Jan 28 2024, 15:37
valerio.bozzolan edited the content of Next Up.
Jan 28 2024, 15:27
bekay closed T15645: Implement "Locate File" input in Browse view as Resolved.

I have landed my solution.

Jan 28 2024, 12:18 · Diffusion
bekay updated the task description for T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:17 · Discussion Needed, Diffusion
bekay created T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:12 · Discussion Needed, Diffusion
bekay closed D25521: Adds "Locate File" input to every browse directory view in Diffusion.
Jan 28 2024, 11:51
bekay committed rP87db48289705: Adds "Locate File" input to every browse directory view in Diffusion.
Adds "Locate File" input to every browse directory view in Diffusion
Jan 28 2024, 11:51
bekay closed D25523: Add flexible line height to remarkup headers.
Jan 28 2024, 11:45
bekay closed T15716: Remarkup header have a fixed line height and are less readable with increased size as Resolved by committing rPf8db94f2bfbe: Add flexible line height to remarkup headers.
Jan 28 2024, 11:45 · Discussion Needed, Remarkup
bekay committed rPf8db94f2bfbe: Add flexible line height to remarkup headers.
Add flexible line height to remarkup headers
Jan 28 2024, 11:45

Jan 27 2024

pppery added a comment to T15722: Phorge is inaccessible while waiting for approval after registration.

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

Jan 27 2024, 22:20 · Bug Reports, UX
aklapper planned changes to D25531: Remove dysfunctional Fund and Phortune prototype applications.

Test Plan still to be fully executed thus setting "Plan Changes"

Jan 27 2024, 13:30
aklapper requested review of D25531: Remove dysfunctional Fund and Phortune prototype applications.
Jan 27 2024, 13:29
aklapper added a revision to T15726: Remove dysfunctional Fund and Phortune prototype applications: D25531: Remove dysfunctional Fund and Phortune prototype applications.
Jan 27 2024, 13:29
aklapper renamed T15726: Remove dysfunctional Fund and Phortune prototype applications from Phortune: Stripe Payments Account API changes to Remove dysfunctional Fund and Phortune prototype applications.
Jan 27 2024, 13:28
aklapper closed T15727: Update external timezone information file from 2016 as Resolved by committing rP6a30dc039ea5: Update external timezone information.
Jan 27 2024, 12:29
aklapper closed D25529: Update external timezone information.
Jan 27 2024, 12:29
aklapper committed rP6a30dc039ea5: Update external timezone information.
Update external timezone information
Jan 27 2024, 12:29
aklapper added a comment to D25529: Update external timezone information.

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

Jan 27 2024, 12:28
aklapper updated the test plan for D25529: Update external timezone information.
Jan 27 2024, 12:20
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

Makes sense.
Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]
arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=c0191a039293)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:345]
Jan 27 2024, 12:12
avivey added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

+1 for "delete". Also Fund (which is basically a demo for Phortune).

Jan 27 2024, 10:42
avivey requested review of D25530: Revert "Added cross-platform default fonts".
Jan 27 2024, 10:28
avivey added a reverting change for D25021: Added cross-platform default fonts: D25530: Revert "Added cross-platform default fonts".
Jan 27 2024, 10:28
avivey added a reverting change for rPf8ffa393c442: Added cross-platform default fonts: D25530: Revert "Added cross-platform default fonts".
Jan 27 2024, 10:28
avivey added a revision to T15630: Fix Fonts: D25530: Revert "Added cross-platform default fonts".
Jan 27 2024, 10:28
avivey accepted D25529: Update external timezone information.
Jan 27 2024, 10:19
aklapper added a comment to D25529: Update external timezone information.

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

Jan 27 2024, 08:35
aklapper requested review of D25529: Update external timezone information.
Jan 27 2024, 08:33
aklapper added a revision to T15727: Update external timezone information file from 2016: D25529: Update external timezone information.
Jan 27 2024, 08:33
aklapper closed D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 27 2024, 08:20
aklapper closed T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Jan 27 2024, 08:20 · PHP 8 support
aklapper closed T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune as Resolved by committing rPc0191a039293: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 27 2024, 08:20 · PHP 8 support
aklapper committed rPc0191a039293: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune
Jan 27 2024, 08:20
aklapper created T15727: Update external timezone information file from 2016.
Jan 27 2024, 08:19
aklapper updated the test plan for D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 27 2024, 07:23

Jan 26 2024

speck added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I believe it was originally made for Phacility to accept donations and then process payments for paid support, neither of which we want at Phorge, and I doubt is used elsewhere. Removing seems fine to me.

Jan 26 2024, 20:47
speck accepted D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 26 2024, 20:39
aklapper created T15726: Remove dysfunctional Fund and Phortune prototype applications.
Jan 26 2024, 18:24
aklapper requested review of D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 26 2024, 18:13
aklapper added a revision to T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune: D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 26 2024, 18:13 · PHP 8 support
aklapper created T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Jan 26 2024, 18:12 · PHP 8 support
aklapper created T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.
Jan 26 2024, 17:52 · PHP 8 support
speck added inline comments to D25526: Avoid exception in revision timeline when left diff does not exist.
Jan 26 2024, 14:19
avivey updated the diff for D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

Counter-diff: Keep the hackiness confined

Jan 26 2024, 13:48
avivey added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

The more I look at the code, the less I understand the comment about "just use getIsNewObject()".

Jan 26 2024, 13:39
20after4 accepted D25527: Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField.
Jan 26 2024, 13:30
aklapper added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

In an ideal world 1030-1313 could become just:

Jan 26 2024, 11:14
aklapper requested review of D25527: Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField.
Jan 26 2024, 11:01
aklapper added a revision to T15723: Convert "Page Size" field in ManiphestTaskSearchEngine.php to PhabricatorSearchIntField: D25527: Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField.
Jan 26 2024, 11:01
aklapper created T15723: Convert "Page Size" field in ManiphestTaskSearchEngine.php to PhabricatorSearchIntField.
Jan 26 2024, 10:55
aklapper requested review of D25526: Avoid exception in revision timeline when left diff does not exist.
Jan 26 2024, 10:42
aklapper added a revision to T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php: D25526: Avoid exception in revision timeline when left diff does not exist.
Jan 26 2024, 10:42
valerio.bozzolan added a comment to T15713: Phorge stickers.

I was able to recover the layout in PNG at least. Imagine this 3''x2''. Here:

Jan 26 2024, 10:27 · Blessed Communicators, Phorge