Page MenuHomePhorge

Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField
AcceptedPublic

Authored by aklapper on Jan 26 2024, 11:01.
Tags
None
Referenced Files
F2166485: D25527.id1665.diff
Sat, Apr 27, 03:29
Unknown Object (File)
Thu, Apr 25, 22:40
Unknown Object (File)
Wed, Apr 17, 18:22
Unknown Object (File)
Wed, Apr 17, 06:56
Unknown Object (File)
Sat, Mar 30, 15:55
Unknown Object (File)
Sat, Mar 30, 15:40
Unknown Object (File)
Sat, Mar 30, 15:36
Unknown Object (File)
Sat, Mar 30, 06:37

Details

Summary

Convert the "Page Size" field from PhabricatorSearchTextField to PhabricatorSearchIntField as its input should be an integer value (the number of tasks to display in the query results).

Closes T15723

Test Plan
  • Go to /maniphest/query/advanced/
  • enter random values in the Page Size field and run random Maniphest queries (example values: 13, 0, -13, foobar, foo13bar, -foo1313, 13.5, -13.5, 13,5, -13,5, -, -0).

Diff Detail

Repository
rP Phorge
Branch
maniphestPageSizeFieldInt (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1044
Build 1044: arc lint + arc unit