In T15726#15431, @valerio.bozzolan wrote:

Should we deprecate these first, before complete removal? (if easy)

In D25388#13885, @avivey wrote:

In D25388#13843, @Matthew wrote:

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

I feel like that kind of task will just fall down into oblivion....

In T15671#14420, @avivey wrote:

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Maybe this can be done as an extension:

• Abstract the "profile picture provider"
• Allow an extension to write a Gravatar one

There are currently 2-3 sources, so maybe there is some abstraction:

• pokemon-style silhouette
• Character with background (generated from username)
• Upload Picture

I like renaming the function!

1 comment...

In D25362#13135, @speck wrote:

Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context.

Change PHID list to have new lines instead of commas

In D25362#12819, @valerio.bozzolan wrote:

Hi @Matthew can I help in landing this useful change?

Here is the homepage feed after I created this task. Nothing indicates that there was a task creation, just a triage:

LGTM

LGTM

LGTM

Please fix unit errors

I see no problem with consistency.

Address code review comments

Sorry, didn't see your earlier ping. Approved.

In D25362#10494, @valerio.bozzolan wrote:

Can I amend this change fixing spaces? I have some time to waste right now and I love this kind of "del del del" ihih

Unfortunately, PHPStorm defaults to four spaces. I'm not really willing to spend a ton of time arguing with it (especially since my day job requires four spaces) ... though it would be helpful if we could come up with some clear code rules and them implement them in the repository using phpcs.

Adjust spacing

Fix lint errors

Here are some screenshots of this change in action:

In T15568#12244, @valerio.bozzolan wrote:

every extension should have its own

Ah, yeah, even better I think, if possible

In T15568#12239, @avivey wrote:

I was thinking of adding a script to ./bin to manage (mostly add/remove from load-libraries, maybe also clone) extensions.

@brainchild We receive feature requests here, and we have the choice to decline them here. The admin team has discussed it, we have decided that the current database setup works best for Phorge as is discussed in the documents avivey has linked. As such, changes will not be made to Phorge's database architecture at this time. If you are looking for something to provision with Softaculous, please consider a different solution.

I'd like to give this a shot, as part of streamlining extensions as discussed in T15568

While Deploy Keys do not appear to be the tool, I just configured a new Personal Access Token that's tied to the PhorgeIt organization. If there are any issues, please open a new task and assign it to me, I'll take a look.

Looks good to me.

LGTM

In T15206#5910, @valerio.bozzolan wrote:

In T15206#5663, @avivey wrote:

Looks like it's @chris that controls phorgelabs.

Also thank you @chris for setting yourself as a public user here https://github.com/orgs/phorgelabs/people so people can understand this

Whereas it would be nice for me to understand this duplication

Ship it!

LGTM

Sure, done.

Please rebase and resubmit, there is a merge conflict.

This does not land cleanly, please merge from master and re-submit.

In D25060#1987, @valerio.bozzolan wrote:

Hi @Matthew I think I cannot run arc land since I'm not in Blessed Committers

Well, I did ask for this to be converted into a revision, so I'm OK getting added as a reviewer. Sorry for the delay, I've been on vacation.