HomePhorge

Fix broken file PHID extraction that causes Pholio uploads to crash

Description

Fix broken file PHID extraction that causes Pholio uploads to crash

Summary:
A commit earlier this year modified the structure of the file upload transaction data value, by nesting the array of file upload PHIDs in another array.
The extractFilePHIDs method was not updated to deal with that change though, therefore new mock uploads via Pholio would crash.
This patch fixes that method so it can process the updated transaction data.

Resolves T15105

Test Plan: Patched my live Phabricator installation with this fix and successfully uploaded new Pholio mockups.

Reviewers: O1 Blessed Committers, Cigaryno, Matthew

Reviewed By: O1 Blessed Committers, Cigaryno, Matthew

Subscribers: Matthew, speck, tobiaswiese, valerio.bozzolan, Cigaryno

Tags: Pholio

Maniphest Tasks: T15105

Differential Revision: https://we.phorge.it/D25058

Details

Provenance
tiguchiAuthored on Fri, Nov 11, 20:06
MatthewCommitted on Fri, Nov 11, 20:10
MatthewPushed on Fri, Nov 11, 20:10
Reviewer
O1: Blessed Committers
Differential Revision
D25058: Fix broken file PHID extraction that causes Pholio uploads to crash
Parents
rPabb693962d32: Update sprite sheets
Branches
Unknown
Tags
Unknown
References
HEAD -> master
Tasks
T15105: Cannot upload new mockups via Pholio