Page MenuHomePhorge

tiguchi (Thomas Iguchi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 14 2021, 22:56 (72 w, 3 d)
Availability
Available

Recent Activity

Nov 2 2022

tiguchi added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Maybe the milestone reordering feature could be behind an opt-in toggle? Personally I don't see any problem with that and I'm also not sure why milestones have to be strictly sequential in the first place. I found myself creating milestones accidentally out of sequence and the only way to "reorder" was renaming the milestones, which felt quite punishing.

Nov 2 2022, 20:28 · Phorge Upstream

Oct 21 2022

tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

Oct 21 2022, 15:11 · Pholio
tiguchi requested review of D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 21 2022, 15:09 · Pholio
tiguchi added a revision to T15105: Cannot upload new mockups via Pholio: D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 21 2022, 15:09 · Pholio

Oct 15 2022

tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.

Oct 15 2022, 17:27 · Pholio

Aug 4 2022

tiguchi created T15105: Cannot upload new mockups via Pholio.
Aug 4 2022, 19:01 · Pholio