Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.

I added some debug output to the affected line of code that causes the error message in PholioMockEditor.php on line 212:

public function loadPholioImage($object, $phid) {
  print_r($phid);

  if (!isset($this->images[$phid])) {

The $phid argument is indeed an array of image upload PHID strings:

Array
(
    [0] => PHID-PIMG-2pxae7j2fnbubgpcorxw
)

The caller PholioImageFileTransaction.php is looping over an array of arrays of strings. I also added some debug log output there:

public function extractFilePHIDs($object, $value) {
  $editor = $this->getEditor();

  // NOTE: This method is a little weird (and includes ALL the file PHIDs,
  // including old file PHIDs) because we currently don't have a storage
  // object when called. This might change at some point.

  $new_phids = $value;

  $file_phids = array();

  print_r($value);

The $value argument that is being iterated in a foreach loop shows up as follows:

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )

)

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )

)

to

Array
(
    [0] => PHID-PIMG-2pxae7j2fnbubgpcorxw
)

It seems that commit calls extractFilePHIDs before adjustTransactionValues.

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

In T15105#3252, @tiguchi wrote:

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

Sure, no problem! I'll run the tests on my machine.