Page MenuHomePhorge

Fix broken file PHID extraction that causes Pholio uploads to crash
ClosedPublic

Authored by tiguchi on Oct 21 2022, 15:09.
Tags
Referenced Files
Unknown Object (File)
Sat, Nov 19, 09:56
Unknown Object (File)
Thu, Nov 17, 21:39
Unknown Object (File)
Thu, Nov 17, 07:28
Unknown Object (File)
Fri, Nov 11, 18:42
Unknown Object (File)
Fri, Nov 11, 18:42
Unknown Object (File)
Thu, Nov 10, 12:54
Unknown Object (File)
Wed, Nov 9, 18:43
Unknown Object (File)
Sat, Nov 5, 19:04

Details

Summary

A commit earlier this year modified the structure of the file upload transaction data value, by nesting the array of file upload PHIDs in another array.
The extractFilePHIDs method was not updated to deal with that change though, therefore new mock uploads via Pholio would crash.
This patch fixes that method so it can process the updated transaction data.

Resolves T15105

Test Plan

Patched my live Phabricator installation with this fix and successfully uploaded new Pholio mockups.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tiguchi requested review of this revision.Oct 21 2022, 15:09

The harbormaster has passed and you have properly fixed the bug.

NOTE: This revision is not ready to land because I am not a member of Blessed Committers. It will be ready to land once accepted by members of Blessed Committers.

@tiguchi you don't have to add reviewers yourself.

Well, I did ask for this to be converted into a revision, so I'm OK getting added as a reviewer. Sorry for the delay, I've been on vacation.

This revision is now accepted and ready to land.Fri, Nov 11, 20:09