Page MenuHomePhorge

Add and use new RemarkupMetadata class
Needs ReviewPublic

Authored by Dylsss on Sun, Sep 18, 16:59.
Tags
None
Referenced Files
F185007: D25052.id.diff
Sun, Oct 2, 08:55
F184954: D25052.diff
Sat, Oct 1, 21:27
Unknown Object (File)
Sat, Oct 1, 06:38
Unknown Object (File)
Sat, Oct 1, 06:38
Unknown Object (File)
Sat, Oct 1, 06:38
Unknown Object (File)
Sat, Oct 1, 06:38
Unknown Object (File)
Thu, Sep 29, 23:47
Unknown Object (File)
Thu, Sep 29, 18:22

Details

Summary

Add a new RemarkupMetadata class and use with upload button as well as drag and drop pathways.

Test Plan

Drag and drop file, upload file with button. Check that both files are attached with "attachedFilePHIDs" values.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/RemarkupMetadata.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 87
Build 87: arc lint + arc unit

Event Timeline

Dylsss requested review of this revision.Sun, Sep 18, 16:59

Differentiate between metadata of different text areas using node ID. e.g., new comment text areas and text areas in the edit comment dialog.

Bear with me here, because Javeline (like all js frameworks) is confusing to me.

I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
260–264

is metadata gets automatically inserted into something? I don't see it being manually saved.