Page MenuHomePhorge

Fix icon background color when using Dark Mode
ClosedPublic

Authored by bob on Aug 11 2023, 12:10.
Tags
None
Referenced Files
F2324612: D25384.1721757466.diff
Mon, Jul 22, 17:57
Unknown Object (File)
Sun, Jul 21, 16:15
Unknown Object (File)
Wed, Jul 17, 22:04
Unknown Object (File)
Wed, Jul 17, 09:24
Unknown Object (File)
Sat, Jul 13, 16:38
Unknown Object (File)
Thu, Jul 11, 22:33
Unknown Object (File)
Thu, Jul 11, 21:56
Unknown Object (File)
Thu, Jul 11, 20:33

Details

Summary

This CSS fix replaces the hard coded background gradient (white) value of icons when using Dark Mode.

Now the "Choose User Icon" popup has visible icons.

BeforeAfter
Choose User Icon Dark Mode - Broken.png (329×582 px, 14 KB)
Choose User Icon Dark Mode - Fixed.png (329×582 px, 16 KB)

Ref T15056

Test Plan
  • Flush all Phorge caches
  • Sign in
  • Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
  • Go to user's profile, edit profile and click on Choose icon.
  • Check that now the icons in "Choose User Icon" are visible.
  • Do these steps for each user interface theme in order to check against regression.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 11 2023, 12:10
This comment was removed by bob.
This revision is now accepted and ready to land.Aug 11 2023, 16:30

Thanks

Please also manually run this

./bin/celerity map

(Sorry for that - needs a fix in T15209)

Updating D25384: Update celerity map

I've updated the celerity map, let me know if I've the green light to land the revision!

valerio.bozzolan edited the summary of this revision. (Show Details)

Yeah bob this change was already accepted, and now it's super-accepted. This change is adorable, thanks!