Ref T15554. The plan is to add a new listener that will only listen to DEPRECATED events, and do something useful with them.
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15554: Handling PHP deprecations: convert to Setup Issues
Yes, I should probably have one.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- no-deprect-death
- Lint
Lint Errors Severity Location Code Message Error src/filesystem/PhutilErrorLog.php:31 XHP20 Tautological Expression - Unit
Tests Passed - Build Status
Buildable 747 Build 747: arc lint + arc unit
Event Timeline
Comment Actions
There are, in total, 3 call-sites to setErrorListener - in for the daemons, one for dark-console, and one (PhutilErrorLog) that lives in arcanist but is only used by the SSHD scripts.
Notably, that means the the listener function isn't used when running arc, and probably also in any of the scripts in phorge/bin/.