Page MenuHomePhorge

PhutilErrorHandler: support multiple error listeners
Changes PlannedPublic

Authored by avivey on Aug 11 2023, 19:03.
Referenced Files
Unknown Object (File)
Thu, Sep 21, 05:59
Unknown Object (File)
Mon, Sep 4, 14:22
Unknown Object (File)
Wed, Aug 30, 11:59
Unknown Object (File)
Wed, Aug 30, 04:51
Unknown Object (File)
Tue, Aug 29, 17:39
Unknown Object (File)
Fri, Aug 25, 18:37
Unknown Object (File)
Aug 23 2023, 06:21
Unknown Object (File)
Aug 21 2023, 21:40



Ref T15554. The plan is to add a new listener that will only listen to DEPRECATED events, and do something useful with them.

Test Plan

Yes, I should probably have one.

Diff Detail

rARC Arcanist
Lint Errors
Errorsrc/filesystem/PhutilErrorLog.php:31XHP20Tautological Expression
Tests Passed
Build Status
Buildable 747
Build 747: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Aug 11 2023, 19:03
avivey planned changes to this revision.Aug 11 2023, 19:03

There are, in total, 3 call-sites to setErrorListener - in for the daemons, one for dark-console, and one (PhutilErrorLog) that lives in arcanist but is only used by the SSHD scripts.

Notably, that means the the listener function isn't used when running arc, and probably also in any of the scripts in phorge/bin/.

avivey planned changes to this revision.Aug 12 2023, 06:51