Page MenuHomePhorge

Members page of Parent Subproject: less dead-end
ClosedPublic

Authored by valerio.bozzolan on Apr 19 2023, 14:46.

Details

Summary

When you visit the Members page of a Parent Subproject,
some actions are greyed out by design. And, if you click on
them, nothing really useful happens to continue with what
you want to do.

For example, see this page and click on "Join Project":

https://we.phorge.it/project/members/1/

After this change, the interface at least provides a link to
proceed to the next step of what you wanted to do - that is -
allowing to quickly list direct Subprojects and do something
more meaningful than that.

A/B for the "Join Project" view:

BeforeAfter
Projects: Join Project (Before).png (165×582 px, 14 KB)
Subproject: Join Project (After).png (165×582 px, 15 KB)

A/B for the "Add Members" view:

BeforeAfter
Subproject: Add Member (Before).png (165×582 px, 14 KB)
Subprojects: Add Members (After).png (165×582 px, 15 KB)

Just to be nice, this change adds some inline documentation
on some methods of AphrontDialogView used here.

Closes T15258

Test Plan
  • Create a Project (A) with a Subproject (B)
  • Visit Members page of (A)
  • Click on Join Project and click on the Blue Button
  • Click on the Add Member and click on Blue Button
  • in both cases it should get you to Subprojects list

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan retitled this revision from Parent Subproject: Members page: actions a bit less dead-end to Members page of Parent Subproject: less dead-end.Apr 20 2023, 06:55

Ciao @Matthew 😬

What do you think about this stupid change?

BeforeAfter
Projects: Join Project (Before).png (165×582 px, 14 KB)
Subproject: Join Project (After).png (165×582 px, 15 KB)

Steps to Reproduce:

  1. visit a Root Project
  2. click Join
This revision is now accepted and ready to land.Apr 25 2023, 18:45